chore: rename normalize-color to normalize-colors (umbrella 480) #34571

Titozzz · 2022-09-02T09:02:51Z

Summary

Changelog

[General] [Changed] - Rename normalize-color to normalize-colors as part of react-native-community/discussions-and-proposals#480

Test Plan

github-actions · 2022-09-02T09:03:58Z

	Warnings
⚠️	🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against d7b39e7

facebook-github-bot · 2022-09-02T09:26:19Z

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2022-09-02T09:27:22Z

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

analysis-bot · 2022-09-02T09:30:55Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,103,618	+57
android	hermes	armeabi-v7a	6,471,949	+63
android	hermes	x86	7,521,258	+55
android	hermes	x86_64	7,380,136	+55
android	jsc	arm64-v8a	8,971,262	+2,863
android	jsc	armeabi-v7a	7,702,367	+2,862
android	jsc	x86	9,033,571	+2,865
android	jsc	x86_64	9,511,602	+2,853

Base commit: 2d1d61a
Branch: main

analysis-bot · 2022-09-02T10:31:33Z

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 2d1d61a
Branch: main

cortinico · 2022-09-15T13:35:58Z

packages/normalize-colors/BUCK

@@ -2,7 +2,7 @@ load("@fbsource//tools/build_defs/third_party:yarn_defs.bzl", "yarn_workspace")
 load("@fbsource//xplat/js:JS_DEFS.bzl", "rn_library")

 rn_library(
-    name = "normalize-color",


Commenting here but valid for the whole PR:

Let's undo the BUCK update and the path change. It will make easier for us to import and merge this change 👍

I've also posted an update on the monorepo effort there:

☂️ React Native Monorepo #34692

cortinico · 2022-09-23T12:30:25Z

BUCK

@@ -769,7 +769,7 @@ rn_library(
        "//xplat/js/RKJSModules/vendor/react-test-renderer:react-test-renderer",
        "//xplat/js/RKJSModules/vendor/scheduler:scheduler",
        "//xplat/js/react-native-github/packages/assets:assets",
-        "//xplat/js/react-native-github/packages/normalize-color:normalize-color",
+        "//xplat/js/react-native-github/packages/normalize-colors:normalize-color",


This should also be reverted.

cortinico · 2022-09-23T12:32:03Z

packages/normalize-colors/package.json

  "description": "Color normalization for React Native.",
  "repository": {
    "type": "git",
    "url": "git@github.com:facebook/react-native.git",
-    "directory": "packages/normalize-color"
+    "directory": "packages/normalize-colors"


This should be reverted, alongside the folder renaming

facebook-github-bot · 2022-09-23T13:16:49Z

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2022-09-23T13:17:14Z

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

cipolleschi · 2022-10-04T15:28:22Z

could you rebase this? I'll try to cary this out whenever I have some time.

…n 480)

pull-bot · 2022-11-25T10:36:27Z

PR build artifact for d5554bd is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot · 2022-11-25T10:39:07Z

PR build artifact for d5554bd is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

facebook-github-bot · 2022-11-25T10:55:18Z

@hoxyq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

…recated @react-native/normalize-color

pull-bot · 2022-11-25T13:07:12Z

PR build artifact for d7b39e7 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot · 2022-11-25T13:12:58Z

PR build artifact for d7b39e7 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

facebook-github-bot · 2022-11-25T13:24:31Z

@hoxyq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

react-native-bot · 2022-12-01T16:50:08Z

This pull request was successfully merged by @Titozzz in dc33559.

^{When will my fix make it into a release? | Upcoming Releases}

yungsters · 2022-12-13T15:36:00Z

Should we have also renamed packages/normalize-color{ => s}?

hoxyq · 2022-12-13T16:11:32Z

Should we have also renamed packages/normalize-color{ => s}?

We plan to do all renamings in Phase 4, as discussed in original RFC: react-native-community/discussions-and-proposals#480

…ebook#34571) Summary: ## Changelog  [General] [Changed] - Rename normalize-color to normalize-colors as part of react-native-community/discussions-and-proposals#480 Pull Request resolved: facebook#34571 Reviewed By: cortinico Differential Revision: D39235696 Pulled By: hoxyq fbshipit-source-id: b6d5fcae9fb5c953c2f7b48f73a95cd883ff8f63

Summary: To address the root cause of a recurring issue (#40797, #39692) where breaking changes to `react-native/normalize-colors` would be pulled into old versions of `deprecated-react-native-prop-types`, we recently change the dependency in the latter to use a semver range (facebook/react-native-deprecated-modules#27, #40869). For CI, we generally force `react-native/*` to be resolved only from Verdaccio locally published packages - ie, the current versions at source. The source version (currently `0.74.1`) isn't semver-compatible with `deprecated-react-native-prop-types`'s dependency (`^0.73.0`), so `npm install` was failing in CI with "no package found". We should be getting `0.73.2` from the public registry in this case. This restores a previous workaround added in #34571 but not updated since facebook/react-native-deprecated-modules#11 meant the dependency was now on the pluralised package. We have no dependency on the old non-plural package any more. ## Changelog: [INTERNAL] [FIXED] - CI/Verdaccio: Proxy `react-native/normalize-colors` from NPM for the `deprecated-react-native-prop-types` dependency. Pull Request resolved: #40971 Test Plan: CI Reviewed By: cipolleschi Differential Revision: D50298291 Pulled By: robhogan fbshipit-source-id: 4bf6503108335ffa52654346d1874c217071ff91

Titozzz requested a review from hramos as a code owner September 2, 2022 09:02

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 2, 2022

Titozzz changed the title ~~chore: rename normalize-color to normalize-colors (umbrella discussio…~~ chore: rename normalize-color to normalize-colors (umbrella 480) Sep 2, 2022

facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Sep 2, 2022

Titozzz force-pushed the chore-480-rename-normalize-color branch from 7f1417b to 85f87b4 Compare September 2, 2022 09:04

kelset added the Tech: Monorepo For PRs that are related to the monorepo infra label Sep 12, 2022

cortinico mentioned this pull request Sep 14, 2022

☂️ React Native Monorepo #34692

Closed

11 tasks

cortinico reviewed Sep 15, 2022

View reviewed changes

Titozzz force-pushed the chore-480-rename-normalize-color branch from 02bb773 to 4abf495 Compare September 23, 2022 12:13

cortinico reviewed Sep 23, 2022

View reviewed changes

hoxyq mentioned this pull request Nov 10, 2022

chore: rename polyfills to js-polyfills (umbrella 480) #34574

Closed

Titozzz added 3 commits November 25, 2022 09:29

chore: rename normalize-color to normalize-colors (umbrella discussio…

fab925f

…n 480)

revert buck changes

b0d376e

revert renaming

d5554bd

hoxyq force-pushed the chore-480-rename-normalize-color branch from e874737 to d5554bd Compare November 25, 2022 09:30

feat(@react-native/normalize-colors): update yarn.lock to inclode dep…

d7b39e7

…recated @react-native/normalize-color

facebook-github-bot closed this in dc33559 Dec 1, 2022

react-native-bot added the Merged This PR has been merged. label Dec 1, 2022

robhogan mentioned this pull request Oct 14, 2023

[CI] Verdaccio: proxy @react-native/normalize-colors from NPM #40971

Closed

buraks mentioned this pull request Aug 5, 2024

@react-native/normalize-color => @react-native/normalize-colors EvanBacon/expo-apple-targets#36

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: rename normalize-color to normalize-colors (umbrella 480) #34571

chore: rename normalize-color to normalize-colors (umbrella 480) #34571

Titozzz commented Sep 2, 2022 •

edited

Loading

github-actions bot commented Sep 2, 2022 •

edited

Loading

facebook-github-bot commented Sep 2, 2022

facebook-github-bot commented Sep 2, 2022

analysis-bot commented Sep 2, 2022 •

edited

Loading

analysis-bot commented Sep 2, 2022 •

edited

Loading

cortinico Sep 15, 2022

Titozzz Sep 23, 2022

cortinico Sep 23, 2022

cortinico Sep 23, 2022

facebook-github-bot commented Sep 23, 2022

facebook-github-bot commented Sep 23, 2022

cipolleschi commented Oct 4, 2022

pull-bot commented Nov 25, 2022

pull-bot commented Nov 25, 2022

facebook-github-bot commented Nov 25, 2022

pull-bot commented Nov 25, 2022

pull-bot commented Nov 25, 2022

facebook-github-bot commented Nov 25, 2022

react-native-bot commented Dec 1, 2022

yungsters commented Dec 13, 2022

hoxyq commented Dec 13, 2022

chore: rename normalize-color to normalize-colors (umbrella 480) #34571

chore: rename normalize-color to normalize-colors (umbrella 480) #34571

Conversation

Titozzz commented Sep 2, 2022 • edited Loading

Summary

Changelog

Test Plan

github-actions bot commented Sep 2, 2022 • edited Loading

facebook-github-bot commented Sep 2, 2022

facebook-github-bot commented Sep 2, 2022

analysis-bot commented Sep 2, 2022 • edited Loading

analysis-bot commented Sep 2, 2022 • edited Loading

cortinico Sep 15, 2022

Choose a reason for hiding this comment

Titozzz Sep 23, 2022

Choose a reason for hiding this comment

cortinico Sep 23, 2022

Choose a reason for hiding this comment

cortinico Sep 23, 2022

Choose a reason for hiding this comment

facebook-github-bot commented Sep 23, 2022

facebook-github-bot commented Sep 23, 2022

cipolleschi commented Oct 4, 2022

pull-bot commented Nov 25, 2022

pull-bot commented Nov 25, 2022

facebook-github-bot commented Nov 25, 2022

pull-bot commented Nov 25, 2022

pull-bot commented Nov 25, 2022

facebook-github-bot commented Nov 25, 2022

react-native-bot commented Dec 1, 2022

yungsters commented Dec 13, 2022

hoxyq commented Dec 13, 2022

Titozzz commented Sep 2, 2022 •

edited

Loading

github-actions bot commented Sep 2, 2022 •

edited

Loading

analysis-bot commented Sep 2, 2022 •

edited

Loading

analysis-bot commented Sep 2, 2022 •

edited

Loading