Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename polyfills to js-polyfills (umbrella 480) #34574

Closed
wants to merge 4 commits into from
Closed

chore: rename polyfills to js-polyfills (umbrella 480) #34574

wants to merge 4 commits into from

Conversation

Titozzz
Copy link
Collaborator

@Titozzz Titozzz commented Sep 2, 2022

Summary

Changelog

[General] [Changed] - Rename polyfills to js-polyfills as part of react-native-community/discussions-and-proposals#480

Test Plan

@Titozzz Titozzz requested a review from hramos as a code owner September 2, 2022 09:40
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 2, 2022
@github-actions
Copy link

github-actions bot commented Sep 2, 2022 •
edited
Loading

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 04943ae

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Sep 2, 2022
@analysis-bot
Copy link

analysis-bot commented Sep 2, 2022 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,103,561 +0
android hermes armeabi-v7a 6,471,886 +0
android hermes x86 7,521,203 +0
android hermes x86_64 7,380,081 +0
android jsc arm64-v8a 8,968,399 +0
android jsc armeabi-v7a 7,699,505 +0
android jsc x86 9,030,706 +0
android jsc x86_64 9,508,749 +0

Base commit: 2d1d61a
Branch: main

@analysis-bot
Copy link

analysis-bot commented Sep 2, 2022 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 2d1d61a
Branch: main

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kelset kelset added the Tech: Monorepo For PRs that are related to the monorepo infra label Sep 12, 2022
@cortinico cortinico mentioned this pull request Sep 14, 2022
Closed
11 tasks
cortinico
cortinico reviewed Sep 15, 2022
View reviewed changes
packages/js-polyfills/BUCK Outdated
@@ -21,8 +21,8 @@ yarn_workspace(
)

rn_library(
name = "polyfills",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting here but valid for the whole PR:

Let's undo the BUCK update and the path change. It will make easier for us to import and merge this change 👍

I've also posted an update on the monorepo effort there:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ✅

cortinico
cortinico reviewed Sep 23, 2022
View reviewed changes
BUCK Outdated
@@ -770,7 +770,7 @@ rn_library(
"//xplat/js/RKJSModules/vendor/scheduler:scheduler",
"//xplat/js/react-native-github/packages/assets:assets",
"//xplat/js/react-native-github/packages/normalize-color:normalize-color",
"//xplat/js/react-native-github/packages/polyfills:polyfills",
"//xplat/js/react-native-github/packages/js-polyfills:polyfills",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be reverted

packages/js-polyfills/package.json Outdated
"description": "Polyfills for React Native.",
"repository": {
"type": "git",
"url": "git@github.com:facebook/react-native.git",
"directory": "packages/polyfills"
"directory": "packages/js-polyfills"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be reverted, alognisde the path renaming

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi
Copy link
Contributor

/rebase

@cortinico
Copy link
Contributor

@Titozzz can you manually rebase this. We can't use /rebase here as this is older

@hoxyq
Copy link
Contributor

hoxyq commented Nov 10, 2022

Hey @Titozzz,

Thanks for working on this, I am now planning to continue your work this and #34571 PRs. There are some changes that we need to introduce before merging this.

Could you please share if this is okay for you?

@Titozzz
Copy link
Collaborator Author

Titozzz commented Nov 10, 2022

@hoxyq do what you have to do 👍 lmk if I can help

@hoxyq hoxyq force-pushed the chore-480-rename-polyfills branch from 75c946c to 57cb25b Compare November 25, 2022 12:52
@hoxyq hoxyq force-pushed the chore-480-rename-polyfills branch from 57cb25b to 04943ae Compare November 25, 2022 12:57
@pull-bot
Copy link

PR build artifact for 04943ae is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link

PR build artifact for 04943ae is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot
Copy link
Contributor

@hoxyq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @Titozzz in ca1ae5c.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 26, 2022
@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by 6e9d3bf.

OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
@Titozzz @OlimpiaZurek
chore: rename polyfills to js-polyfills (umbrella 480) (facebook#34574)
61e2214 
Summary:
## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[General] [Changed] - Rename polyfills to js-polyfills as part of react-native-community/discussions-and-proposals#480

Pull Request resolved: facebook#34574

Reviewed By: cipolleschi

Differential Revision: D39268818

Pulled By: hoxyq

fbshipit-source-id: c87807460f27fc83667d18c350a4a847459f056e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico left review comments

@hramos hramos Awaiting requested review from hramos

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Reverted Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. Tech: Monorepo For PRs that are related to the monorepo infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Titozzz @analysis-bot @facebook-github-bot @cipolleschi @cortinico @hoxyq @pull-bot @react-native-bot @kelset