Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving Release Wiki to react-native-website #2961

Merged
merged 16 commits into from
Mar 10, 2022
Merged

Conversation

Megatron4537
Copy link
Contributor

@Megatron4537 Megatron4537 commented Feb 9, 2022

The release wiki can now be found under the community tab

A few things to note:

  • The page url changed from /help to /docs/community. We can change the suffix but for the page to have a left nav bar it needs the prefix docs
  • The page release.md becomes redundant we could consider removing it.

#33014

@facebook-github-bot
Copy link

Hi @Megatron4537!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented Feb 9, 2022

✔️ Deploy Preview for react-native ready!

🔨 Explore the source changes: 10fdf03

🔍 Inspect the deploy log: https://app.netlify.com/sites/react-native/deploys/6229ccb0e32492000800c500

😎 Browse the preview: https://deploy-preview-2961--react-native.netlify.app

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Megatron4537, thank you for picking this task up! 👍

I have take a quick glance on the additions and I have left several question and suggestions. Besides those, we definitely will need to have a formatting and proof-reading pass on the new content, since generally those wiki pages were mostly used internally (and people without the permission in main repo were not able to edit or correct those pages) and now they will be exposed to the larger community.

If you have any questions, feel free to ask them here.

@@ -1430,6 +1430,7 @@ td .label {

.menu__link[href*="dynamiccolorios"]:after,
.menu__link[href*="platformcolor"]:after,
.menu__link[href*="releases"]:after,
Copy link
Collaborator

@Simek Simek Feb 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.menu__link[href*="releases"]:after,

I think that we should mark all of the pages, and ideally the new group with "New" label. Marking only one page looks off, maybe we need to think about support for the label in sidebar groups?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, would be great to have the "new" label on the group

website/versioned_docs/version-0.67/releases.md Outdated Show resolved Hide resolved
website/versioned_docs/version-0.67/release-schedule.md Outdated Show resolved Hide resolved
website/versioned_docs/version-0.67/release-process.md Outdated Show resolved Hide resolved
website/versioned_docs/version-0.67/release-process.md Outdated Show resolved Hide resolved
website/versioned_docs/version-0.67/release-process.md Outdated Show resolved Hide resolved
website/versioned_sidebars/version-0.67-sidebars.json Outdated Show resolved Hide resolved
website/versioned_docs/version-0.67/community.md Outdated Show resolved Hide resolved
website/versioned_sidebars/version-0.67-sidebars.json Outdated Show resolved Hide resolved
@Simek
Copy link
Collaborator

Simek commented Feb 10, 2022

I have also just spotted that you have added the pages manually for the 0.67 version only.

I'm not sure even if we want to version those pages anyway (CC @lunaleaps), but for now it would be best if you move the pages to docs directory (then they will be visible in next version).

@lunaleaps
Copy link
Contributor

I'm not sure even if we want to version those pages anyway (CC @lunaleaps)

Hmm, my instinct is to not have these versioned but I do think there are instruction changes in different versions. Like adding new automation etc. for a new release candidate but I do doubt if it's intuitive to see release instructions for different versions? Maybe? Would love to hear others' thoughts

@cortinico
Copy link
Contributor

Hmm, my instinct is to not have these versioned but I do think there are instruction changes in different versions

+1 on this. I'm not sure how we can separate some docs from being not versioned, but it will definitely reduce the maintenance costs.

@lunaleaps
Copy link
Contributor

@Megatron4537 Is this something you still want to tackle? Let me know if you need help or need to step away from it

@Megatron4537
Copy link
Contributor Author

@Megatron4537 Is this something you still want to tackle? Let me know if you need help or need to step away from it

@lunaleaps Yes, I am just unsure of how to approach it. Which pages should be versioned and which shouldn't be? The implementation is different for versioned and not versioned

@lunaleaps
Copy link
Contributor

lunaleaps commented Feb 24, 2022

@Megatron4537 I think your changes are un-versioned right now which is how we want it.

I would suggest, let's just focus on adding the Release section and something like the FAQ page only in this PR -- we can add each page one by one in a different PR so it's not overwhelming -- how does that sound?

@Megatron4537
Copy link
Contributor Author

@lunaleaps I made the changes with all the pages but a new sidebar if you want to have a look and/or proof-read. We can also opt to have only a few pages to begin with if you think it's more appropriate.

@Simek I made all requested changes except the "New" label for the release group which I don't know how to do with Docusaurus' template.

Let me know if this is what you two had in mind for the sidebar and release process page breakdown.

The only thing untouched is I couldn't add the "New" label to the group with the Docusaurus template.

@Simek
Copy link
Collaborator

Simek commented Feb 25, 2022

@Megatron4537 Thank you for the updates, but you are still working on the 0.67 versioned docs files. To make the pages "unversioned", and detached form the versioning mechanism, you need to place files in website/src/pages directory, you can check out the details here:

Let me know if this is what you two had in mind for the sidebar and release process page breakdown.

The sidebar organization definitely looks better now, it is also something that we can iterate and improve. We need a bit more consistency in the sidebar names (ex. "release/releasing", unified capitalization), also the header to the releases guides can be improved.

The only thing untouched is I couldn't add the "New" label to the group with the Docusaurus template.

"New" label is not that important right now, we can add it later, in the separate PR. It's a custom CSS-based solution, which is not a part of Docusaurus by default so don't worry about that.

@Megatron4537
Copy link
Contributor Author

@Simek Allright, thanks for the quick review!

I understand for the unversioned docs but I can't use the link you referred for this since Pages don't allow use sidebars. Only docs can use sidebars

@Simek
Copy link
Collaborator

Simek commented Feb 25, 2022

I understand for the unversioned docs but I can't use the link you referred for this since Pages don't allow use sidebars. Only docs can use sidebars

@Megatron4537 Docusaurus offers an ability to group the custom pages in the custom sidebars, you can check more details in here:

They also use this on theirs website, for the Community part:

@Megatron4537
Copy link
Contributor Author

@Simek I moved all community pages to their own subfolder. Let me know if there's anything else to do :)

@Simek
Copy link
Collaborator

Simek commented Mar 1, 2022

@Megatron4537 Thank you for all the updates! 👍

Docs structure looks fine now, we can improve it later, it's time to focus on the page naming, page content and formatting.

If you visit the deploy preview, you can see that there are several minor rendering and formatting issues like broken tables, code block with additional whitespace, duplicated headers or missing punctuation marks.

I will try to leave few suggestions later today, but it would be nice to have the native speaker to proof-read those docs.

@kelset
Copy link
Contributor

kelset commented Mar 2, 2022

thanks for doing the work @Megatron4537! I think it's a great starting point to have a bit of a broader conversation - I feel that having the release wiki stuff under the "community" name is super confusing (but it's not your fault!).

So, right now we have a situation with, in the sidebar:

  • Guides
  • Components
  • API
  • Architecture
  • Community
  • Blog

And the community page "Support" is very, very misleading as a name.

So here are a couple of small tweaks that I'd like to propose.

  1. rename the top section "Community" to "Contributing".
    1. "Community Overview" -> "Contributing to React Native"
    2. "Support" page becomes like "How to contribute" landing page saying something like thanks that you want to help, please head over to CONTRIBUTING.md (or migrate the contributing.md here, and have the markdown be the "thanks for contributing, head here for info")
  2. the "community page" from being /help becomes /community, stays as-is and it's only linked via the footer, just like for the showcase

I think that would set everything in a better state. I'm not saying all of it needs to be done in this PR (actually, it'd be probably better to do the above as a separate PR, then rebase this one on top of it)

@Megatron4537 Megatron4537 mentioned this pull request Mar 3, 2022
@Megatron4537
Copy link
Contributor Author

I made this new alternative PR #2989 with your requested changes @kelset

Let me know if there's other changes you'd like

@Simek
Copy link
Collaborator

Simek commented Mar 3, 2022

I made this new alternative PR #2989 with your requested changes @kelset

What's the reason for an additional and separate PR? It is a bit confusing, and makes it harder to suggest further changes.

Also I would like to contribute to your PR during weekend and focus on the formatting and wording, is it fine for you?

@kelset
Copy link
Contributor

kelset commented Mar 3, 2022

What's the reason for an additional and separate PR? It is a bit confusing, and makes it harder to suggest further changes.

@Simek it's on me - I proposed to do as a separate PR to make it easier to review in isolation :) Sorry, I'm a person that prefers that kind of "dividi et impera" approach over having 1 massive PR 😅

But yeah it looks like @Megatron4537 still kept in that other PR all the release wiki changes too which kinds of defeats the purpose of having two separate PRs 😅😅😅 @Megatron4537 can you remove the "release wiki" stuff from the other PR? Or just have all the changes in this PR (and close the other) - either one is fine :)

@kelset
Copy link
Contributor

kelset commented Mar 7, 2022

Just a quick check in - @Simek & @lunaleaps from your perspective, aside the feedbacks Simek has already provided, is this in good shape? Personally I think it's 👍

@lunaleaps
Copy link
Contributor

Yea this is looking good to me!

@lunaleaps
Copy link
Contributor

I'll let @Simek reply and merge if it's good, thanks @Megatron4537 for pushing forward on this! It'll be great to have all this information more visible!

@Simek
Copy link
Collaborator

Simek commented Mar 8, 2022

Since I have updated the page names and structure I will re-request the review.

Also most of the formatting changes and typos were fixed, but I still think that it would be nice to have a pass over (and potentially rephrase) the content of some pages by native speaker.

There are still sections or places which seems to be WIP or not finished, for example the "Dependencies" table comments:

Needs to be clarified (kept up to date by internal team?).

It would be nice to update this, but I think it's not a shipping blocker.


[changelog-pr]: https://github.com/facebook/react-native/labels/%F0%9F%93%9D%20Changelog
[current-release]: https://github.com/facebook/react-native/releases
[changelog-wiki]: https://github.com/facebook/react-native/wiki/Release-Changelog
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[changelog-wiki]: https://github.com/facebook/react-native/wiki/Release-Changelog
[changelog-wiki]: https://github.com/facebook/react-native/wiki/Release-Changelog

It looks like this wiki page do not exist anymore, and link leads to wiki home. Any idea if this has this been moved somewhere else @lunaleaps? Maybe releases WG repo?

Copy link
Collaborator

@Simek Simek Mar 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the GitHub message I see when I try to access the link, which is a bit confusing:
Screenshot 2022-03-08 at 13 16 31

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea let's delete this. I don't think that page exists anymore and I also don't see it being referenced in the markdown.

@Simek Simek self-requested a review March 8, 2022 12:08
id: 'contributing',
path: 'contributing',
routeBasePath: 'contributing',
editCurrentVersion: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useless if the plugin is not versioned

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have editCurrentVersion in mind right? If yes, this has been addressed in the latest commit. 🙂

path: 'contributing',
routeBasePath: 'contributing',
editCurrentVersion: true,
sidebarPath: require.resolve('./sidebarsCommunity.json'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sidebarPath: require.resolve('./sidebarsCommunity.json'),
sidebarPath: require.resolve('./sidebarsContributing.json'),

For consistency?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! 👍

'content-docs',
/** @type {import('@docusaurus/plugin-content-docs').Options} */
({
id: 'contributing',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some options of the main versioned docs instance are missing, is this on purpose?

        showLastUpdateAuthor: false,
        showLastUpdateTime: true,
        editUrl:
          'https://github.com/facebook/react-native-website/blob/master/website/',
        remarkPlugins: [require('@react-native-website/remark-snackplayer')],

As I'm also adding another docs instance in #3000, maybe it should later be refactored so that those docs options are shared over instances?

to: '/help',
label: 'Community',
to: '/contributing/how-to-contribute',
docId: 'contributing',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should either use:

  • docId + type: "doc" + docsPluginId: ''contributing
  • to

not both at the same time

In this case the docId is not used by Docusaurus so you can remove it normally

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed for now in latest commit, but we can adjust this once more later, to merge this with approach in the architecture PR.

Copy link
Contributor

@lunaleaps lunaleaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! I think it's fine if we have some things in typo/unfilled state. We can continue to iterate on smaller PRs to fix.

Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

(after merging this I guess we could rebase #3000 to also unversion this section, right?)

@Simek
Copy link
Collaborator

Simek commented Mar 10, 2022

🚢

(after merging this I guess we could rebase #3000 to also unversion this section, right?)

Heh, I have planned the reversed merge order for this, we are currently finishing the other PR with Sebastien, and we would stay with two additional docs plugins to simplify the paths. 🙂

@kelset
Copy link
Contributor

kelset commented Mar 10, 2022

Heh, I have planned the reversed merge order for this, we are currently finishing the other PR with Sebastien, and we would stay with two additional docs plugins to simplify the paths. 🙂

Sounds good 👍

@Simek
Copy link
Collaborator

Simek commented Mar 10, 2022

Let's change the plans and ship his one first, since we have few small thing to adjust in the New Arch PR, and this one looks ready to merge as-is right now (and there should not be that many conflicts, if any).

I would like to thank @Megatron4537 for the all the work they done in there, that's awesome to have such involved community members like you! ❤️

@Simek Simek merged commit 3607bf2 into facebook:main Mar 10, 2022
sunnylqm added a commit to reactnativecn/react-native-website that referenced this pull request Mar 26, 2022
* Generate 0.67 version of the docs (facebook#2926)

* version 0.67

* Revert "version 0.67"

This reverts commit f4896ac.

* updated v0.67 docs cut

* blogpost for 0.67 (facebook#2933)

* add Lorenzo

* Facebook -> Meta

* 067 blogpost

* add highlights and truncate

* tweak

* Update website/blog/2022-01-19-version-067.md

* Update website/blog/2022-01-19-version-067.md

Co-authored-by: Eli White <github@eli-white.com>

* Move Hermes 0.10 issue callout to acknowledgements

* Link the wiki

Co-authored-by: Luna <lunaleaps@gmail.com>
Co-authored-by: Eli White <github@eli-white.com>

* blogpost: React Native - H2 2021 Recap (facebook#2937)

Co-authored-by: Luna <luwe@fb.com>

* Fix typo in H2 blog post: next year / half -> numbers (facebook#2938)

* Use numbers for the time

* Bump nanoid from 3.1.30 to 3.2.0 (facebook#2939)

Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.30 to 3.2.0.
- [Release notes](https://github.com/ai/nanoid/releases)
- [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md)
- [Commits](ai/nanoid@3.1.30...3.2.0)

---
updated-dependencies:
- dependency-name: nanoid
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* remove text in running on device (facebook#2943)

* remove text on docs running-on-device (facebook#2944)

* Fix small grammatical error (facebook#2942)

* update copyright on website (facebook#2940)

Co-authored-by: luism3861 <Eduardo_Medina@fragua.com.mx>

* Fix flexShrink default value in Layout Props docs (facebook#2945)

* update website font, misc UI tweaks (facebook#2947)

* Fix the guide to the deprecated OpenJDK installation command. (facebook#2817)

* Add function based components example for Flat list optimisation (facebook#2955)

* Update typo in render-pipeline.md (facebook#2951)

* Update typo in tutorial.md (facebook#2946)

* Add an extra command to the troubleshooting guide for typescript template (facebook#2954)

Co-authored-by: Nicola Corti <corti.nico@gmail.com>

* (Image) Fix documentation for onLoad event. (facebook#2964)

* - (Image) Fix documentation for onLoad event.

* - (Image) Prettier.

* Update image.md (facebook#2965)

* Bump follow-redirects from 1.14.7 to 1.14.8 (facebook#2966)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.14.7...v1.14.8)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fixed a typo in Linking page. (facebook#2968)

AndroidManifext.xml should be AndroidManifest.xml

* 📚 Guide: Getting Started with The New Architecture (a.k.a. the Playbook) (facebook#2879)

* Initial Draft of the New Architecture Playbook

* Fix c++ codeblocks not rendering correctly

* Fix Android.mk containing wrong wildcards

* Remove Markdown exports artifacts

* Fix missing parenthesis in section header

* Renamed section header as it was incomplete

* Removed canCreateTurboModule as it was not used

* Fix indententation and add imports to MyComponentsRegistry.java

* Add missing import for MyComponentsRegistry.h

* Fix the broken table

* s/two/three arguments

* Fix comments inside podfile

* split The New Architecture guide into few pages (facebook#2882)

* Fix wrong import for ./RNTMyNativeViewNativeComponent

* Fix import for codegenNativeCommands

* Add a banner for TypeScript support

* Do not sound prescriptive with 'you will be using flow'

* React concurrent mode -> React 18

* Add a banner on homepage about the number of manual steps

* Fix typo on Enabling TurboModule section title

Co-authored-by: Johny Urgiles <jurgiles@users.noreply.github.com>

* code formatting, admonitions and small tweaks (facebook#2922)

Co-authored-by: Nicola Corti <corti.nico@gmail.com>

* Use descriptive component names and fix use of ref (facebook#2935)

* Use descriptive component names and fix use of ref

* Remove ambiguity from migrating .measure* example

* Playbook => Guide

* Use implicit dependency substitution for the Gradle Plugin

* Specify reactRoot and codegenDir in the App setup

* Add a patch for configureNdkBuild not depending on preBuild

* Add the getTurboModule method

* Copy the warning banner on all the pages

* Update pod install to specify RCT_NEW_ARCH_ENABLED

* HermesExecutorFactory header lives inside reacthermes/ and not React/

* Fix broken jsExecutorFactoryForBridge iOS

* Bump used nightly version to 0.0.0-20220201-2008-79975d146

* Clarify the react-native-codegen version to use

* Suggest to use :app:externalNativeBuildDebug instead of Release

* Put LOCAL_SHARED_LIBRARIES on Android.mk on separate lines

* Update docs/new-architecture-app-renderer-ios.md

Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>

* Remove unnecessary duplicated `pod install`

Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>

* Setup a New Architecture Troubleshooting page

* Fix lint failures on troubleshooting section

Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
Co-authored-by: Johny Urgiles <jurgiles@users.noreply.github.com>
Co-authored-by: Samuel Susla <samuel.susla@gmail.com>

* fix(ios): update Fabric in Podfile instructions (facebook#2973)

* fix(ios): update Fabric in Podfile instructions

* move fabric_enabled comment closer to the property

* 📚 Add instruction for M1 users to work with Cocoapods (facebook#2974)

* Update Android SDK version to 30 (facebook#2975)

* Adding Explain Like I'm 5 video to the home page (facebook#2971)

* Adding ELI5 video to the home page

* Remove unused VideoContainer function

* Combining Video and Talk sections

Co-authored-by: Dmitry Vinnik <dvinnik@fb.com>

* Updated expired link in docs/security (facebook#2972)

* Updated link colors to meet WCAG color contrast guidelines. (facebook#2976)

* Bump prismjs from 1.25.0 to 1.27.0 (facebook#2978)

Bumps [prismjs](https://github.com/PrismJS/prism) from 1.25.0 to 1.27.0.
- [Release notes](https://github.com/PrismJS/prism/releases)
- [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md)
- [Commits](PrismJS/prism@v1.25.0...v1.27.0)

---
updated-dependencies:
- dependency-name: prismjs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: spelling error mudule -> module (facebook#2979)

* Update migration guide feedback link to the working group (facebook#2983)

* Add TOC sections for the 'Render, Commit, and Mount' page (facebook#2985)

* Adding Social Banner in Support of Ukraine  (facebook#2986)

* fix layout resizing when page includes wide code block (facebook#2980)

* docs: Moving to use Announcement Banner for the Support Ukraine Initiative (facebook#2988)

* Fix deeplink to react-host-components-or-host-components in Glossary (facebook#2992)

* Clarify intended audience for architecture overview (facebook#2995)

* changed android_hyphenation for 0.67+ (facebook#2982)

* Add missing `normal` enum for Hyphenation (facebook#3002)

* add ToC headers for phases on Render Pipeline page (facebook#2997)

* Moving Release Wiki to react-native-website (facebook#2961)

Co-authored-by: Simek <gosimek@gmail.com>

* Update discrete update threading model diagram (facebook#2999)

* move Fabric warning to partial, use admonition (facebook#2998)

* Clarify the Configure Codegen in your Gradle File section (facebook#2993)

Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>

* Unversion Architecture docs (facebook#3000)

Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>

* refactor(getting-started): path to sdk binaries (facebook#2991)

* bump lint stack, include `website` files in check (facebook#3004)

* Add table of contents and encourage people to leave feedback in working group in Architecture Overview intro (facebook#2996)

* Clarify intended audience for architecture overview
* Fix broken links

* Blogpost: An update on the New Architecture Rollout (facebook#3009)

Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
Co-authored-by: Lorenzo Sciandra <notkelset@kelset.dev>

* Use bundler to pod install (facebook#3011)

* Use placeholders instead of hardcoded strings (facebook#3015)

* Use @flow annotation and fix syntax (facebook#3016)

* Improve documentation about JS Specs (facebook#3017)

* Use more specific dependency React-Core (facebook#3020)

* distinguish windows from mac keytool instructions (facebook#3019)

Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>

* spelling fix (facebook#3021)

* Rename _bridge into bridge (facebook#3013)

* Use empty dicts instead of nil (facebook#3014)

* 📚 Rename JSCExecutorFactory into HermesExecutorFactory (facebook#3012)

* fix codegenNativeCommands section example (facebook#3024)

Co-authored-by: Piotr Trocki <piotr@trocki.com>

* [sync-api] Replace deprecated String.prototype.substr() (facebook#3025)

* Add kotlin sample code in "Integration with an Android Fragment" documentation (facebook#2977)

Co-authored-by: Andrei Shikov <andreiishikov@gmail.com>
Co-authored-by: Nicola Corti <corti.nico@gmail.com>
Co-authored-by: Simek <gosimek@gmail.com>

* small custom CSS fixes and tweaks (facebook#3026)

* Update references from Java to Java/Kotlin in the body of the article (facebook#3028)

Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>

* update project structure in Readme (facebook#3031)

Co-authored-by: Lorenzo Sciandra <notkelset@kelset.dev>
Co-authored-by: Luna <lunaleaps@gmail.com>
Co-authored-by: Eli White <github@eli-white.com>
Co-authored-by: Nicola Corti <ncor@fb.com>
Co-authored-by: Luna <luwe@fb.com>
Co-authored-by: Sota <5866096+sota000@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Luis Medina Huerta <luism3861@gmail.com>
Co-authored-by: Palash Shrivastava <35087196+BattleOfPlassey@users.noreply.github.com>
Co-authored-by: Michael Evans <michaelrevans@live.co.uk>
Co-authored-by: luism3861 <Eduardo_Medina@fragua.com.mx>
Co-authored-by: jzxchiang1 <15524484+jzxchiang1@users.noreply.github.com>
Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
Co-authored-by: 1natsu <1natsu172@users.noreply.github.com>
Co-authored-by: DIBYAJYOTI MISHRA <dibyajyotimishra14@gmail.com>
Co-authored-by: Jiovanna Manriquez <jiovannamanriquez@gmail.com>
Co-authored-by: markbell2410 <24226636+markbell2410@users.noreply.github.com>
Co-authored-by: Nicola Corti <corti.nico@gmail.com>
Co-authored-by: Erick Maeda Lopes <erick.maeda26@gmail.com>
Co-authored-by: Kavanaugh Latiolais <kav@pelo.tech>
Co-authored-by: hj <jiehecd@gmail.com>
Co-authored-by: Johny Urgiles <jurgiles@users.noreply.github.com>
Co-authored-by: Samuel Susla <samuel.susla@gmail.com>
Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
Co-authored-by: Riccardo <riccardo.cipolleschi@gmail.com>
Co-authored-by: Kid <44045911+kidonng@users.noreply.github.com>
Co-authored-by: Dmitry Vinnik <dmitryvinn@users.noreply.github.com>
Co-authored-by: Dmitry Vinnik <dvinnik@fb.com>
Co-authored-by: Vishwa Gaurav <81325730+VishwaGauravIn@users.noreply.github.com>
Co-authored-by: blavalla <blavalla@gmail.com>
Co-authored-by: RayKay91 <61206305+RayKay91@users.noreply.github.com>
Co-authored-by: zegermouw <zegermouw@gmail.com>
Co-authored-by: Nicolas <nicolashortaadam@gmail.com>
Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com>
Co-authored-by: Henry Hobhouse <henryhobhouse@gmail.com>
Co-authored-by: Samuel Susla <samuelsusla@fb.com>
Co-authored-by: Danilo Bürger <info@danilobuerger.de>
Co-authored-by: Riccardo <cipolleschi@fb.com>
Co-authored-by: Fernando Cervera <86963649+fernandocervera-abi@users.noreply.github.com>
Co-authored-by: Rajesh Sharma <broncha@rajesharma.com>
Co-authored-by: troZee <12766071+troZee@users.noreply.github.com>
Co-authored-by: Piotr Trocki <piotr@trocki.com>
Co-authored-by: CommanderRoot <CommanderRoot@users.noreply.github.com>
Co-authored-by: David Vacca <515103+mdvacca@users.noreply.github.com>
Co-authored-by: Andrei Shikov <andreiishikov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants