-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade docusaurus to 2.3.1 & react 18.2 #3618
Conversation
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Thanks for looking at Docusaurus upgrade! 👍 There are few things which need to be done, besides bumping the packages versions in
Broken things I have spotted on quick check:
|
These changes will only start to work once our documentation is updated to support this feature: - facebook/react-native-website#3618 - facebook/react-native-website#3619 - facebook/react-native-website#3620
196b514
to
21846bf
Compare
04f5dbc
to
4f2bf39
Compare
@Simek I think this LGTM now. When you have a moment would you mind looking over it again. I've incorporated the swizzle changes and fixed the issue with showcase. |
Thank you for all the work put into the upgrade! 🙏 Besides the comment about Showcase issue, this LGTM! 👍 Also, it looks like we have broken content container on versions page - https://deploy-preview-3618--react-native.netlify.app/versions - but surprisingly, this already seems to be an issue for PROD deployment, so we can address this in a separate PR. |
8d7e57f
to
bdb9be6
Compare
I'm spamming netifly atm because the issue doesn't reproduce on my locally hosted version. Apologies for the noise. |
430989a
to
b9b852d
Compare
const imgSource = !app.icon.startsWith('http') | ||
? useBaseUrl('img/showcase/' + app.icon) | ||
: app.icon; | ||
const renderApp = (app, i) => <AppBox app={app} key={`app-${app.name}-${i}`} />; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separated the hooks in here from the Showcase component made it simpler to call hooks consistently in Showcase (otherwise we'd get invariant errors).
Showcase looks good, glad you figure it out! To fix the announcement bar styling we will need to change CSS selectors in this section: react-native-website/website/src/css/customTheme.scss Lines 1214 to 1259 in 30f9e3a
Since the class names changed between versions, now we need to use |
b9b852d
to
b57521b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all the updates and great comments on the process, LGTM! 🚀
These changes will only start to work once our documentation is updated to support this feature: - facebook/react-native-website#3618 - facebook/react-native-website#3619 - facebook/react-native-website#3620
These changes will only start to work once our documentation is updated to support this feature: - facebook/react-native-website#3618 - facebook/react-native-website#3619 - facebook/react-native-website#3620
These changes will only start to work once our documentation is updated to support this feature: - facebook/react-native-website#3618 - facebook/react-native-website#3619 - facebook/react-native-website#3620
These changes will only start to work once our documentation is updated to support this feature: - facebook/react-native-website#3618 - facebook/react-native-website#3619 - facebook/react-native-website#3620
* feat: add deeplinks to our documentation These changes will only start to work once our documentation is updated to support this feature: - facebook/react-native-website#3618 - facebook/react-native-website#3619 - facebook/react-native-website#3620 * refactor: decouple our version checks There was a single version check that would log an available stable version of React Native that was greater than the current version in a project. The change breaks that up into: - what is the current version - what is the next stable upgrade if available - log any stable upgrade if available
Upgrade these dependencies, so we can support deep-linking in Tabs.