-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add deeplinks to our documentation #1870
Merged
adamTrz
merged 2 commits into
react-native-community:main
from
blakef:feat-deeplink-support
Mar 20, 2023
Merged
feat: add deeplinks to our documentation #1870
adamTrz
merged 2 commits into
react-native-community:main
from
blakef:feat-deeplink-support
Mar 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakef
commented
Mar 10, 2023
blakef
commented
Mar 10, 2023
blakef
force-pushed
the
feat-deeplink-support
branch
2 times, most recently
from
March 16, 2023 13:28
876d96b
to
36d0f5e
Compare
adamTrz
approved these changes
Mar 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Massive work, thanks for the PR! 🎉
blakef
force-pushed
the
feat-deeplink-support
branch
2 times, most recently
from
March 17, 2023 22:16
b98efe0
to
f70caa5
Compare
@blakef Mind resolving conflicts so we can merge? 🙏 |
These changes will only start to work once our documentation is updated to support this feature: - facebook/react-native-website#3618 - facebook/react-native-website#3619 - facebook/react-native-website#3620
There was a single version check that would log an available stable version of React Native that was greater than the current version in a project. The change breaks that up into: - what is the current version - what is the next stable upgrade if available - log any stable upgrade if available
blakef
force-pushed
the
feat-deeplink-support
branch
from
March 20, 2023 10:06
f70caa5
to
f5477f2
Compare
@adamTrz thanks for all of your support on this PR. Fixed the conflict. |
This is the feature I've been waiting for years :D Thank you @blakef |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Everything is in, so this should be good to tests against.
These changes will only start to work once our documentation is updated to support this feature:The outcome is that we now write links like this:
And get links this:
For more complicated examples you'd write this:
Depending on how the user has run the project. With this result if clicked on:
Test Plan:
I've run this against a locally generated project from
init
. I'll do something more comprehensive, but wanted to get some direction feedback before.