Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update how-to-build-from-source for 0.72+ #3659

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Update how-to-build-from-source for 0.72+ #3659

merged 1 commit into from
Jul 7, 2023

Conversation

cortinico
Copy link
Contributor

@cortinico cortinico commented Mar 29, 2023 •
edited
Loading

With the monorepo changes, the way how we trigger a build from source had to be adapted.

This change is also pending a change on react-native before it can be merged:

As this doc is not versioned, so I think we might want to hold on merging it till 0.72 lands?
On the other hand, the current setup is broken for nightlies and user should use the new instructions.

How do we feel about it?

@cortinico cortinico added the 🕐 Waiting on PR These may be waiting for a PR to the facebook/react-native to be merged label Mar 29, 2023
@netlify
Copy link

netlify bot commented Mar 29, 2023

✅ Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 9ccdaae
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/64244952d7a64300083e6dab
😎 Deploy Preview https://deploy-preview-3659--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cortinico cortinico mentioned this pull request Apr 25, 2023
Closed
@cubuspl42
Copy link

@cortinico What's the general suggested approach for forking React Native? Let's say I found a bug in my app, and the investigation showed that the root cause of that problem lies in React Native itself. I found an issue, I forked the repository, I filed a PR. How can I test those changes in the context of my app?

The docs seem to assume that the changes are applied directly in the node_modules directory, or I'm missing something.

@cortinico
Copy link
Contributor Author

The docs seem to assume that the changes are applied directly in the node_modules directory, or I'm missing something.

Yes that's exactly the case. Your best bet is to either:

  1. Wait for the PR to be merged and us a @nightly
  2. Use the latest @nightly and edit the files in your node_modules + use the approach I suggested in this PR

@cubuspl42
Copy link

@cortinico

  1. Use the latest @nightly and edit the files in your node_modules + use the approach I suggested in this PR

This is not practical to do manually in case of a PR that contains multiple commits and affects multiple files. So I guess that I'd have to come up with some rsync-based approach or something like that.

But thanks, at least I know that I'm not missing something.

@cortinico
Copy link
Contributor Author

cortinico commented Apr 28, 2023 •
edited
Loading

This is not practical to do manually in case of a PR that contains multiple commits and affects multiple files.

Yup I see. The best is to use rn-tester inside the React Native repo to test those changes then 👍

@kelset
Copy link
Contributor

kelset commented May 3, 2023

yeah until the referenced commit is merged this won't work on 0.72 either, so I think the order is:

  • cp commit in 0.72
  • after 0.72 is cut, we merge this

@cortinico cortinico removed the 🕐 Waiting on PR These may be waiting for a PR to the facebook/react-native to be merged label Jul 7, 2023
@cortinico cortinico requested review from Simek and cipolleschi July 7, 2023 08:49
@cortinico
Copy link
Contributor Author

This can now be merged @cipolleschi @Simek

@cipolleschi cipolleschi merged commit 22da0cc into main Jul 7, 2023
@cipolleschi cipolleschi deleted the nc/how-to-build-from-source-0.72+ branch July 7, 2023 09:02
sunnylqm added a commit to reactnativecn/react-native-website that referenced this pull request Aug 5, 2023
@sunnylqm @gabrieldonadel
@huntie @dependabot @blakef @Pranav-yadav @waseemk7 @javache @cortinico @StefanWallin @Azelisi @NickGerleman @flexbox @slorber @connorpmullins @cipolleschi @Simek @kelset @stanleyugwu @duguyihou
0805 sync 0.73 (#734)
fe6e34b 
* Update Debugging docs to no longer recommend Remote debugging (facebook#3702)

Co-authored-by: Alex Hunt <hello@alexhunt.io>

* Bump fast-xml-parser from 4.2.4 to 4.2.5 (facebook#3777)

Bumps [fast-xml-parser](https://github.com/NaturalIntelligence/fast-xml-parser) from 4.2.4 to 4.2.5.
- [Release notes](https://github.com/NaturalIntelligence/fast-xml-parser/releases)
- [Changelog](https://github.com/NaturalIntelligence/fast-xml-parser/blob/master/CHANGELOG.md)
- [Commits](NaturalIntelligence/fast-xml-parser@v4.2.4...v4.2.5)

---
updated-dependencies:
- dependency-name: fast-xml-parser
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Upgrade got dependency (facebook#3776)

* feature: Move to GA4 (UA being reprecated in June)

Google Analytics is deprecating the older clients. This is the first
step to enable to newer client. This should be followed with a step to
remove the old client once we know data is flowing.

* Upgrade got dependency

Resolves dependabot alerts #26

* Use `https` links over `http` (facebook#3761)

* [docs] Update/simplify info around Metro for env setup (facebook#3673)

* [docs] Add Metro guide, update Metro config references (facebook#3772)

* [docs] Remove static config note in Metro guide, adjust formatting (facebook#3782)

* Improving Grammar and Clarity.md (facebook#3783)

Improving Grammar and Clarity in React Native's Performance Description

* Fix docs for onResponderGrant (facebook#3785)

* react-native-gradle-plugin renamed to @react-native/gradle-plugin (facebook#3786)

* Update _integration-with-existing-apps-kotlin.md

* Update _integration-with-existing-apps-kotlin.md

* Update _integration-with-existing-apps-java.md

* Update _integration-with-existing-apps-java.md

* Update _integration-with-existing-apps-kotlin.md

* Update how-to-build-from-source for 0.72+ (facebook#3659)

* Clarify documentation for turbomodules (facebook#3787)

* Clarify documentation for turbomodules

`codegenConfig` is stated in text that it's an array, but in code example it's an object.

Either the text or the code example should change.

* Fix linting issue

* Update the PR to reflect knowledge that the code sample is correct but documentation wrong

* Update FlatList Optimization Guide for FCs (facebook#3700)

* Update FlatList Optimization Guide for FCs

* fix lint

* Update docs/optimizing-flatlist-configuration.md

---------

Co-authored-by: Егорик <86266852+Huinko@users.noreply.github.com>
Co-authored-by: Nick Gerleman <nick@nickgerleman.com>

* [docs] Add guidance on repo build scripts (facebook#3788)

* [docs] add Chain React 2023 playlist link on staying-updated (facebook#3790)

* Bump semver from 5.7.1 to 5.7.2 (facebook#3791)

Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md)
- [Commits](npm/node-semver@v5.7.1...v5.7.2)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Docusaurus v2.4.1 (facebook#3778)

* Bump word-wrap from 1.2.3 to 1.2.4 (facebook#3794)

Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
- [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4)

---
updated-dependencies:
- dependency-name: word-wrap
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* docs: iOS backwards compatibility update (facebook#3775)

* Update backward-compatibility-fabric-components.md

Ensure backwards-compat docs refer to all necessary code changes.

reactwg/react-native-new-architecture#8 (comment)

* Update docs/the-new-architecture/backward-compatibility-fabric-components.md

Co-authored-by: Riccardo Cipolleschi <riccardo.cipolleschi@gmail.com>

* trim whitespace and fix typo

---------

Co-authored-by: Riccardo Cipolleschi <riccardo.cipolleschi@gmail.com>

* [website] swizzle DocVersionBanner, tweak wording (facebook#3800)

* tweak: improve wordiness on docs about bumping monorepo packages (facebook#3805)

* Fix typo in architecture-glossary.md (facebook#3806)

* docs: change js to tsx (facebook#3808)

* Update website to use JDK 17 (facebook#3812)

LGTM.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Gabriel Donadel Dall'Agnol <donadeldev@gmail.com>
Co-authored-by: Alex Hunt <hello@alexhunt.io>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Blake Friedman <blakef@meta.com>
Co-authored-by: Pranav Yadav <Pranavyadav3912@gmail.com>
Co-authored-by: Waseem Kurne <55435990+waseemk7@users.noreply.github.com>
Co-authored-by: Pieter De Baets <pieterdb@meta.com>
Co-authored-by: Nicola Corti <corti.nico@gmail.com>
Co-authored-by: Stefan Wallin <github@stefan-wallin.se>
Co-authored-by: Егорик <86266852+Azelisi@users.noreply.github.com>
Co-authored-by: Егорик <86266852+Huinko@users.noreply.github.com>
Co-authored-by: Nick Gerleman <nick@nickgerleman.com>
Co-authored-by: David Leuliette <dleuliette@gmail.com>
Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com>
Co-authored-by: Connor Mullins <connorpmullins@gmail.com>
Co-authored-by: Riccardo Cipolleschi <riccardo.cipolleschi@gmail.com>
Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
Co-authored-by: Lorenzo Sciandra <lsciandra@microsoft.com>
Co-authored-by: Stanley Ugwu <stanleyugwu2018@gmail.com>
Co-authored-by: kong <duguyihou@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simek Simek Awaiting requested review from Simek

@cipolleschi cipolleschi Awaiting requested review from cipolleschi

Assignees
No one assigned
Labels
CLA Signed p: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cortinico @cubuspl42 @kelset @facebook-github-bot @cipolleschi