Skip to content

Commit

Permalink
Bump NDK to 26.1 (#42656)
Browse files Browse the repository at this point in the history
Summary:

I'm bumping the NDK to 26.1. As we already have a bump lined up to 26.0 on main,
it makes sense to go to .1 as it's declared the LTS:
https://github.com/android/ndk/wiki

Changelog:
[Android] [Changed] - Android NDK to 26.1

Reviewed By: NickGerleman

Differential Revision: D53083606
  • Loading branch information
cortinico authored and facebook-github-bot committed Jan 25, 2024
1 parent e04d1b4 commit 06cad26
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ version =
group = "com.facebook.react"

val ndkPath by extra(System.getenv("ANDROID_NDK"))
val ndkVersion by extra(System.getenv("ANDROID_NDK_VERSION") ?: "26.0.10792818")
val ndkVersion by extra(System.getenv("ANDROID_NDK_VERSION") ?: libs.versions.ndkVersion.get())
val sonatypeUsername = findProperty("SONATYPE_USERNAME")?.toString()
val sonatypePassword = findProperty("SONATYPE_PASSWORD")?.toString()

Expand Down
1 change: 1 addition & 0 deletions packages/react-native/gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ minSdk = "23"
targetSdk = "34"
compileSdk = "34"
buildTools = "34.0.0"
ndkVersion = "26.1.10909125"
# Dependencies versions
agp = "8.2.1"
androidx-annotation = "1.6.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/template/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ buildscript {
minSdkVersion = 23
compileSdkVersion = 34
targetSdkVersion = 34
ndkVersion = "26.0.10792818"
ndkVersion = "26.1.10909125"
kotlinVersion = "1.8.0"
}
repositories {
Expand Down

0 comments on commit 06cad26

Please sign in to comment.