-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump NDK to 26.1 #42656
Closed
Closed
Bump NDK to 26.1 #42656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jan 25, 2024
This pull request was exported from Phabricator. Differential Revision: D53083606 |
Base commit: ffaeaba |
cortinico
force-pushed
the
export-D53083606
branch
from
January 25, 2024 22:12
5fda615
to
06cad26
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Jan 25, 2024
Summary: I'm bumping the NDK to 26.1. As we already have a bump lined up to 26.0 on main, it makes sense to go to .1 as it's declared the LTS: https://github.com/android/ndk/wiki Changelog: [Android] [Changed] - Android NDK to 26.1 Reviewed By: NickGerleman Differential Revision: D53083606
This pull request was exported from Phabricator. Differential Revision: D53083606 |
Summary: I'm bumping the NDK to 26.1. As we already have a bump lined up to 26.0 on main, it makes sense to go to .1 as it's declared the LTS: https://github.com/android/ndk/wiki Changelog: [Android] [Changed] - Android NDK to 26.1 Reviewed By: NickGerleman Differential Revision: D53083606
cortinico
force-pushed
the
export-D53083606
branch
from
January 26, 2024 08:27
06cad26
to
a0bca21
Compare
This pull request was exported from Phabricator. Differential Revision: D53083606 |
This pull request has been merged in 5f75e9b. |
facebook-github-bot
pushed a commit
to facebookincubator/fbjni
that referenced
this pull request
Jan 27, 2024
Summary: ## Motivation Bumps Android NDK version to 26.1.xxx - see facebook/react-native#42656, cc cortinico bump in gradle Pull Request resolved: #94 Test Plan: build app Reviewed By: NickGerleman Differential Revision: D53122799 Pulled By: cortinico fbshipit-source-id: 4a256d4e595ea7025b80b98260330827023a07a0
blakef
pushed a commit
to blakef/template
that referenced
this pull request
Feb 28, 2024
Summary: Pull Request resolved: facebook/react-native#42656 I'm bumping the NDK to 26.1. As we already have a bump lined up to 26.0 on main, it makes sense to go to .1 as it's declared the LTS: https://github.com/android/ndk/wiki Changelog: [Android] [Changed] - Android NDK to 26.1 Reviewed By: NickGerleman Differential Revision: D53083606 fbshipit-source-id: 12290efcfa8a72ab88c21ffe9507d08d5512d61b Original: facebook/react-native@5f75e9b
blakef
pushed a commit
to react-native-community/template
that referenced
this pull request
Feb 29, 2024
Summary: Pull Request resolved: facebook/react-native#42656 I'm bumping the NDK to 26.1. As we already have a bump lined up to 26.0 on main, it makes sense to go to .1 as it's declared the LTS: https://github.com/android/ndk/wiki Changelog: [Android] [Changed] - Android NDK to 26.1 Reviewed By: NickGerleman Differential Revision: D53083606 fbshipit-source-id: 12290efcfa8a72ab88c21ffe9507d08d5512d61b Original-Commit: facebook/react-native@5f75e9b
blakef
pushed a commit
to react-native-community/template
that referenced
this pull request
Feb 29, 2024
Summary: Pull Request resolved: facebook/react-native#42656 I'm bumping the NDK to 26.1. As we already have a bump lined up to 26.0 on main, it makes sense to go to .1 as it's declared the LTS: https://github.com/android/ndk/wiki Changelog: [Android] [Changed] - Android NDK to 26.1 Reviewed By: NickGerleman Differential Revision: D53083606 fbshipit-source-id: 12290efcfa8a72ab88c21ffe9507d08d5512d61b Original-Commit: facebook/react-native@5f75e9b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
This PR has been merged.
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I'm bumping the NDK to 26.1. As we already have a bump lined up to 26.0 on main,
it makes sense to go to .1 as it's declared the LTS:
https://github.com/android/ndk/wiki
Changelog:
[Android] [Changed] - Android NDK to 26.1
Differential Revision: D53083606