Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump NDK to 26.1 #42656

Closed
wants to merge 1 commit into from
Closed

Bump NDK to 26.1 #42656

wants to merge 1 commit into from

Conversation

cortinico
Copy link
Contributor

Summary:
I'm bumping the NDK to 26.1. As we already have a bump lined up to 26.0 on main,
it makes sense to go to .1 as it's declared the LTS:
https://github.com/android/ndk/wiki

Changelog:
[Android] [Changed] - Android NDK to 26.1

Differential Revision: D53083606

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 25, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53083606

@analysis-bot
Copy link

analysis-bot commented Jan 25, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,963,775 -8,471
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,347,548 -8,467
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: ffaeaba
Branch: main

cortinico added a commit to cortinico/react-native that referenced this pull request Jan 25, 2024
Summary:

I'm bumping the NDK to 26.1. As we already have a bump lined up to 26.0 on main,
it makes sense to go to .1 as it's declared the LTS:
https://github.com/android/ndk/wiki

Changelog:
[Android] [Changed] - Android NDK to 26.1

Reviewed By: NickGerleman

Differential Revision: D53083606
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53083606

Summary:

I'm bumping the NDK to 26.1. As we already have a bump lined up to 26.0 on main,
it makes sense to go to .1 as it's declared the LTS:
https://github.com/android/ndk/wiki

Changelog:
[Android] [Changed] - Android NDK to 26.1

Reviewed By: NickGerleman

Differential Revision: D53083606
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53083606

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 26, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 5f75e9b.

facebook-github-bot pushed a commit to facebookincubator/fbjni that referenced this pull request Jan 27, 2024
Summary:
## Motivation

Bumps Android NDK version to 26.1.xxx - see facebook/react-native#42656, cc cortinico

bump in gradle

Pull Request resolved: #94

Test Plan: build app

Reviewed By: NickGerleman

Differential Revision: D53122799

Pulled By: cortinico

fbshipit-source-id: 4a256d4e595ea7025b80b98260330827023a07a0
blakef pushed a commit to blakef/template that referenced this pull request Feb 28, 2024
Summary:
Pull Request resolved: facebook/react-native#42656

I'm bumping the NDK to 26.1. As we already have a bump lined up to 26.0 on main,
it makes sense to go to .1 as it's declared the LTS:
https://github.com/android/ndk/wiki

Changelog:
[Android] [Changed] - Android NDK to 26.1

Reviewed By: NickGerleman

Differential Revision: D53083606

fbshipit-source-id: 12290efcfa8a72ab88c21ffe9507d08d5512d61b

Original: facebook/react-native@5f75e9b
blakef pushed a commit to react-native-community/template that referenced this pull request Feb 29, 2024
Summary:
Pull Request resolved: facebook/react-native#42656

I'm bumping the NDK to 26.1. As we already have a bump lined up to 26.0 on main,
it makes sense to go to .1 as it's declared the LTS:
https://github.com/android/ndk/wiki

Changelog:
[Android] [Changed] - Android NDK to 26.1

Reviewed By: NickGerleman

Differential Revision: D53083606

fbshipit-source-id: 12290efcfa8a72ab88c21ffe9507d08d5512d61b

Original-Commit: facebook/react-native@5f75e9b
blakef pushed a commit to react-native-community/template that referenced this pull request Feb 29, 2024
Summary:
Pull Request resolved: facebook/react-native#42656

I'm bumping the NDK to 26.1. As we already have a bump lined up to 26.0 on main,
it makes sense to go to .1 as it's declared the LTS:
https://github.com/android/ndk/wiki

Changelog:
[Android] [Changed] - Android NDK to 26.1

Reviewed By: NickGerleman

Differential Revision: D53083606

fbshipit-source-id: 12290efcfa8a72ab88c21ffe9507d08d5512d61b

Original-Commit: facebook/react-native@5f75e9b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants