Skip to content

Commit

Permalink
Removing TimerMixin on TextInput (#21522)
Browse files Browse the repository at this point in the history
Summary:
Related to #21485.
Removed TimerMixin from Libraries/Components/TextInput/TextInput.js
Pull Request resolved: #21522

Differential Revision: D10229669

Pulled By: RSNara

fbshipit-source-id: 45de331203eddce06b8fb7ddf4080869c07b6c55
  • Loading branch information
richardcann authored and facebook-github-bot committed Oct 8, 2018
1 parent de416e7 commit 31d6a69
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions Libraries/Components/TextInput/TextInput.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ const StyleSheet = require('StyleSheet');
const Text = require('Text');
const TextAncestor = require('TextAncestor');
const TextInputState = require('TextInputState');
const TimerMixin = require('react-timer-mixin');
const TouchableWithoutFeedback = require('TouchableWithoutFeedback');
const UIManager = require('UIManager');

Expand Down Expand Up @@ -803,7 +802,7 @@ const TextInput = createReactClass({
* `NativeMethodsMixin` will look for this when invoking `setNativeProps`. We
* make `this` look like an actual native component class.
*/
mixins: [NativeMethodsMixin, TimerMixin],
mixins: [NativeMethodsMixin],

/**
* Returns `true` if the input is currently focused; `false` otherwise.
Expand All @@ -819,6 +818,7 @@ const TextInput = createReactClass({
_focusSubscription: (undefined: ?Function),
_lastNativeText: (undefined: ?string),
_lastNativeSelection: (undefined: ?Selection),
_rafId: (null: ?AnimationFrameID),

componentDidMount: function() {
this._lastNativeText = this.props.value;
Expand All @@ -833,7 +833,7 @@ const TextInput = createReactClass({
'focus',
el => {
if (this === el) {
this.requestAnimationFrame(this.focus);
this._rafId = requestAnimationFrame(this.focus);
} else if (this.isFocused()) {
this.blur();
}
Expand All @@ -844,7 +844,7 @@ const TextInput = createReactClass({
}
} else {
if (this.props.autoFocus) {
this.requestAnimationFrame(this.focus);
this._rafId = requestAnimationFrame(this.focus);
}
}
},
Expand All @@ -858,6 +858,9 @@ const TextInput = createReactClass({
if (tag != null) {
TextInputState.unregisterInput(tag);
}
if (this._rafId != null) {
cancelAnimationFrame(this._rafId);
}
},

contextTypes: {
Expand Down

0 comments on commit 31d6a69

Please sign in to comment.