Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TimerMixin] Removing TimerMixin on TextInput #21522

Conversation

richardcann
Copy link
Contributor

@richardcann richardcann commented Oct 5, 2018

Related to #21485.
Removed TimerMixin from Libraries/Components/TextInput/TextInput.js

Test Plan:

  • run prettier
  • npm run flow-check-ios
  • npm run flow-check-android

RNTester:

  • run tester for Android
  • checked that the TextInput component has same animation when focus

Release Notes:

[GENERAL] [ENHANCEMENT] [Libraries/Components/TextInput/TextInput.js] - remove TimerMixin

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 5, 2018
Copy link

@analysis-bot analysis-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis results:

  • flow found some issues.

@@ -858,6 +858,9 @@ const TextInput = createReactClass({

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot call cancelAnimationFrame with this._rafId bound to requestId because null or undefined [1] is incompatible with AnimationFrameID [2].

@react-native-bot react-native-bot added Component: TextInput Related to the TextInput component. 🔶Components labels Oct 5, 2018
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSNara has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@RSNara RSNara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏽

@RSNara RSNara changed the title Removing TimerMixin on TextInput [TimerMixin] Removing TimerMixin on TextInput Oct 8, 2018
@facebook-github-bot facebook-github-bot added Import Started This pull request has been imported. This does not imply the PR has been approved. Import Failed and removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Oct 8, 2018
@facebook-github-bot
Copy link
Contributor

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

@react-native-bot
Copy link
Collaborator

@rmcp1g15 merged commit 31d6a69 into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Oct 8, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 8, 2018
t-nanava pushed a commit to microsoft/react-native-macos that referenced this pull request Jun 17, 2019
Summary:
Related to facebook#21485.
Removed TimerMixin from Libraries/Components/TextInput/TextInput.js
Pull Request resolved: facebook#21522

Differential Revision: D10229669

Pulled By: RSNara

fbshipit-source-id: 45de331203eddce06b8fb7ddf4080869c07b6c55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Component: TextInput Related to the TextInput component. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants