Skip to content

Commit

Permalink
Update fresco to v1.9.0, okhttp3 to v3.10.0
Browse files Browse the repository at this point in the history
Summary:
I found many crash reports of imagepipeline in our android app,
this is caused by fresco webp native memory leak, they have fixed it in v1.9.0
fixed wrong pull request of [18848](#18848)

    Test with local build.
    Check CI passes.

    [ANDROID] [ENHANCEMENT] [Fresco/OkHttp] - Updates Fresco to 1.9.0, OkHttp to 3.10.0
Closes #18849

Differential Revision: D7651377

Pulled By: mdvacca

fbshipit-source-id: 0bfe79fd3d232b11a6a9380c961b9401c9e0ced9
  • Loading branch information
liangtongchuan authored and facebook-github-bot committed Apr 24, 2018
1 parent 9909a42 commit 6b07602
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 20 deletions.
8 changes: 4 additions & 4 deletions ReactAndroid/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -294,12 +294,12 @@ dependencies {
compile 'javax.inject:javax.inject:1'
compile 'com.android.support:appcompat-v7:23.0.1'
compile 'com.facebook.fbui.textlayoutbuilder:textlayoutbuilder:1.0.0'
compile 'com.facebook.fresco:fresco:1.8.1'
compile 'com.facebook.fresco:imagepipeline-okhttp3:1.8.1'
compile 'com.facebook.fresco:fresco:1.9.0'
compile 'com.facebook.fresco:imagepipeline-okhttp3:1.9.0'
compile 'com.facebook.soloader:soloader:0.3.0'
compile 'com.google.code.findbugs:jsr305:3.0.0'
compile 'com.squareup.okhttp3:okhttp:3.8.0'
compile 'com.squareup.okhttp3:okhttp-urlconnection:3.8.0'
compile 'com.squareup.okhttp3:okhttp:3.10.0'
compile 'com.squareup.okhttp3:okhttp-urlconnection:3.10.0'
compile 'com.squareup.okio:okio:1.14.0'
compile 'org.webkit:android-jsc:r174650'

Expand Down
24 changes: 12 additions & 12 deletions ReactAndroid/src/main/libraries/fresco/fresco-react-native/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ rn_android_prebuilt_aar(

remote_file(
name = "fresco-binary-aar",
sha1 = "c6ed3f696ed47dca3b20d4ffbd0600c94b9119b2",
url = "mvn:com.facebook.fresco:fresco:aar:1.8.1",
sha1 = "f4415e8676eef4d12fdc8ddbd784bb752cf0c5e3",
url = "mvn:com.facebook.fresco:fresco:aar:1.9.0",
)

android_prebuilt_aar(
Expand All @@ -20,8 +20,8 @@ android_prebuilt_aar(

remote_file(
name = "drawee-binary-aar",
sha1 = "6bc689901ddcac8f3df5ba4db1f8aabeb8e80107",
url = "mvn:com.facebook.fresco:drawee:aar:1.8.1",
sha1 = "e0c3b0fa64fc7525f05a852476bc8723ae6ddc90",
url = "mvn:com.facebook.fresco:drawee:aar:1.9.0",
)

rn_android_library(
Expand All @@ -42,8 +42,8 @@ rn_android_prebuilt_aar(

remote_file(
name = "imagepipeline-base-aar",
sha1 = "42fd80c46a853850dfc0d71808b982fef401c841",
url = "mvn:com.facebook.fresco:imagepipeline-base:aar:1.8.1",
sha1 = "8034e5c8a75385bd20e72ff51489b0673029fcf7",
url = "mvn:com.facebook.fresco:imagepipeline-base:aar:1.9.0",
)

rn_android_prebuilt_aar(
Expand All @@ -54,8 +54,8 @@ rn_android_prebuilt_aar(

remote_file(
name = "imagepipeline-aar",
sha1 = "06a2a4c3e1d9a7fb7d7f1ad14db63e2d32ef0b61",
url = "mvn:com.facebook.fresco:imagepipeline:aar:1.8.1",
sha1 = "8043733b1bf3713d3a3c7fc7896205c96c050fd7",
url = "mvn:com.facebook.fresco:imagepipeline:aar:1.9.0",
)

rn_prebuilt_jar(
Expand All @@ -78,8 +78,8 @@ android_prebuilt_aar(

remote_file(
name = "fbcore-aar",
sha1 = "99b7a83946e16f037149e4cd3abfd6840a09445d",
url = "mvn:com.facebook.fresco:fbcore:aar:1.8.1",
sha1 = "fc3703511dc7b135bcd0e76d8015cdaf247b1760",
url = "mvn:com.facebook.fresco:fbcore:aar:1.9.0",
)

android_prebuilt_aar(
Expand All @@ -90,6 +90,6 @@ android_prebuilt_aar(

remote_file(
name = "imagepipeline-okhttp3-binary-aar",
sha1 = "751f19412e1843b1c1e76eae46e388fb1deddbcc",
url = "mvn:com.facebook.fresco:imagepipeline-okhttp3:aar:1.8.1",
sha1 = "4ac95941c1761a1ba5647ed551f7e47a5c417c7b",
url = "mvn:com.facebook.fresco:imagepipeline-okhttp3:aar:1.9.0",
)
8 changes: 4 additions & 4 deletions ReactAndroid/src/main/third-party/java/okhttp/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ prebuilt_jar(

remote_file(
name = "okhttp3-binary-jar",
sha1 = "5a11f020cce2d11eb71ba916700600e18c4547e7",
url = "mvn:com.squareup.okhttp3:okhttp:jar:3.8.0",
sha1 = "7ef0f1d95bf4c0b3ba30bbae25e0e562b05cf75e",
url = "mvn:com.squareup.okhttp3:okhttp:jar:3.10.0",
)

prebuilt_jar(
Expand All @@ -18,6 +18,6 @@ prebuilt_jar(

remote_file(
name = "okhttp3-urlconnection-binary-jar",
sha1 = "265257b82f20bb0371a926cc8ceb5f7bb17c0df8",
url = "mvn:com.squareup.okhttp3:okhttp-urlconnection:jar:3.8.0",
sha1 = "ec614c05825ddd2267677a99f585d3913474b125",
url = "mvn:com.squareup.okhttp3:okhttp-urlconnection:jar:3.10.0",
)

0 comments on commit 6b07602

Please sign in to comment.