Update fresco to v1.9.0 #18848
Closed
Update fresco to v1.9.0 #18848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This adds a way to test out CocoaPods build to RNTester, but as a separate project/workspace. This also fixes the podspecs due to Fabric stuffs. Note that this setup is meant to be run manually, not by CI (yet) Reviewed By: mmmulani Differential Revision: D7603823 fbshipit-source-id: 2219aa4c77f40ec07097a5c9ed4052529226618b
Summary: fresco v1.9.0 updated to MIT license, fixed WebP native memory leak bug which caused anroid app crash.
Generated by 🚫 dangerJS |
|
@daqiuqu I think your rebase failed. might want to rebase properly. |
|
@chirag04 Thank you for your time. I'll try later. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 24, 2018
Summary: I found many crash reports of imagepipeline in our android app, this is caused by fresco webp native memory leak, they have fixed it in v1.9.0 fixed wrong pull request of [18848](#18848) Test with local build. Check CI passes. [ANDROID] [ENHANCEMENT] [Fresco/OkHttp] - Updates Fresco to 1.9.0, OkHttp to 3.10.0 Closes #18849 Differential Revision: D7651377 Pulled By: mdvacca fbshipit-source-id: 0bfe79fd3d232b11a6a9380c961b9401c9e0ced9
macdoum1
pushed a commit
to macdoum1/react-native
that referenced
this pull request
Jun 28, 2018
Summary: I found many crash reports of imagepipeline in our android app, this is caused by fresco webp native memory leak, they have fixed it in v1.9.0 fixed wrong pull request of [18848](facebook#18848) Test with local build. Check CI passes. [ANDROID] [ENHANCEMENT] [Fresco/OkHttp] - Updates Fresco to 1.9.0, OkHttp to 3.10.0 Closes facebook#18849 Differential Revision: D7651377 Pulled By: mdvacca fbshipit-source-id: 0bfe79fd3d232b11a6a9380c961b9401c9e0ced9
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found many crash reports of imagepipeline in our android app,
this is caused by fresco webp native memory leak, they have fixed it in v1.9.0
Test Plan
Release Notes