Skip to content

Commit

Permalink
Remove force_static from ReactCommon/react/renderer/core
Browse files Browse the repository at this point in the history
Summary: This will cause the library to be included multiple times in different dynamic libraries, leading to potentially different values of `CoreFeatures`.

Reviewed By: christophpurrer

Differential Revision: D43772552

fbshipit-source-id: 4590bb9aef7c2330b6e488fa1640eda2720b6e7b
  • Loading branch information
javache authored and facebook-github-bot committed Mar 6, 2023
1 parent d00c150 commit e088f81
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
1 change: 1 addition & 0 deletions ReactCommon/react/renderer/components/view/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ rn_xplat_cxx_library(
react_native_xplat_target("react/renderer/core:core"),
react_native_xplat_target("react/renderer/debug:debug"),
react_native_xplat_target("react/renderer/graphics:graphics"),
react_native_xplat_target("react/renderer/mapbuffer:mapbuffer"),
react_native_xplat_target("react/config:config"),
react_native_xplat_target("logger:logger"),
],
Expand Down
5 changes: 3 additions & 2 deletions ReactCommon/react/renderer/core/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ rn_xplat_cxx_library(
fbandroid_tests_override = [],
fbobjc_compiler_flags = APPLE_COMPILER_FLAGS,
fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(),
force_static = True,
labels = [
"pfh:ReactNative_CommonInfrastructurePlaceholder",
],
Expand All @@ -55,13 +54,15 @@ rn_xplat_cxx_library(
"//xplat/folly:hash",
"//xplat/folly:likely",
"//xplat/jsi:JSIDynamic",
"//xplat/jsi:jsi",
react_native_xplat_target("react/debug:debug"),
react_native_xplat_target("react/utils:utils"),
react_native_xplat_target("react/renderer/debug:debug"),
react_native_xplat_target("react/renderer/graphics:graphics"),
react_native_xplat_target("cxxreact:bridge"),
],
exported_deps = [
"//xplat/jsi:jsi",
],
)

fb_xplat_cxx_test(
Expand Down

0 comments on commit e088f81

Please sign in to comment.