Skip to content

Commit

Permalink
Use NODE_BINARY from .xcode.env when running packager from Xcode (#…
Browse files Browse the repository at this point in the history
…34121)

Summary:
Before this change, during the "Start Packager" Xcode build step that runs the packager, `packager.sh` was using my system node version and not the one from `nvm` that is meant to be used with the project.

## Changelog

[iOS] [Fixed] - Use `NODE_BINARY` from `.xcode.env` when running packager from Xcode

Pull Request resolved: #34121

Test Plan: Perform a build using Xcode and confirm that the packager is using the correct version of node.

Reviewed By: cortinico

Differential Revision: D37746951

Pulled By: cipolleschi

fbshipit-source-id: de697c27fe86ce65e8e3646cb30309ecc7f6c247
  • Loading branch information
elsurudo authored and facebook-github-bot committed Jul 12, 2022
1 parent a7100a1 commit ff785db
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions scripts/launchPackager.command
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ clear

THIS_DIR=$(cd -P "$(dirname "$(readlink "${BASH_SOURCE[0]}" || echo "${BASH_SOURCE[0]}")")" && pwd)

export PODS_ROOT="$THIS_DIR/../../../ios/Pods"
WITH_ENVIRONMENT="$THIS_DIR/xcode/with-environment.sh"
source $WITH_ENVIRONMENT

# export packager environment variables
source "$THIS_DIR/.packager.env"

Expand Down

0 comments on commit ff785db

Please sign in to comment.