Cannot read property 'tokens' of undefined #12071

skv-headless · 2017-01-25T14:38:26Z

Description

I'm testing my app on react-native master. And having such error during transformation

UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 548): SyntaxError: TransformError: /Users/headless/tmp/TestIntlCrash/node_modules/intl/lib/core.js: Cannot read property 'tokens' of undefined

Reproduction

new project with intl dependency
https://github.com/skv-headless/TestIntlCrash

Solution

Not yet.

Additional Information

React Native version: [master], works on 0.40
Platform: [iOS, Android]
Operating System: [MacOS]

The text was updated successfully, but these errors were encountered:

skv-headless · 2017-01-25T15:15:17Z

caused by this commit 0849f84 I hope @davidaurelio can give me a hint since I'm not fully understand this patch.

gitim · 2017-01-25T16:53:03Z

I have the same issue, I debugged it a little bit and I found that error occurs on the line https://github.com/babel/babel/blob/master/packages/babel-generator/src/index.js#L16, because somehow ast for this file is undefined.

skv-headless · 2017-01-26T11:39:48Z

andyearnshaw/Intl.js#264

gitim · 2017-02-08T19:52:46Z

The issue is solved in the version 0.41, it can be closed.

ruiaraujo · 2017-02-14T13:52:31Z

@gitim I am getting this again in 0.42-rc2.
It does work on 0.41.

dkpalmer · 2017-02-14T20:51:34Z

Also getting this on 0.42.0-rc3, and confirmed working downgrading to 0.41.0.

cknitt · 2017-03-01T18:22:06Z

Just encountered this problem in 0.42.0 release. 0.41 works fine.

ericvicenti · 2017-03-01T18:34:23Z

What is the intl library doing that causes this? This issue description does not make it clear what is broken inside RN, just that something is wrong when you use this library. Please re-open an issue that is more specific about RN's behavior, if the issue doesn't already exist

cknitt · 2017-03-01T19:11:22Z

@ericvicenti: This error occurs during packaging, not while using the library.

seavan · 2017-03-02T16:04:39Z

@ericvicenti please reopen the issue

chandu0101 · 2017-03-04T03:33:35Z

probably related to #12695

antoinerousseau · 2017-03-06T17:03:07Z

any workaround idea?

seavan · 2017-03-06T17:05:25Z

@antoinerousseau remove all files from .babelignore or "ignore" section of "babelrc".
make sure they are transformed correctly.

antoinerousseau · 2017-03-06T17:34:41Z

@seavan that did the trick, thanks!

jpaas · 2017-03-08T22:56:15Z

@seavan 's suggestion doesn't work for me because I don't have anything being ignored. So this continues to prevent me from moving up to 0.42

pmdida · 2017-03-09T07:52:05Z

@jpaas seavan is not refering to your .babelrc/.babelignore if I understand well. He refers to the .babelrc of the intl node module. It's better explained in this discussion: andyearnshaw/Intl.js#264

I went for the workaround they propose there: remove the .babelrc file of the intl module in the postinstall of your package.json, it works fine until a better solution is found.

seavan · 2017-03-09T09:41:04Z

React-packager tries to parse .babelrc and .babelignore in node_modules as well as in the source directories. So yeah, if you have a NPM module which has .babelrc with "ignore" - you'll have problems.

When we have such problems we do it like this:

add a copy/watch task for that specific module, so on build it will copy all sources (or distro) "node_modules/some-specific-package/" to, say "app/lib/some-specific-package/"

That actually is enough. Your task won't copy '.babelrc', your packager won't try to parse it (unless you reference it as import 'package-name'; instead of import './lib/package-name';

antoinerousseau · 2017-03-09T09:47:00Z

Or as @didaktik wrote, just add "postinstall": "rm -f node_modules/intl/.babelrc" to your package.json as proposed in andyearnshaw/Intl.js#264

jpaas · 2017-03-09T12:27:59Z

Ah thank-you @didaktik that makes more sense. Well at least we have a workaround for now.

Fixes facebook#12071, facebook#13168

Summary: - [x] Explain the **motivation** for making this change. - [x] Provide a **test plan** demonstrating that the code is solid. - [x] Match the **code formatting** of the rest of the codebase. - [x] Target the `master` branch, NOT a "stable" branch. I have a need to bundle a pre-optimized external lib with my RN application. Until RN 0.42 I had been using a .babelignore to prevent the packager from trying to optimize this file and choke. It seems in 0.42 and higher I'm no longer allowed to ignore the file. This issue has also been reported as #12071 Details on the reasoning for this patch can be found in the issue I originally filed: #13168 What existing problem does the pull request solve? This PR restores the functionality with babel ignoring files that existed in 0.41 before this patch: 0849f84#diff-4676ea0b3c55c65c3929aa993144f07f Here's a screenshot of this patch properly ignoring the file I referenced in #13168 to be ignored. ![screen shot 2017-04-27 at 12 48 32 am](https://cloud.githubusercontent.com/assets/21967/25469653/524dbc0c-2ae3-11e7-81a6-faca2f4d21fe.png) The patch relies on the `ignored` value of the call to `babel.transform` and if true returns the src in a object per instruction from loganfsmyth from BabelJS core team. To test, add a file to the `ignore` array of a `.babelrc` file in a React Native project with this fork. I was unable to locate a test file for the transformer.js Fixes #12071, #13168 Closes #13681 Differential Revision: D5017565 Pulled By: davidaurelio fbshipit-source-id: 421f57b5ce192eedd46fae4285d8a741cb5f8e71

Summary: - [x] Explain the **motivation** for making this change. - [x] Provide a **test plan** demonstrating that the code is solid. - [x] Match the **code formatting** of the rest of the codebase. - [x] Target the `master` branch, NOT a "stable" branch. I have a need to bundle a pre-optimized external lib with my RN application. Until RN 0.42 I had been using a .babelignore to prevent the packager from trying to optimize this file and choke. It seems in 0.42 and higher I'm no longer allowed to ignore the file. This issue has also been reported as facebook#12071 Details on the reasoning for this patch can be found in the issue I originally filed: facebook#13168 What existing problem does the pull request solve? This PR restores the functionality with babel ignoring files that existed in 0.41 before this patch: facebook@0849f84#diff-4676ea0b3c55c65c3929aa993144f07f Here's a screenshot of this patch properly ignoring the file I referenced in facebook#13168 to be ignored. ![screen shot 2017-04-27 at 12 48 32 am](https://cloud.githubusercontent.com/assets/21967/25469653/524dbc0c-2ae3-11e7-81a6-faca2f4d21fe.png) The patch relies on the `ignored` value of the call to `babel.transform` and if true returns the src in a object per instruction from loganfsmyth from BabelJS core team. To test, add a file to the `ignore` array of a `.babelrc` file in a React Native project with this fork. I was unable to locate a test file for the transformer.js Fixes facebook#12071, facebook#13168 Closes facebook#13681 Differential Revision: D5017565 Pulled By: davidaurelio fbshipit-source-id: 421f57b5ce192eedd46fae4285d8a741cb5f8e71

ghost · 2017-05-23T23:03:54Z

Hoping this gets merged in soon. Can't currently run ./gradlew without first running rm -f node_modules/intl/.babelrc, which requires me to update build scripts in our android deployment flow, that I'd rather not modify for a temp fix.

nerdmed · 2017-06-15T21:08:59Z

Any news here? Seems that this is still broken and its not the intl lib?!

ghost · 2017-06-16T05:13:14Z

@nerdmed The current solution is to add the following to your scripts section of your package.json file.

"postinstall": "rm -f node_modules/intl/.babelrc"

If that's not working for you, you might have another NPM that's including a .babelrc that is tripping up React Native. I personally am surprised it's not fixed yet, I'm currently on version 0.44.0

ghost · 2017-06-16T05:14:24Z

Looks like it was fixed in 0.45.1

7932b93

https://github.com/facebook/react-native/releases

I've just personally confirmed it works for me after I upgraded react-native and removed the postinstall line from my package.json

skv-headless mentioned this issue Jan 26, 2017

fix babelrc andyearnshaw/Intl.js#264

Closed

gitim mentioned this issue Feb 1, 2017

[Packager] Fix transforming when ast is not available #12156

Closed

ericvicenti closed this as completed Mar 1, 2017

GertjanReynaert mentioned this issue Mar 3, 2017

Packager fails loading Intl polyfill for Android #12683

Closed

kevinold mentioned this issue Mar 27, 2017

Packager not handling .babelignore'd files due to sourcemap generation logic #13168

Closed

kevinold mentioned this issue Apr 27, 2017

Properly handle babel ignored files, returning only the contents #13681

Closed

4 tasks

kevinold pushed a commit to kevinold/react-native that referenced this issue Apr 27, 2017

Properly handle babel ignored files, returning only the contents

a6f8cb3

Fixes facebook#12071, facebook#13168

facebook locked as resolved and limited conversation to collaborators May 24, 2018

react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 19, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cannot read property 'tokens' of undefined #12071

Cannot read property 'tokens' of undefined #12071

skv-headless commented Jan 25, 2017 •

edited

Loading

skv-headless commented Jan 25, 2017

gitim commented Jan 25, 2017 •

edited

Loading

skv-headless commented Jan 26, 2017

gitim commented Feb 8, 2017

ruiaraujo commented Feb 14, 2017 •

edited

Loading

dkpalmer commented Feb 14, 2017 •

edited

Loading

cknitt commented Mar 1, 2017

ericvicenti commented Mar 1, 2017

cknitt commented Mar 1, 2017

seavan commented Mar 2, 2017

chandu0101 commented Mar 4, 2017

antoinerousseau commented Mar 6, 2017

seavan commented Mar 6, 2017

antoinerousseau commented Mar 6, 2017

jpaas commented Mar 8, 2017

pmdida commented Mar 9, 2017

seavan commented Mar 9, 2017 •

edited

Loading

antoinerousseau commented Mar 9, 2017 •

edited

Loading

jpaas commented Mar 9, 2017

ghost commented May 23, 2017

nerdmed commented Jun 15, 2017

ghost commented Jun 16, 2017

ghost commented Jun 16, 2017 •

edited by ghost

Loading

Cannot read property 'tokens' of undefined #12071

Cannot read property 'tokens' of undefined #12071

Comments

skv-headless commented Jan 25, 2017 • edited Loading

Description

Reproduction

Solution

Additional Information

skv-headless commented Jan 25, 2017

gitim commented Jan 25, 2017 • edited Loading

skv-headless commented Jan 26, 2017

gitim commented Feb 8, 2017

ruiaraujo commented Feb 14, 2017 • edited Loading

dkpalmer commented Feb 14, 2017 • edited Loading

cknitt commented Mar 1, 2017

ericvicenti commented Mar 1, 2017

cknitt commented Mar 1, 2017

seavan commented Mar 2, 2017

chandu0101 commented Mar 4, 2017

antoinerousseau commented Mar 6, 2017

seavan commented Mar 6, 2017

antoinerousseau commented Mar 6, 2017

jpaas commented Mar 8, 2017

pmdida commented Mar 9, 2017

seavan commented Mar 9, 2017 • edited Loading

antoinerousseau commented Mar 9, 2017 • edited Loading

jpaas commented Mar 9, 2017

ghost commented May 23, 2017

nerdmed commented Jun 15, 2017

ghost commented Jun 16, 2017

ghost commented Jun 16, 2017 • edited by ghost Loading

skv-headless commented Jan 25, 2017 •

edited

Loading

gitim commented Jan 25, 2017 •

edited

Loading

ruiaraujo commented Feb 14, 2017 •

edited

Loading

dkpalmer commented Feb 14, 2017 •

edited

Loading

seavan commented Mar 9, 2017 •

edited

Loading

antoinerousseau commented Mar 9, 2017 •

edited

Loading

ghost commented Jun 16, 2017 •

edited by ghost

Loading