Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Packager] Fix transforming when ast is not available #12156

Closed
wants to merge 1 commit into from

Conversation

gitim
Copy link
Contributor

@gitim gitim commented Feb 1, 2017

Fixes #12071. I found that babel.transform does not generate ast for files from babelrc' ignore list, so babel-generator fails. I don't know the best way to handle such files, so I restored logic that was used before 0849f84 for files without ast.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. GH Review: review-needed labels Feb 1, 2017
@gitim
Copy link
Contributor Author

gitim commented Feb 1, 2017

cc @davidaurelio

@gitim
Copy link
Contributor Author

gitim commented Feb 6, 2017

Looks that this issue was solved in 0.41.2

@gitim gitim closed this Feb 6, 2017
@ruiaraujo
Copy link
Contributor

@gitim @davidaurelio This is still happening on 0.42 and I have verified that this PR fixes the issue.

@dkpalmer
Copy link

Verified same as @ruiaraujo, 0.42.0rc3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants