Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more documentation in ListViewDataSource #1285

Closed
wants to merge 1 commit into from

Conversation

umhan35
Copy link
Contributor

@umhan35 umhan35 commented May 14, 2015

ListViewDataSource's default data extractor can actually expect another data form:

{ sectionID_1: [ <rowData1>, <rowData2>, ... ], ... }

ListViewDataSource's default data extractor can actually expect another data form:

`{ sectionID_1: [ <rowData1>, <rowData2>, ... ], ... }`
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 14, 2015
@sahrens
Copy link
Contributor

sahrens commented May 15, 2015

@facebook-github-bot import

@facebook-github-bot
Copy link
Contributor

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1593093057609165/int_phab to review.

@sahrens
Copy link
Contributor

sahrens commented May 15, 2015

Thanks for the fix!

In the future, please make sure to clean up trailing spaces and any other lint.

@umhan35
Copy link
Contributor Author

umhan35 commented May 15, 2015

Sorry, I just added something in the comment. Why do we need to clean up trailing spaces and any other lint in this context?

@vjeux vjeux closed this in 40da7bb May 15, 2015
@sahrens
Copy link
Contributor

sahrens commented May 15, 2015

code is code and lint is lint, whether it's a comment or not.

@umhan35
Copy link
Contributor Author

umhan35 commented May 16, 2015

OK. I just noticed that there are trailing spaces. I didn't mean it and it's hard to find. Sorry.

@sahrens
Copy link
Contributor

sahrens commented May 16, 2015

Some editors can be configured to automatically remove trailing whitespace which is nice. Does running lint pick up these issues for you?

On May 15, 2015, at 5:11 PM, Zhao Han notifications@github.com wrote:

OK. I just noticed that there are trailing spaces. I didn't mean it and it's hard to find. Sorry.


Reply to this email directly or view it on GitHub.

@umhan35
Copy link
Contributor Author

umhan35 commented May 16, 2015

Oh, I edited the file using GitHub's edit button because I think the change is minor... (My IDE, WebStorm, for my react native project has the automatic trailing space removal feature.)

I'm new to node.js and lint is also new to me. I just figured out myself: the ESLint project (http://eslint.org/). But how do you run it? I tried several commands and they don't work.

@umhan35
Copy link
Contributor Author

umhan35 commented May 19, 2015

Thank you @sahrens! Just saw the update of CONTRIBUTING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants