Turn on focus ring for multiline textinput (facebook#1276) (facebook#…

…1285)
mganandraj · Jul 25, 2022 · 32e83dc · 32e83dc
1 parent ffa3c99
commit 32e83dc
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 0 deletions.
diff --git a/Libraries/Text/TextInput/Multiline/RCTMultilineTextInputView.m b/Libraries/Text/TextInput/Multiline/RCTMultilineTextInputView.m
@@ -48,6 +48,8 @@ - (instancetype)initWithBridge:(RCTBridge *)bridge
 #else // [TODO(macOS GH#774)
     _scrollView.documentView = _backedTextInputView;
     _scrollView.contentView.postsBoundsChangedNotifications = YES;
+    // Enable focus ring by default
+    _scrollView.enableFocusRing = YES;
     [self addSubview:_scrollView];
 
     // a register for those notifications on the content view.
@@ -89,6 +91,14 @@ - (void)setReactBorderInsets:(UIEdgeInsets)reactBorderInsets
   _scrollView.frame = UIEdgeInsetsInsetRect(self.bounds, reactBorderInsets);
   [self setNeedsLayout];
 }
+
+- (void)setEnableFocusRing:(BOOL)enableFocusRing {
+  [super setEnableFocusRing:enableFocusRing];
+  if ([_scrollView respondsToSelector:@selector(setEnableFocusRing:)]) {
+    [_scrollView setEnableFocusRing:YES];
+  }
+}
+
 #endif // ]TODO(macOS GH#774)
 
 #pragma mark - UIScrollViewDelegate

diff --git a/React/Base/RCTUIKit.h b/React/Base/RCTUIKit.h
@@ -425,6 +425,8 @@ CGPathRef UIBezierPathCreateCGPathRef(UIBezierPath *path);
 @property (nonatomic, assign) CGFloat zoomScale;
 @property (nonatomic, assign) BOOL alwaysBounceHorizontal;
 @property (nonatomic, assign) BOOL alwaysBounceVertical;
+// macOS specific properties
+@property (nonatomic, assign) BOOL enableFocusRing;
 
 @end
 

diff --git a/React/Base/macOS/RCTUIKit.m b/React/Base/macOS/RCTUIKit.m
@@ -429,6 +429,19 @@ - (void)setBackgroundColor:(NSColor *)backgroundColor
 
 @implementation RCTUIScrollView // TODO(macOS ISS#3536887)
 
+- (void)setEnableFocusRing:(BOOL)enableFocusRing {
+  if (_enableFocusRing != enableFocusRing) {
+    _enableFocusRing = enableFocusRing;
+  }
+
+  if (enableFocusRing) {
+    // NSTextView has no focus ring by default so let's use the standard Aqua focus ring.
+    [self setFocusRingType:NSFocusRingTypeExterior];
+  } else {
+    [self setFocusRingType:NSFocusRingTypeNone];
+  }
+}
+
 // UIScrollView properties missing from NSScrollView
 - (CGPoint)contentOffset
 {