Updates fri 15 may #1301
Merged
Updates fri 15 may #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Add console.profile sync hooks compliant with the chrome API https://developer.chrome.com/devtools/docs/console-api#consoleprofilelabel @public Test Plan: Add a `console.profile()` and a `console.profileEnd()` in the JavaScript, and record a systrace-like profile via DevMenu
Summary: The parent RCTBridge no longer tracks the JS loading since that has been handed off to the RCTBatchedBridge. To make the `loading` property accurate again, just expose the batch bridge's loading property from the parent bridge (note: I didn't make it KVO-compliant). Fixes facebook#1199 Closes facebook#1200 Github Author: James Ide <ide@jameside.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
facebook-github-bot
added
the
CLA Signed
…views Summary: `TextInput` does not automatically forward all props using the spread operator so we need to explicitly forward the `onLayout` prop. Closes facebook#1296 Github Author: James Ide <ide@jameside.com> Test Plan: Mount a TextInput component with an `onLayout` prop and see that the callback handler is invoked with the TextInput's frame.
Summary:
ListViewDataSource's default data extractor can actually expect another data form:
`{ sectionID_1: [ <rowData1>, <rowData2>, ... ], ... }`
Closes facebook#1285
Github Author: Zhao Han <cx.chenghai+github@gmail.com>
Test Plan: Changed the ListViewExample to make sure all three formats work.
Summary: @public Apparently trailing commas transform isn't exported by react-tools. We need to pull it out manually. This is not so clean but we're swtching to babel very shortly. Test Plan: * npm start * write `foo(a,b,c,)` in some file * request that file in the browser and make sure that trailing comma is gone
ayushjainrksh
pushed a commit
to MLH-Fellowship/react-native
that referenced
this pull request
Jul 2, 2020
This was referenced Jan 18, 2022
This was referenced May 14, 2022
mganandraj
pushed a commit
to mganandraj/react-native
that referenced
this pull request
Aug 5, 2022
ryanlntn
pushed a commit
to ryanlntn/react-native
that referenced
this pull request
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.