[Packager] Fix the --root, --assetRoots, and --platform options #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should go in the 0.5.0 branch as well (something broke in the May 22 sync). |
facebook-github-bot
added
the
CLA Signed
Looks like these options were handled as booleans when they should be handled as strings. Explicitly specify them as strings. Test Plan: `packager/packager.sh --root A --root B` works. Also tested `packager/packager.sh --root A,B`. Tested the port option too: `packager/packager.sh --port 12345' and got a response visiting http://localhost:12345/index.includeRequire.runModule.bundle?dev=true.
|
👍 pulling. |
tadeuzagallo
pushed a commit
to tadeuzagallo/react-native
that referenced
this pull request
May 28, 2015
Summary: Looks like these options were handled as booleans when they should be handled as strings. Explicitly specify them as strings. Closes facebook#1377 Github Author: James Ide <ide@jameside.com> Test Plan: `packager/packager.sh --root A --root B` works. Also tested `packager/packager.sh --root A,B`.
jsierles
pushed a commit
to rnplay/react-native
that referenced
this pull request
Jun 8, 2015
Summary: Looks like these options were handled as booleans when they should be handled as strings. Explicitly specify them as strings. Closes facebook#1377 Github Author: James Ide <ide@jameside.com> Test Plan: `packager/packager.sh --root A --root B` works. Also tested `packager/packager.sh --root A,B`.
cpojer
pushed a commit
to facebook/metro
that referenced
this pull request
Jan 26, 2017
Summary: Looks like these options were handled as booleans when they should be handled as strings. Explicitly specify them as strings. Closes facebook/react-native#1377 Github Author: James Ide <ide@jameside.com> Test Plan: `packager/packager.sh --root A --root B` works. Also tested `packager/packager.sh --root A,B`.
mganandraj
pushed a commit
to mganandraj/react-native
that referenced
this pull request
Aug 28, 2022
update v8jsi version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like these options were handled as booleans when they should be handled as strings. Explicitly specify them as strings.
Test Plan:
packager/packager.sh --root A --root Bworks. Also testedpackager/packager.sh --root A,B.