Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Packager] Fix the --root, --assetRoots, and --platform options #1377

Closed
wants to merge 1 commit into from
Closed

[Packager] Fix the --root, --assetRoots, and --platform options #1377

wants to merge 1 commit into from

Commits on May 25, 2015

  1. [Packager] Fix the --root, --assetRoots, --port, and --platform options 

    Looks like these options were handled as booleans when they should be handled as strings. Explicitly specify them as strings.

Test Plan: `packager/packager.sh --root A --root B` works. Also tested `packager/packager.sh --root A,B`.

Tested the port option too: `packager/packager.sh --port 12345' and got a response visiting http://localhost:12345/index.includeRequire.runModule.bundle?dev=true.
    @ide
    ide committed May 25, 2015
    Configuration menu
    Copy the full SHA
    d17bdac View commit details
    Browse the repository at this point in the history