Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates fri 5 june #1525

Closed
wants to merge 20 commits into from
Closed

Updates fri 5 june #1525

wants to merge 20 commits into from

Commits on Jun 3, 2015

  1. Configuration menu
    Copy the full SHA
    e1454c2 View commit details
    Browse the repository at this point in the history
  2. Added ProgressViewIOS

    nicklockwood committed Jun 3, 2015
    Configuration menu
    Copy the full SHA
    e68f89b View commit details
    Browse the repository at this point in the history
  3. press ctrl-i to toggle inspect element

    Jared Forsyth committed Jun 3, 2015
    Configuration menu
    Copy the full SHA
    bba576a View commit details
    Browse the repository at this point in the history
  4. [Cosmetic] Fix typo in packager README

    Summary:
    
    Closes facebook#693
    Github Author: Tyler McGinnis <tylermcginnis33@gmail.com>
    
    Test Plan: Imported from GitHub, without a `Test Plan:` line.
    tylermcginnis committed Jun 3, 2015
    Configuration menu
    Copy the full SHA
    ca7a764 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    435125f View commit details
    Browse the repository at this point in the history
  6. [react-packager] Add support for nested node_modules

    Summary:
    @public
    The packager's resolver started out imitating node-haste, which meant that we didn't support nested modules. Now this is a problem. Bigger projects are bound to have versions of different versions of the same package at different levels of the dependency tree. This
    makes loading dependencies lazy for node_modules and implements the node resolution algorithm. However, it also mantains that some
    modules are still "haste" format, which currently defaults to "react-native" and "react-tools".
    
    Finally, this means ~5 seconds speed up on every server start. This should also have a big impact on open source users with projects with big node_modules.
    
    Test Plan:
    1- test the app with --reset-cache
    2- click around test and production apps
    3- update the OSS library
    4- create a new project
    5- npm install multiple modules
    6- create some version conflict in your project
    7- make sure we do the "right" thing
    8- test file changes to make sure it works
    Amjad Masad committed Jun 3, 2015
    Configuration menu
    Copy the full SHA
    5a191da View commit details
    Browse the repository at this point in the history
  7. visualize padding and margin in inspector

    Summary:
    This shows margin and padding visually when inspecting an element.
    
    @public
    
    Test Plan:
    Go to the "UIExplorer", to the <View> page. Open the inspector, and start
    selecting things. Padding and margin should be indicated. (Padding in dark
    blue and margin in orange).
    Jared Forsyth committed Jun 3, 2015
    Configuration menu
    Copy the full SHA
    7be471d View commit details
    Browse the repository at this point in the history
  8. [Touchable] Add custom delay props to Touchable components

    Summary:
    @public
    This PR adds quite a bit of functionality to the Touchable components, allowing the ms delays of each of the handlers (`onPressIn, onPressOut, onPress, onLongPress`) to be configured.
    
    It adds the following props to `TouchableWithoutFeedback, TouchableOpacity, and TouchableHighlight`:
    ```javascript
    /**
     * Delay in ms, from the release of the touch, before onPress is called.
     */
    delayOnPress: React.PropTypes.number,
    /**
     * Delay in ms, from the start of the touch, before onPressIn is called.
     */
    delayOnPressIn: React.PropTypes.number,
    /**
     * Delay in ms, from the release of the touch, before onPressOut is called.
     */
    delayOnPressOut: React.PropTypes.number,
    /**
     * Delay in ms, from onPressIn, before onLongPress is called.
     */
    delayOnLongPress: React.PropTypes.number,
    ```
    
    `TouchableHighlight` also gets an additional set of props:
    ```javascript
    /**
     * Delay in ms, from the start of the touch, before the highlight is shown.
     */
    delayHighlightShow: React.PropTypes.number,
    /**
     * Del
    ...
    ```
    
    Closes facebook#1255
    Github Author: jmstout <git@jmstout.com>
    
    Test Plan: Imported from GitHub, without a `Test Plan:` line.
    jmstout committed Jun 3, 2015
    Configuration menu
    Copy the full SHA
    074fa75 View commit details
    Browse the repository at this point in the history
  9. add style inspector + more margin + styles

    Summary:
    - make overlay transparent to avoid obscuring the app
    - show style in the inspector pane
    - show margin+padding values, also width/height and abs position
    
    @public
    
    Test Plan:
    Open the inspector somewhere, start selecting things. You should see correct
    padding, margin, and dimentions values; in addition to all style properties
    enumerated.
    Jared Forsyth committed Jun 3, 2015
    Configuration menu
    Copy the full SHA
    b2b89c0 View commit details
    Browse the repository at this point in the history
  10. Add an event for remote notification registration, and improve permis…

    …sions request
    
    Summary:
    In order to add Push support to the Parse JS SDK in React Native, we need a way to receive the APNS device token from the JS context. This adds another event to PushNotificationIOS, so that code can respond to a successful registration.
    
    Additionally, I've updated the `requestPermissions` call to accept an optional map of parameters. This way, developers can request a subset of user notification types.
    Closes facebook#1304
    Github Author: Andrew Imm <andrewi@fb.com>
    
    Test Plan: Imported from GitHub, without a `Test Plan:` line.
    andrewimm committed Jun 3, 2015
    1 Configuration menu
    Copy the full SHA
    89a1e94 View commit details
    Browse the repository at this point in the history
  11. [react-packager] Support packages with '.' in the name

    Summary:
    @public
    Fixes issue facebook#1055
    For some historical reason we used to strip the extension of the module name before passing it to `resolveDependency` which is completly capable of handling all kinds of names. The fix is one line, but added a few tests for this.
    
    Test Plan:
    * ./runJestTests.sh
    * ./runJestTests.sh PacakgerIntegration
    * Open app and click around
    Amjad Masad committed Jun 3, 2015
    Configuration menu
    Copy the full SHA
    856469a View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    6d25ff8 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2015

  1. [ReactNative] Remove unused touch arrays

    Summary:
    These two arrays aren't used. The code is easier to read without them
    
    @public
    
    Test Plan: Tap around UIExplorer and verify multi-touch and responder system behavior works the same
    Eric Vicenti committed Jun 4, 2015
    Configuration menu
    Copy the full SHA
    fa3491e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    63b8262 View commit details
    Browse the repository at this point in the history
  3. [ReactNative] Refactor DevMenu items construction

    Summary:
    The idea behind this change it to couple together menu item title
    and handler. The code becomes simpler and easier to maintain, but
    also makes it possible to extend dev menu in the future.
    
    @public
    
    Test Plan:
    All menu items works as before.
    Changed websocket executor class name and made sure that when the class
    is missing we get nice error message.
    frantic committed Jun 4, 2015
    Configuration menu
    Copy the full SHA
    9fe7128 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7ffa7bd View commit details
    Browse the repository at this point in the history
  5. [React Native] PickerIOS can update its items list

    Summary:
    @public
    PickerIOS doesn't look at the content of its list. It just keeps a list ref
    and pushes new items in.  Sadly this doesn't work with the naive reference checker
    so new item lists don't trigger a native rerender.
    
    The solution here is to ask PickerIOS to just pass its props down to native directly
    
    Test Plan:
    Implemented a simple Picker hooked up to a store getting new items.
    Watched the list not update and then update after this diff as new items come in
    alexmadjar committed Jun 4, 2015
    Configuration menu
    Copy the full SHA
    015b5cf View commit details
    Browse the repository at this point in the history
  6. select up and down the inspector hierarchy

    Summary:
    This allows you to select the displayed owner hierarchy, and see the styles,
    props, and position.
    
    @public
    
    Test Plan:
    Open the inspector, select something in the middle of the page. Click the
    breadcrumb train in the inspector, and verify that:
    - styles are reflected
    - margin/padding/box is correct
    - the highlight updates to show the selected item
    
    See video as well.
    
    [Video](https://www.latest.facebook.com/pxlcld/mqnl)
    
    Screenshot
    {F22518618}
    Jared Forsyth committed Jun 4, 2015
    Configuration menu
    Copy the full SHA
    53b2c39 View commit details
    Browse the repository at this point in the history
  7. [react-packager] Fix more node_modules resolution rules

    Summary:
    @public
    Fixes facebook#773
    This fixes `.json` name resolution. And also reads `package.json` when doing a directory module resolution.
    The algorithm can be found here: https://nodejs.org/api/modules.html
    I'll probably start including the node (or browserify) modules test in later diffs to make sure we're fully compliant.
    
    Test Plan:
    * ./runJestTests.sh
    * ./runJestTests.sh PackagerIntegration
    * open playground and require a json file
    * test redbox
    Amjad Masad committed Jun 4, 2015
    Configuration menu
    Copy the full SHA
    30fc738 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2015

  1. Updates from Fri 5 Jun

    vjeux committed Jun 5, 2015
    Configuration menu
    Copy the full SHA
    a5cabd1 View commit details
    Browse the repository at this point in the history