Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability for Animated views to be created with scale X or scale Y #18181

Closed
wants to merge 24 commits into from
Closed

Add ability for Animated views to be created with scale X or scale Y #18181

wants to merge 24 commits into from

Commits on Mar 3, 2018

  1. Configuration menu
    Copy the full SHA
    673c999 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cb0667c View commit details
    Browse the repository at this point in the history
  3. Merge branch 'pr/scaleAnimations' of https://github.com/Liamandrew/re…

    …act-native into pr/scaleAnimations
    
    Merge upstream
    Liamandrew committed Mar 3, 2018
    Configuration menu
    Copy the full SHA
    2b633a2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8ae3395 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2018

  1. Reënable iOS and tvOS tests

    Summary:
    Although the test suites have a handful of failing tests, the jobs themselves do not fail.
    
    Let's get these tests back into the fold so that we may track our progress getting these back to a good state.
    
    cc dlowder-salesforce
    
    Run tests on Circle, and confirm everything is green: https://circleci.com/workflow-run/4dd1a84b-502d-4ad6-aa41-64c768392a6b
    
    If you go into the test iOS and test tvOS jobs, you will see that we are collecting test results at the top. These results show the failing individual tests.
    Closes #18171
    
    Differential Revision: D7151558
    
    Pulled By: hramos
    
    fbshipit-source-id: f105ec8bc97e80ed1b8358cde3f13a1ad3b271c2
    hramos authored and facebook-github-bot committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    498cf7e View commit details
    Browse the repository at this point in the history
  2. Fix Viewpager on Android when using native navigation.

    Summary:
    See the "broken" video attached to really understand the problem easily.
    
    On Android after navigating to any other screen using wix navigation library, the native viewpager would lose the settling page behaviour which is quite annoying for the users.
    
    This is caused by the onAttachedToWindow that resets mFirstLayout to true inside ViewPager. By request another layout pass, everything works as expected.
    
    Working video is the application with patched RN.
    
    [broken.mp4](https://github.com/facebook/react-native/files/1128028/broken.mp4.zip)
    [working.mp4](https://github.com/facebook/react-native/files/1128032/working.mp4.zip)
    Closes #14867
    
    Differential Revision: D7154981
    
    Pulled By: hramos
    
    fbshipit-source-id: 2b3570800a5320ed2c12c488748d9e1358936c84
    ruiaraujo authored and facebook-github-bot committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    a1295e1 View commit details
    Browse the repository at this point in the history
  3. Move fb_xplat_cxx.bzl to xplat/build_defs

    Reviewed By: mzlee, ttsugriy
    
    Differential Revision: D7152463
    
    fbshipit-source-id: ad7ca85f225343a043e2f606c6b3bbf74f42bbcd
    Jonathan Kim authored and facebook-github-bot committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    f389ad8 View commit details
    Browse the repository at this point in the history
  4. Remove log in JSDevSupportModule

    Reviewed By: fkgozali
    
    Differential Revision: D7138115
    
    fbshipit-source-id: f9cdda250b60a305195e01a11d0907f658d0a9d1
    mdvacca authored and facebook-github-bot committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    8769057 View commit details
    Browse the repository at this point in the history
  5. Revert "Better Android Gradle Plugin 3.x integration"

    Summary:
    This reverts commit d16ff3b.
    
    Currently breaks with the gradle version used by RN, I think there has been some work to update that to a more recent one but for now I think we should just revert it.
    
    It errors with:
    
    ```
    Could not find method registerGeneratedResFolders() for arguments [file collection] on object of type com.android.build.gradle.internal.api.ApplicationVariantImpl.
    ```
    
    Tested that RN tester now builds when using the right react.gradle (#18188)
    
    [ ANDROID ] [ BUGFIX ] [ react.gradle ] - REVERT "Support Android Gradle Plugin 3.x and AAPT2"
    [ ANDROID ] [ FEATURE ] [ react.gradle ] - REVERT "Expose the bundling task and its outputs via ext properties"
    Closes #18189
    
    Differential Revision: D7155176
    
    Pulled By: hramos
    
    fbshipit-source-id: 87b7b80b39cd345eebac4631efe6697971a1dbdf
    janicduplessis authored and facebook-github-bot committed Mar 5, 2018
    1 Configuration menu
    Copy the full SHA
    3f8a04b View commit details
    Browse the repository at this point in the history
  6. Use react.gradle from repo root instead of copy in RNTester

    Summary:
    RNTester used a copy of the main react.gradle file instead of the real one. Recent changes to the real file caused builds to fail with older gradle versions but was not caught by CI because it wasn't using that file for RNTester. That copy of react.gradle is just a leftover from when projects included a copy instead of importing the one in RN directly.
    
    Note: CI WILL fail with this PR, if we have trouble landing this I can add the revert in this commit too but wanted to keep it as 2 separate commits.
    
    Tested that building RNTester actually fails now that it uses react.gradle with recent changes, then tested that is builds properly when reverting d16ff3b.
    
    [INTERNAL] [MINOR] [RNTester] - Use react.gradle from repo root instead of copy in RNTester
    Closes #18188
    
    Differential Revision: D7155179
    
    Pulled By: hramos
    
    fbshipit-source-id: 15b461a63b841bf807e7d11ba3ead005ca5e33b0
    janicduplessis authored and facebook-github-bot committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    9f239d7 View commit details
    Browse the repository at this point in the history
  7. Refactor BridgeListener into JSIModulesProvider

    Reviewed By: achen1
    
    Differential Revision: D7140944
    
    fbshipit-source-id: 092ea8569af5b5f90e005d6dc2c1819c1c9cf58f
    mdvacca authored and facebook-github-bot committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    4466b6f View commit details
    Browse the repository at this point in the history
  8. Update VirtualizedList to not throw with double constructor

    Summary: constructor shouldn't have side effects.
    
    Reviewed By: sahrens
    
    Differential Revision: D7146018
    
    fbshipit-source-id: 0ca311e48d6bad81988ed48605c8134068c482da
    sophiebits authored and facebook-github-bot committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    19b9851 View commit details
    Browse the repository at this point in the history
  9. Update node-notifier (has mem leak fix)

    Summary:
    Noticed that we're on a version of node-notifier that has a leak mentioned [here](mikaelbr/node-notifier#183) and fixed in the newest version.
    
    Automated tests
    
     [INTERNAL] [BUGFIX] [package.json] - Update node-notifier dependency
    Closes #18033
    
    Differential Revision: D7102637
    
    Pulled By: hramos
    
    fbshipit-source-id: 850f3d826c1d880a6281d95e4d5af68e9af89927
    rickhanlonii authored and facebook-github-bot committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    860fcd4 View commit details
    Browse the repository at this point in the history
  10. Remove callFunctionSync experimental APIs

    Reviewed By: michalgr
    
    Differential Revision: D6124038
    
    fbshipit-source-id: 219afe30783da92cf10f800dc35e64823b61cf4b
    Dan Zimmerman authored and facebook-github-bot committed Mar 5, 2018
    1 Configuration menu
    Copy the full SHA
    19a4a7d View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2018

  1. Update opacity when disabled prop is changed

    Summary:
    fixes #17105
    
    If you render
    
    ```
        <TouchableOpacity
            disabled={true}
            style={{opacity: 0.5}}
        >
            ...
        </TouchableOpacity>
    ```
    
    and then
    
    ```
        <TouchableOpacity
            disabled={false}
            style={{opacity: 1}}
        >
            ...
        </TouchableOpacity>
    ```
    
    The content of `TouchableOpacity` will still have opacity = 0.5 because real
    opacity is controlled by animated property which should be properly updated
    when `disabled` prop changes.
    
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    Usually when a button or other UI component is built with `TouchableOpacity` you may want to change it's opacity if state of component is changed (enabled/disabled). Opacity provided in props is overridden with internally-managed animated value. Add extra check when component is updated to trigger opacity animation upon change of `disabled` flag.
    
    You can use code from #17105.
    
    (If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/react-native-website, and link to your PR here.)
    
    [GENERAL][BUGFIX][TouchableOpacity] - trigger animation on `opacity` upon change in `disabled` prop.
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [CATEGORY] [TYPE] [LOCATION] - MESSAGE
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    Closes #17106
    
    Differential Revision: D7158549
    
    Pulled By: hramos
    
    fbshipit-source-id: 209cc433b829b129810e8a884964c8853ca3fe8f
    maxkomarychev authored and facebook-github-bot committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    9366ce4 View commit details
    Browse the repository at this point in the history
  2. iOS: branch out Fabric handling into a separate RCTSurface-compatible…

    … class.
    
    Reviewed By: mmmulani
    
    Differential Revision: D7158824
    
    fbshipit-source-id: 80eb61835181fa3f522b788e2861470cba88890a
    fkgozali authored and facebook-github-bot committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    b4ce427 View commit details
    Browse the repository at this point in the history
  3. Remove polymorphic types from StyleSheetTypes

    Summary:
    These types were polymorphic so that stricter types could be passed in for dimension or color. For example, color could be a union of allowed colors. However, since `rgb(0,0,0)` is a valid color, these would have to be allowed opaque types and every creator or caller of these colors would have to use a function.
    
    This would require a massive change to every RN product in the world for negligable gain because StyleSheet values are validated at dev at runtime and cause redboxes for invalid uses.
    
    Since we don't plan to adopt these widely, lets clean up the complexity of these types.
    
    Reviewed By: sahrens
    
    Differential Revision: D7158920
    
    fbshipit-source-id: c58ae402c8248b0863c217c27153191a49c6b980
    elicwhite authored and facebook-github-bot committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    b98bf1e View commit details
    Browse the repository at this point in the history
  4. Using ReadOnly and Exact types for StyleSheet

    Summary: There are a few more things that need to be tightened up but they cause *tons* of errors in FBSource and require more investigation before we can change them.
    
    Reviewed By: sahrens
    
    Differential Revision: D7160522
    
    fbshipit-source-id: 17167efd80fd6c3bac5a055d2ab58b3b251c1b8b
    elicwhite authored and facebook-github-bot committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    b6c7e55 View commit details
    Browse the repository at this point in the history
  5. Fix lint in StyleSheet.compose

    Reviewed By: TheSavior, yungsters
    
    Differential Revision: D7106910
    
    fbshipit-source-id: e150c6622bb1af9830eef06757897d42002f5676
    sahrens authored and facebook-github-bot committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    52c7957 View commit details
    Browse the repository at this point in the history
  6. Fix subtle bugs in cloning and FabricUIManager

    Reviewed By: achen1
    
    Differential Revision: D7164980
    
    fbshipit-source-id: 86e9f3f11b67c8947b177aac23f99808083c3121
    mdvacca authored and facebook-github-bot committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    ac929ef View commit details
    Browse the repository at this point in the history
  7. Generalize JavaOnlyMap's getMap

    Reviewed By: mdvacca
    
    Differential Revision: D7165678
    
    fbshipit-source-id: 3dd88b24c89af369c9d5f3cc57c96f29c4f10d47
    ayc1 authored and facebook-github-bot committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    e839c91 View commit details
    Browse the repository at this point in the history
  8. Initial changes to add layout animation

    Adjust scale parameters correctly
    
    scale animation commit
    Liamandrew committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    9d6c798 View commit details
    Browse the repository at this point in the history
  9. Merge branch 'pr/scaleAnimations' of https://github.com/Liamandrew/re…

    …act-native into pr/scaleAnimations
    
    merge upstream
    Liamandrew committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    23cbb21 View commit details
    Browse the repository at this point in the history
  10. remove dependency

    Liamandrew committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    460ef0f View commit details
    Browse the repository at this point in the history