Fix issue #21065 getInspectorDataForViewTag is not a function #21237

TranLuongTuanAnh · 2018-09-21T06:16:18Z

Fix renderer.getInspectorDataForViewTag is not a function when try Toggle Inspector

Release Notes:

[BUGFIX] [MINOR] [/react-native/Libraries/Inspector/Inspector.js]

fix renderer.getInspectorDataForViewTag is not a function

Fix renderer.getInspectorDataForViewTag is not a function when try Toggle Inspector

facebook-github-bot · 2018-09-21T06:16:32Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

analysis-bot

eslint found some issues. You may run yarn prettier or npm run prettier to fix these.

analysis-bot · 2018-09-21T06:18:26Z

Libraries/Inspector/Inspector.js

-    const inspectorData = renderer.getInspectorDataForViewTag(touchedViewTag);
-    if (inspectorData.hierarchy.length > 0) {
-      return inspectorData;
+    if (Object.prototype.hasOwnProperty.call(renderer, 'getInspectorDataForViewTag')) {


prettier/prettier: Replace Object.prototype.hasOwnProperty.call(renderer,·'getInspectorDataForViewTag') with ⏎······Object.prototype.hasOwnProperty.call(⏎········renderer,⏎········'getInspectorDataForViewTag',⏎······)⏎····

pull-bot · 2018-09-21T06:18:34Z

	Warnings
⚠️	📋 Test Plan - This PR appears to be missing a Test Plan.
⚠️	📋 Release Notes - This PR may have incorrectly formatted Release Notes.

Generated by 🚫 dangerJS

hramos · 2018-12-11T21:16:46Z

Would you mind adding a test plan to your PR?

cpojer · 2019-01-22T13:56:38Z

@TranLuongTuanAnh thank you for your PR. Unfortunately, there is no explanation for this pull request in terms of how to reproduce this issue and what it actually fixes. Since there hasn't been a reply in more than a month. I'm going to close this PR, but I am happy to reopen and land it if you can add the information back.

th317erd · 2019-01-25T23:46:09Z

This should be reopened. See here: #21065

hramos · 2019-01-26T00:30:28Z

@th317erd would you mind opening a new PR? Please make sure to address the feedback from this thread when doing so.

th317erd · 2019-01-26T16:48:38Z

No @hramos, this PR is fine, and just needs to be reopened. If you need another PR request from the author just ask. Besides, it peeves me greatly to try and follow Facebook's stringent and ridiculous "Community Guidelines". They essentially bitch-slap their community members all the time by closing PRs, closing and locking legitimate bug requests, being rude, and generally having the all around "don't give a shit about our community" attitude. I am not eager to help out the Facebook community because of this, and because nearly every interaction I have had with one of their developers has been a negative experience. If they don't want the help from the community (that IMHO is blatantly obvious through their actions and attitude), that is Facebook's problem, not mine. Sorry, normally with any other community I would be happy to help, not this time.

cpojer · 2019-01-28T09:23:06Z

@th317erd thanks for making me realize I missed the issue number in the title, oops! I edited the summary to add the issue as well. I'm sorry that we disappointed you in the past and hope we can win back your trust in the future. We are working hard on getting React Native open source into a manageable state but it will take a while.

@TranLuongTuanAnh Unfortunately I cannot land your fix unless you sign the CLA. Please go to https://code.facebook.com/cla to sign it so we can land this change. Thank you :)

facebook-github-bot · 2019-01-28T09:29:46Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

cpojer · 2019-01-28T09:33:30Z

Thanks for the quick turnaround. Landing this PR now.

th317erd · 2019-01-28T16:46:16Z

Thank you @cpojer!

…facebook#21237) Summary: Fix renderer.getInspectorDataForViewTag is not a function when try Toggle Inspector Fixes facebook#21065 Release Notes: -------------- [BUGFIX] [MINOR] [/react-native/Libraries/Inspector/Inspector.js] Pull Request resolved: facebook#21237 Differential Revision: D13838339 Pulled By: cpojer fbshipit-source-id: 363a4beba211e7868395578c7941cbda119bc753

tkow · 2019-03-05T07:00:37Z

~~Is any progress?~~

I'm sorry, I got it under way.
46f3285

TranLuongTuanAnh added 3 commits September 19, 2018 13:04

fix README markdown

82e0439

Update Inspector.js

d0966dc

fix renderer.getInspectorDataForViewTag is not a function

Fix getInspectorDataForViewTag is not a function

f733389

Fix renderer.getInspectorDataForViewTag is not a function when try Toggle Inspector

analysis-bot suggested changes Sep 21, 2018

View reviewed changes

react-native-bot added Missing Test Plan This PR appears to be missing a test plan. Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. 🔶Components labels Sep 21, 2018

TranLuongTuanAnh added 2 commits October 3, 2018 15:45

fix prettier

a6e226c

fix prettier

7d061e7

hramos added ✅Changelog and removed Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. labels Jan 15, 2019

cpojer closed this Jan 22, 2019

cpojer reopened this Jan 28, 2019

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 28, 2019

facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Jan 28, 2019

facebook-github-bot approved these changes Jan 28, 2019

View reviewed changes

cpojer approved these changes Jan 28, 2019

View reviewed changes

facebook-github-bot closed this in 46f3285 Jan 28, 2019

hramos added the Merged This PR has been merged. label Mar 8, 2019

react-native-bot removed the Import Started This pull request has been imported. This does not imply the PR has been approved. label Mar 8, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix issue #21065 getInspectorDataForViewTag is not a function #21237

Fix issue #21065 getInspectorDataForViewTag is not a function #21237

TranLuongTuanAnh commented Sep 21, 2018 •

edited by cpojer

Loading

facebook-github-bot commented Sep 21, 2018

analysis-bot left a comment

analysis-bot Sep 21, 2018

pull-bot commented Sep 21, 2018

hramos commented Dec 11, 2018

cpojer commented Jan 22, 2019

th317erd commented Jan 25, 2019

hramos commented Jan 26, 2019

th317erd commented Jan 26, 2019

cpojer commented Jan 28, 2019

facebook-github-bot commented Jan 28, 2019

facebook-github-bot left a comment

cpojer commented Jan 28, 2019 •

edited

Loading

th317erd commented Jan 28, 2019

tkow commented Mar 5, 2019 •

edited

Loading

Fix issue #21065 getInspectorDataForViewTag is not a function #21237

Fix issue #21065 getInspectorDataForViewTag is not a function #21237

Conversation

TranLuongTuanAnh commented Sep 21, 2018 • edited by cpojer Loading

Release Notes:

facebook-github-bot commented Sep 21, 2018

analysis-bot left a comment

Choose a reason for hiding this comment

analysis-bot Sep 21, 2018

Choose a reason for hiding this comment

pull-bot commented Sep 21, 2018

hramos commented Dec 11, 2018

cpojer commented Jan 22, 2019

th317erd commented Jan 25, 2019

hramos commented Jan 26, 2019

th317erd commented Jan 26, 2019

cpojer commented Jan 28, 2019

facebook-github-bot commented Jan 28, 2019

facebook-github-bot left a comment

Choose a reason for hiding this comment

cpojer commented Jan 28, 2019 • edited Loading

th317erd commented Jan 28, 2019

tkow commented Mar 5, 2019 • edited Loading

TranLuongTuanAnh commented Sep 21, 2018 •

edited by cpojer

Loading

cpojer commented Jan 28, 2019 •

edited

Loading

tkow commented Mar 5, 2019 •

edited

Loading