Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #21065 getInspectorDataForViewTag is not a function #21237

Closed
wants to merge 5 commits into from
Closed

Fix issue #21065 getInspectorDataForViewTag is not a function #21237

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
82e0439
fix README markdown
TranLuongTuanAnh Sep 19, 2018
d0966dc
Update Inspector.js
TranLuongTuanAnh Sep 21, 2018
f733389
Fix getInspectorDataForViewTag is not a function
TranLuongTuanAnh Sep 21, 2018
a6e226c
fix prettier
TranLuongTuanAnh Oct 3, 2018
7d061e7
fix prettier
TranLuongTuanAnh Oct 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions Libraries/Inspector/Inspector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,11 @@ function findRenderers(): $ReadOnlyArray<ReactRenderer> {
function getInspectorDataForViewTag(touchedViewTag: number) {
for (let i = 0; i < renderers.length; i++) {
const renderer = renderers[i];
const inspectorData = renderer.getInspectorDataForViewTag(touchedViewTag);
if (inspectorData.hierarchy.length > 0) {
return inspectorData;
if (Object.prototype.hasOwnProperty.call(renderer, 'getInspectorDataForViewTag')) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier/prettier: Replace Object.prototype.hasOwnProperty.call(renderer,·'getInspectorDataForViewTag') with ⏎······Object.prototype.hasOwnProperty.call(⏎········renderer,⏎········'getInspectorDataForViewTag',⏎······)⏎····

const inspectorData = renderer.getInspectorDataForViewTag(touchedViewTag);
if (inspectorData.hierarchy.length > 0) {
return inspectorData;
}
}
}
throw new Error('Expected to find at least one React renderer.');
Expand Down