Update dependency: schedule/tracking -> schedule/tracing #21246
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
react-native-bot
added
Missing Test Plan
Generated by 🚫 dangerJS |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
I wanted to make such PR, but I decided to not do it, because currently React Native is locked on React Besides that, it's great to see the support for the newest React in this PR! 🎉 |
|
@yairopro Thanks for the PR! This code actually lives in the react repo and is synced when we update the react version. Right now RN is only compatible with react@16.5.0 so you need to lock the version to that. We'll probably update the react version soon. cc @yungsters who did the last sync :) |
|
I believe @bvaughn is already working on the next sync. |
|
Thanks guys. |
|
Yes, this PR can be closed. 😄 The tracking -> tracing rename needs to happen (and has already been made) in the react repo anyway, because that's where the ReactNative renderer is built and synced from. So long as you're using the version of "react" that "react-native" pins to, the dependencies should line up correctly. Using a different version of "react" than the explicitly pinned dependency may cause problems like this, but that was never supported. |
|
I have update my react-native project from 0.57.8 to 0.59.1 it's give me the same error. After that I have update to 0.53.9 and it's give me the same result. I have try all of these works. But non worked for me. Can anyone help me on this. |
Summary: This sync includes the following changes: - **[bd7f4a013](facebook/react@bd7f4a013 )**: Fix sloppy factoring in `performSyncWorkOnRoot` ([#21246](facebook/react#21246)) //<Andrew Clark>// - **[78120032d](facebook/react@78120032d )**: Remove `flushDiscreteUpdates` from end of event ([#21223](facebook/react#21223)) //<Andrew Clark>// - **[a3a7adb83](facebook/react@a3a7adb83 )**: Turn off enableSyncDefaultUpdates in test renderer ([#21319](facebook/react#21319)) //<Ricky>// - **[cdb6b4c55](facebook/react@cdb6b4c55 )**: Only hide outermost host nodes when Offscreen is hidden ([#21250](facebook/react#21250)) //<Brian Vaughn>// - **[b9c6a2b30](facebook/react@b9c6a2b30 )**: Remove LayoutStatic check from commit phase ([#21249](facebook/react#21249)) //<Brian Vaughn>// - **[af1a4cbf7](facebook/react@af1a4cbf7 )**: Revert expiration for retry lanes ([#21300](facebook/react#21300)) //<Andrew Clark>// - **[cc4b431da](facebook/react@cc4b431da )**: Mark boundary as client rendered even if aborting fallback ([#21294](facebook/react#21294)) //<Sebastian Markbåge>// Changelog: [General][Changed] - React Native sync for revisions f7cdc89...bd7f4a0 jest_e2e[run_all_tests] Reviewed By: JoshuaGross Differential Revision: D27909257 fbshipit-source-id: 36ec4cf1de9df109f1fe1542031df10a693baae0
Fixes #21150
I just updated the dependency's name and module name (from
trackingtotracing). If tests don't pass, that means that they didn't pass either before.As this comment pointed out, the dependency's name has changed.
Updating the dependency's name fixed the bug.