Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate ci to official docker #21477

Closed
wants to merge 17 commits into from
Closed

migrate ci to official docker #21477

wants to merge 17 commits into from

Conversation

gengjiawen
Copy link
Contributor

@gengjiawen gengjiawen commented Oct 4, 2018 •
edited
Loading

Motivation

Simplify current build and offer it to community as official docker.
I have also created an rfc.

Test Plan

pass all current ci.

Related PRs

none

Release Notes

[GENERAL] [INTERNAL] [CI] - migrate ci to official docker

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 4, 2018
@react-native-bot react-native-bot added Core Team Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. labels Oct 4, 2018
@gengjiawen gengjiawen changed the title migrate ci to official docker [WIP]migrate ci to official docker Oct 4, 2018
@gengjiawen gengjiawen changed the title [WIP]migrate ci to official docker migrate ci to official docker Oct 5, 2018
@gengjiawen
Copy link
Contributor Author

@hramos Collect Test Results failed, but looks like not related to this pr.

@hramos
Copy link
Contributor

hramos commented Oct 5, 2018

Thanks for taking a stab at this. Happy to set up Docker accounts as needed. I'll try to review this sooner rather than later.

@hramos hramos self-assigned this Oct 5, 2018
@hramos hramos added ✅Test Plan 🔩Test Infrastructure Test infrastructure and continuous integration. and removed Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. labels Oct 5, 2018
@gengjiawen
Copy link
Contributor Author

@hramos ping.

@gengjiawen gengjiawen mentioned this pull request Nov 20, 2018
Closed
@dulmandakh
Copy link
Contributor

@gengjiawen where I can find Dockerfile for your image?

@gengjiawen
Copy link
Contributor Author

see ContainerShip/Dockerfile.android-base in this pr.

@gengjiawen
Copy link
Contributor Author

Current build failure due to circle ci limit docker memory to 4GB.

@pull-bot
Copy link

pull-bot commented Jan 19, 2019 •
edited
Loading

Warnings
⚠️

🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
⚠️

📋 Changelog - This PR appears to be missing Changelog. Please add a section called "changelog" and format it as explained in the contributing guidelines.

Generated by 🚫 dangerJS

@cpojer
Copy link
Contributor

cpojer commented Jan 22, 2019

What's the status of this PR?

@gengjiawen
Copy link
Contributor Author

wait for android ci fixed on master.

@gengjiawen
add missing tag
e512d72
@gengjiawen
add java home
f4e4eb9
@gengjiawen
fix docker dir
cbc35c4
@gengjiawen
remove test env temporally
6cde95f
@gengjiawen
remove validate test-env for now
b93521e 
Signed-off-by: gengjiawen <technicalcute@gmail.com>
@gengjiawen
clean up
6b1a2d0 
Signed-off-by: gengjiawen <technicalcute@gmail.com>
@gengjiawen
oh, partial commit :(
ba155cb 
Signed-off-by: gengjiawen <technicalcute@gmail.com>
@gengjiawen
remove publish script and try to fix memory issue.
2d14f02 
Signed-off-by: gengjiawen <technicalcute@gmail.com>
@gengjiawen
remove redundant file
3ae7b14 
Signed-off-by: gengjiawen <technicalcute@gmail.com>
@gengjiawen
update package.json
722abe4 
Signed-off-by: gengjiawen <technicalcute@gmail.com>
@gengjiawen gengjiawen requested a review from hramos as a code owner January 24, 2019 12:14
@gengjiawen
fix cache
909e08e 
Signed-off-by: gengjiawen <technicalcute@gmail.com>
@gengjiawen
fix buck
bb11aa8 
Signed-off-by: gengjiawen <technicalcute@gmail.com>
@gengjiawen
Copy link
Contributor Author

cc @hramos @cpojer Please review.

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Jan 24, 2019
facebook-github-bot
facebook-github-bot approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

cpojer
cpojer approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I really like how it simplifies the setup from this repo.

@react-native-bot
Copy link
Collaborator

@gengjiawen merged commit 9351dd6 into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Jan 24, 2019
@react-native-bot react-native-bot added the Merged This PR has been merged. label Jan 24, 2019
@dulmandakh
Copy link
Contributor

dulmandakh commented Jan 24, 2019 •
edited
Loading

@gengjiawen this is huge a milestone in Android CI. Congratulations 👏👍

@gengjiawen
Copy link
Contributor Author

@dulmandakh Thanks for working with me for the docker build.

@gengjiawen gengjiawen deleted the feature/docker_ci branch January 24, 2019 16:18
@hramos
Copy link
Contributor

hramos commented Jan 24, 2019

<3

@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 6, 2019
matt-oakes pushed a commit to matt-oakes/react-native that referenced this pull request Feb 7, 2019
@gengjiawen @facebook-github-bot
migrate ci to official docker (facebook#21477)
2ff2a5c 
Summary:
Simplify current build and offer it to community as official docker.
I have also created an [rfc](react-native-community/discussions-and-proposals#36).
pass all current ci.
none
 [GENERAL] [INTERNAL] [CI] - migrate ci to official docker
Pull Request resolved: facebook#21477

Differential Revision: D13801696

Pulled By: cpojer

fbshipit-source-id: fa235cf21ab5af2c87eb3c1a14788fab01c71ccf
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

@cpojer cpojer cpojer approved these changes

@dulmandakh dulmandakh Awaiting requested review from dulmandakh

@hramos hramos Awaiting requested review from hramos

Assignees

@hramos hramos

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. 🔩Test Infrastructure Test infrastructure and continuous integration.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gengjiawen @hramos @dulmandakh @pull-bot @cpojer @react-native-bot @facebook-github-bot