Official Android Docker for react native

[gengjiawen]

Provide an official docker to the community and make the ci easier.

[kelset]

👋 @gengjiawen!

If I understand correctly, this would mean maintain like a docker image in the registry/marketplace so that people can just write something like FROM react_native_android:latest in their Dockerfile, right?

Does it mean that we should have a version of the image per each RN release?

[gengjiawen]

Yes, you are right, just import the image and add the build script is enough.

Actually if we have not touch the Dockerfile, there is no need to publish a new one.

But if we hook the publish docker script when we draft a new release, it maybe easier this way by not publishing the docker manually.

[axe-fb]

Does this have to be a part of core react native ? Can it not live separately in react-native-community ?

[gengjiawen]

yes, I think it can move out.

[satya164]

@gengjiawen lemme know if you want to create a repo in react-native-community. I can help with that.

[axe-fb]

@gengjiawen - Once we have moved it out, can we also delete the images from the core repo ?

[axe-fb]

Should we close this issue since we have a resolution for it ?

[gengjiawen]

Once we have moved it out, can we also delete the images from the core repo ?

@axe-fb Yes, maybe remove some script in package.json, but I need @hramos opinion on this.

Should we close this issue since we have a resolution for it ?

Maybe not for now, I want this to get community know this more and discuss how this pr will go.

@gengjiawen lemme know if you want to create a repo in react-native-community. I can help with that.

@satya164 Not for now, but maybe later, I will let you know if it needs, thanks.

[gengjiawen]

I don't want to maintain two same file in two repo, is the dockerfile used internally at facebook @axe-fb ?

[gengjiawen]

@satya164 Can you create a repo for me, I think I want to try it in community due to facebook/react-native-website#653.

[sibelius]

https://twitter.com/sseraphini/status/1061919273113829376

We have this docker image https://github.com/entria/docker-react-native-android

we've been using it on some open source projects like react-native-camera and react-native-share

[gengjiawen]

@sibelius The docker is intended to do more then build an react native android app, it also has the ability to build and test react native source code.

[axe-fb]

@gengjiawen - what are the next steps on this proposal ?

[gengjiawen]

@axe-fb I need @hramos opinion on this, to see whether or not move the Dockerfile out of the main repo.

[axe-fb]

@gengjiawen - should we merge this PR, since we will now be acting upon the proposal ?

[gengjiawen]

I think it can merge.