Update Gradle wrapper to 5.6

[friederbluemle]

Summary

Welcome to Gradle 5.6!

Here are the highlights of this release:
 - Incremental Groovy compilation
 - Groovy compile avoidance
 - Test fixtures for Java projects
 - Manage plugin versions via settings script

For more details see https://docs.gradle.org/5.6/release-notes.html

Changelog

[Android] [Changed] - Gradle wrapper 5.6

Test Plan

Ran build and tests locally.

[gengjiawen]

I don't see this necessary, can you explain why ?

[friederbluemle]

Hi @gengjiawen - Thanks for taking time to review the PR!
Manually increasing the heap space was necessary because of the way the build is run on AppVeyor. There is no gradle.properties file in the root directory of the repo (even though it contains the Gradle wrapper scripts and Gradle build files). You can see it directly runs the assembleRelease task in RNTester/android - It might not immediately be obvious, but when called that way it will not pick up the Gradle settings from that directory, and instead use the default heap space of only 64MB! Previously it failed because it was running out of heap space. However, it looks like the AppVeyor CI build was disabled in 382cb05, so this line modification might not be needed anymore (at least for now). Let me try to remove it.

[gengjiawen]

It's removed because android failed to run due to low memory. We intend to re-enable it later.
So maybe just leave it be.

[gengjiawen]

same here

[friederbluemle]

Actually, the update to this file has been missing for a very long time. The default Android project templates as generated by Android Studio include the setting of the jvmargs to -Xmx1536m. Running with lower heap space might degrade performance or fail the build. You can check by just generating any new project in Android Studio and open the gradle.properties file.

[gengjiawen]

Those default is fit for project like react native, it's likely you can't run on machine memory like than 8GB.

[dulmandakh]

@friederbluemle could you please revert some changes @gengjiawen requested?

[friederbluemle]

@dulmandakh - Thanks for your comment. I reverted the line. Do you also want me to undo the change in the .appveyor config file?

[dulmandakh]

@friederbluemle usually it's best to change one thing in a PR, or version bump in this case. So please revert changes that are not related to version change.

[friederbluemle]

Okay, I also reverted the change to .appveyor/config.yml.

[friederbluemle]

FYI, the changes to the wrapper scripts were done automatically by the wrapper task (of a newer Gradle version) - I did not manually modify these files. Since they are directly related to the Gradle wrapper, I think it makes sense to include them here too?

[dulmandakh]

how about template/android/gradle.properties?

[friederbluemle]

These are just a few comments, in a file directly related to the Gradle wrapper, to bring it in sync with the default template. I agree they could be independent from the version update. Having a separate PR seemed a bit excessive to me though. Of course, if you prefer, I will exclude them here as well.

[dulmandakh]

@cpojer @hramos please merge 👍

[friederbluemle]

Thanks @dulmandakh @gengjiawen

[dulmandakh]

@friederbluemle you don't need to sync with master unless there is a conflict. thanks, let's wait for reviewers to merge the change.

[friederbluemle]

@dulmandakh - Okay sure, I won't push the branch anymore. I just like to keep branches fully rebased to make sure everything works with the latest base branch. Related to that - Do you happen to know when the CI will be fully working again? I assume work is already being done?

[friederbluemle]

@mdvacca - Could you also take a quick look please? @dulmandakh and @gengjiawen have approved it already. Thanks!

[mdvacca]

LGTM

[facebook-github-bot]

@mdvacca is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @friederbluemle in be2a252.

^{When will my fix make it into a release? | Upcoming Releases}

[friederbluemle]

@grabbou - Any reason this was reverted (6830ec8) on the 0.61-stable branch, after being cherry-picked (afd3529)?

[dulmandakh]

it because I forgot to mention that 7c8e266 needs to be cherry-picked too

[friederbluemle]

No, this is about the Gradle wrapper update.. There is no cross dependency on the Android Gradle plugin update. Those are two separate things. Both 3.4.1 and 3.5.0 work fine with Gradle 5.6.