[Headers] Add an umbrella header for the library #261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ide
force-pushed
the
umbrella-header
branch
2 times, most recently
from
4bdad02 to
78a49d0
Compare
|
cc @tadeuzagallo too. |
|
This has been kind of hacked together as React Native has been refactored, so I think the concept stands but each library should have its own umbrella header, and then maybe have a master umbrella header that imports the core + ubiquitous libraries (text, image support but not geolocation, vibration, etc). |
|
Sounds good. Everything that is non-optional is exposed in this header, and one more header per subspec. |
The umbrella header allows projects that link React Native using CocoaPods to import it in standard fashion: `#import <React/React.h>`. Currently all of the headers are exported so that external projects can experiment.
Generated with:
find React -name "*.h" | awk -F'/' '{print "#import <React/"$NF">"}' > React/React.h
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 17, 2017
Summary: Fixes #261 Closes facebook/yoga#262 Reviewed By: splhack Differential Revision: D4245200 Pulled By: emilsjolander fbshipit-source-id: 77d802d71010ed426511d6a01e6de1e7c9194179
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Jan 19, 2017
Summary: Fixes facebook#261 Closes facebook/yoga#262 Reviewed By: splhack Differential Revision: D4245200 Pulled By: emilsjolander fbshipit-source-id: 77d802d71010ed426511d6a01e6de1e7c9194179
mganandraj
pushed a commit
to mganandraj/react-native
that referenced
this pull request
Mar 26, 2020
ayushjainrksh
referenced
this pull request
in MLH-Fellowship/react-native
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The umbrella header allows projects that link React Native using CocoaPods to import it in standard fashion:
#import <React/React.h>. Currently all of the headers are exported so that external projects can experiment.