-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Headers] Add an umbrella header for the library #653
Conversation
3a0b8aa
to
3ccf996
Compare
15a4832
to
7ae4e30
Compare
Not a bad idea, but I'm concerned about the maintenance burden of keeping this up to date. It's also probably not necessary to include most/any of the view and viewmanagers, as they're effectively private - they're only exposed to the JS code. |
@nicklockwood - i agree about the maintenance upkeep. I could make a little script that adds all the headers under Base and Executors, and then have a manually curated list of headers under Views (e.g. the categories). |
@nicklockwood - there is now a little bash script that generates the umbrella header that pulls in Base+Executors and some headers I handpicked from Views. To reduce the chance of breakage (specifically removing/renaming a header and not removing it from the umbrella - although I imagine codemod/git grep would pick up the change anyway), I'll update the example projects to use the umbrella header if this looks good to you. |
2b01eca
to
28232ca
Compare
over to nick to decide if we want to do this and review or close it out as something we don't want. |
1a3b8de
to
b149bd5
Compare
acdc1f5
to
d48ae55
Compare
Presently in RN macOS, clickable views (buttons, etc.) require two clicks when that window is not in the foreground. This counter to the typical behavior on macOS where controls will default to accepting the mouse event even when in the background (and simultaneously bring to the foreground unless the command key is held).
Previous discussion in #261, looks like I accidentally closed it...
The umbrella header allows projects that link React Native to import it in standard fashion:
#import <React/React.h>
. Only some headers are included based on what I've found to be useful.Generated with
scripts/generate-umbrella-header.sh
, which is a script that scans the Base and Executors directories for all headers and also includes some handpicked Views headers as well.