Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Headers] Add an umbrella header for the library #653

Closed
wants to merge 1 commit into from

Conversation

ide
Copy link
Contributor

@ide ide commented Apr 3, 2015

Previous discussion in #261, looks like I accidentally closed it...

The umbrella header allows projects that link React Native to import it in standard fashion: #import <React/React.h>. Only some headers are included based on what I've found to be useful.

Generated with scripts/generate-umbrella-header.sh, which is a script that scans the Base and Executors directories for all headers and also includes some handpicked Views headers as well.

@ide ide force-pushed the umbrella-header branch from 6a6a5c4 to d864611 Compare April 6, 2015 19:40
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 7, 2015
@ide ide force-pushed the umbrella-header branch 4 times, most recently from 3a0b8aa to 3ccf996 Compare April 15, 2015 21:00
@ide ide force-pushed the umbrella-header branch 3 times, most recently from 15a4832 to 7ae4e30 Compare April 29, 2015 03:46
@ide ide force-pushed the umbrella-header branch from 7ae4e30 to acd3dcf Compare April 29, 2015 20:21
@nicklockwood
Copy link
Contributor

Not a bad idea, but I'm concerned about the maintenance burden of keeping this up to date.

It's also probably not necessary to include most/any of the view and viewmanagers, as they're effectively private - they're only exposed to the JS code.

@ide
Copy link
Contributor Author

ide commented Apr 29, 2015

@nicklockwood - i agree about the maintenance upkeep. I could make a little script that adds all the headers under Base and Executors, and then have a manually curated list of headers under Views (e.g. the categories).

@ide ide force-pushed the umbrella-header branch from acd3dcf to 07ea8e0 Compare April 30, 2015 05:36
@ide
Copy link
Contributor Author

ide commented Apr 30, 2015

@nicklockwood - there is now a little bash script that generates the umbrella header that pulls in Base+Executors and some headers I handpicked from Views.

To reduce the chance of breakage (specifically removing/renaming a header and not removing it from the umbrella - although I imagine codemod/git grep would pick up the change anyway), I'll update the example projects to use the umbrella header if this looks good to you.

@ide ide force-pushed the umbrella-header branch 4 times, most recently from 2b01eca to 28232ca Compare May 8, 2015 21:51
@ide ide force-pushed the umbrella-header branch from 28232ca to cca9cce Compare May 13, 2015 23:03
@ide ide force-pushed the umbrella-header branch from cca9cce to bc465d0 Compare May 31, 2015 10:12
@sahrens
Copy link
Contributor

sahrens commented Jun 11, 2015

over to nick to decide if we want to do this and review or close it out as something we don't want.

@ide ide force-pushed the umbrella-header branch from bc465d0 to 56e9386 Compare June 13, 2015 01:47
@ide ide force-pushed the umbrella-header branch from 56e9386 to 1ca446b Compare July 2, 2015 19:01
@ide ide force-pushed the umbrella-header branch 2 times, most recently from 1a3b8de to b149bd5 Compare July 15, 2015 22:58
@ide ide force-pushed the umbrella-header branch 2 times, most recently from acdc1f5 to d48ae55 Compare September 2, 2015 20:01
@satya164 satya164 closed this Jan 26, 2016
ayushjainrksh referenced this pull request in MLH-Fellowship/react-native Jul 2, 2020
* Add section for how to make a git dependency branch (#653)

* move publishing a fork to separate page (#653)

* updated review comments

* link back from building android sources and updated docker link

* changed to —force instead of changing .gitignore

* Update publishing.md
thymikee pushed a commit to thymikee/react-native that referenced this pull request Dec 1, 2020
Presently in RN macOS, clickable views (buttons, etc.) require two clicks when that window is not in the foreground. This counter to the typical behavior on macOS where controls will default to accepting the mouse event even when in the background (and simultaneously bring to the foreground unless the command key is held).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants