Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update React.podspec to require cocoapods >= 1.10.1 #31134

Closed
wants to merge 2 commits into from

Conversation

sunnylqm
Copy link
Contributor

@sunnylqm sunnylqm commented Mar 11, 2021

According to #30922 (comment)
Cocoapods 1.10.1 is required to compile iOS deps (OpenSSL).

Fixes #30922 (comment)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 11, 2021
@sunnylqm sunnylqm changed the title Update React.podspec to require cocoapods >= 1.10 Update React.podspec to require cocoapods >= 1.10.1 Mar 11, 2021
@pull-bot
Copy link

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against e90485a

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 4fb9e2f

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,908,927 +0
android hermes armeabi-v7a 8,407,962 +0
android hermes x86 9,399,557 +0
android hermes x86_64 9,343,363 +0
android jsc arm64-v8a 10,642,481 +0
android jsc armeabi-v7a 10,124,616 +0
android jsc x86 10,694,615 +0
android jsc x86_64 11,278,685 +0

Base commit: 4fb9e2f

@facebook-github-bot
Copy link
Contributor

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@hramos merged this pull request in b50b7e3.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't compile initial project for iOS
4 participants