Road to v0.64 Discussion

[grabbou]

Current latest release: v0.64.0-rc.4

Highlighted Changes

• Hermes opt-in iOS
• Inline requires enabled by default
• new profile-hermes CLI command for converting Hermes tracing profile to Chrome format
• Hermes with Proxy support (will now support react-native-firebase, mobx)
• React 17
• Minimum supported Node version changed to 12
• Remove support of Android API levels 16 through 20. The new minSDK version will be 21+ moving forward
• Use of Xcode 12 and CocoaPods 1.10 is recommended to ensure no errors on iOS

Please see the changelog PR for more details.

Work Required

• Changelog (draft is here)
• Blog post [@grabbou]
• When clicking "Open Debugger" on iOS with Hermes and not having Flipper installed, nothing happens. Perhaps a warning / alert or an appropriate log in the CLI would be helpful to instruct those that don't have Flipper installed on the next steps.
• Dependency on shelljs has been moved from the root package.json into repo-config/package.json (facebook/react-native@f3930a9), causing publish-npm.js script to fail. I have temporarily installed that package on the CircleCI, but would love additional background on the original commit and whether we can safely move it back to the root. fix: release branches miss workspace dependencies facebook/react-native#30472
• Create Xcode project upgrade guide to link to from the Upgrade Helper
• Cut the docs

Already resolved

• Update documentation [@Simek]
• feat: Enable Hermes to work on iOS facebook/react-native#29914
• React 17 support (landed)
• [iOS] Fix cannot working Modal's onDismiss. facebook/react-native#29882
• Fix App Bundle/Release build missing index.android.bundle with gradle plugin 4.1.0+/gradle 6.5 facebook/react-native#30177
• facebook/react-native@a7c1c5a
• Bump CLI to latest
• Migrate warnings in index.js to point to new lean core repos (chore: updated url of deprecated modules facebook/react-native#30422)
• The hermes-engine pod has no version constraints specified, which should probably happen in the React-Core.podspec file and lock it with similar version constraints as the one applied to the Android version in package.json. Fixed by fix: pin hermes-engine to 0.7.x facebook/react-native#30432
• The newly introduced codegen invocation step in the iOS Podfile is failing, as the dependencies of the react-native-codegen package have not been installed. See output here. In progress PR here Integrate Native Module codegen into Xcode build pipeline facebook/react-native#30449
• Trying to build a newly created Android app fails when checking the dynamic libraries for duplicate classes. See output here. Fixed by include android in npm package facebook/react-native#30452
• fix: android artifacts in a release package facebook/react-native#30470
• The new CLI has a minor regression when using a local template dir, now you need to specify the file:// protocol to resolve that [@grabbou] (added note to changelog, this is expected)
• facebook/react-native@d85d5d2
• Update template devDependencies facebook/react-native#30489 (+ make sure to update the changelog as per this comment)
• Bump to Hermes 0.7.2 (What should be included in v0.7.2 facebook/hermes#373) (Bump Hermes to 0.7.2 for v0.64 facebook/react-native#30561)
• Add instructions on how to enable Hermes in the default application Add instructions to template/ios/Podfile for enabling hermes facebook/react-native#30461
• Running pod install outside of ios folder will fail fix(iOS): pod install fails outside ios folder facebook/react-native#30469 (temporary solution, will be fixed by Integrate Native Module codegen into Xcode build pipeline facebook/react-native#30449) - cherry picked facebook/react-native@c901c1f, facebook/react-native@5eee2f2 and facebook/react-native@b61aaa1 for the record.
• Submitting Hermes enabled application to AppStore will fail validation Invalid MinimumOSVersion. Apps that only support 64-bit devices must specify a deployment target of 8.0 or later. MinimumOSVersion in '[My App].app/Frameworks/hermes.framework' is ''." facebook/hermes#420 This isn't a release blocker; this issue is triggered when somebody specifies a higher deployment target than the default and can be solved by the user as shown here.
• fix: default template on iOS facebook/react-native#30571
• Building React Native application in release mode will cause an issue with Xcode 12 After updating to Xcode 12 I get The linked library 'libPods-*****.a' is missing one or more architectures required by this target: arm64. facebook/react-native#29984 (here is a workaround) fix: building in release mode for simulator facebook/react-native#30543
• [0.64.0-rc.1] - KeyboardAvoidingView freezes ios app when wrapped around a scrollview facebook/react-native#30495 (regression)
• Building with Hermes in Release mode (or with "build active architecture" set to false) causes "Thread-local storage is not supported for the current target" in "folly/synchronization/Rcu.cpp:17:10:" and happens while building for "i386". Exclude i386 from valid architectures when building with Hermes on iOS facebook/react-native#30592
• Resolve issues highlighted in the comment Road to v0.64 Discussion #214 (comment)
• facebook/react-native@811ccec
• facebook/react-native@7a9e4ba
• facebook/react-native@f312e5b
• facebook/react-native@f45cb60
• Issue stripping symbols on Android Road to v0.64 Discussion #214 (comment)
• Some users are experiencing issues with CodeGen on iOS due to missing files Road to v0.64 Discussion #214 (comment)

Hopeful Dates

We can never commit to the dates involved in a release as many things are out of our control. However, we are thinking about these rough dates for this release.

• Publish as Release Candidate: Week of January 18th
• Publish as Stable: Beginning of March

[mrousavy]

Awesome work on this! I'm really excited for Hermes running smoothly on iOS devices.

Resolved

So far, I've noticed two critical issues, and a minor inconvinience:

[Critical] AppStore double-checking the min iOS version on 64-bit archives

The Hermes framework, which gets bundled into your project when you enable hermes on iOS, only supports 64 bit architectures. As per Apple, "Apps that only support 64-bit devices must specify a deployment target of 8.0 or later.". The Hermes framework does not specify the MinimumOSVersion in it's Info.plist, and therefore uploading an app to AppStore/Testflight fails with the following output:

Fastlane logs

[11:13:59]: Going to upload updated app to App Store Connect
[11:13:59]: This might take a few minutes. Please don't interrupt the script.
[11:14:46]: [Transporter Error Output]: ERROR ITMS-90530: "Invalid MinimumOSVersion. Apps that only support 64-bit devices must specify a deployment target of 8.0 or later. MinimumOSVersion in '[My App].app/Frameworks/hermes.framework' is ''."
[11:14:46]: [Transporter Error Output]: ERROR ITMS-90360: "Missing Info.plist value. A value for the key 'MinimumOSVersion' in bundle [My App].app/Frameworks/hermes.framework is required."
[11:14:46]: [Transporter Error Output]: ERROR ITMS-90208: "Invalid Bundle. The bundle [My App].app/Frameworks/hermes.framework does not support the minimum OS Version specified in the Info.plist."
[11:14:46]: Transporter transfer failed.
[11:14:46]: 
[11:14:46]: ERROR ITMS-90530: "Invalid MinimumOSVersion. Apps that only support 64-bit devices must specify a deployment target of 8.0 or later. MinimumOSVersion in '[My App].app/Frameworks/hermes.framework' is ''."
ERROR ITMS-90360: "Missing Info.plist value. A value for the key 'MinimumOSVersion' in bundle [My App].app/Frameworks/hermes.framework is required."
ERROR ITMS-90208: "Invalid Bundle. The bundle [My App].app/Frameworks/hermes.framework does not support the minimum OS Version specified in the Info.plist."
[11:14:46]: [iTMSTransporter] [2020-11-24 11:14:46 CET] <main> ERROR: ERROR ITMS-90360: "Missing Info.plist value. A value for the key 'MinimumOSVersion' in bundle [My App].app/Frameworks/hermes.framework is required."

[11:14:46]: [iTMSTransporter] [2020-11-24 11:14:46 CET] <main> ERROR: ERROR ITMS-90208: "Invalid Bundle. The bundle [My App].app/Frameworks/hermes.framework does not support the minimum OS Version specified in the Info.plist."

[11:14:46]: [iTMSTransporter] [2020-11-24 11:14:46 CET] <main> DBG-X: The error code is: 1102

[11:14:46]: [iTMSTransporter] [2020-11-24 11:14:46 CET] <main>  INFO: Done performing authentication.

[11:14:46]: [iTMSTransporter] 

[11:14:46]: [iTMSTransporter] 

[11:14:46]: [iTMSTransporter] 

[11:14:46]: [iTMSTransporter] Package Summary:

[11:14:46]: [iTMSTransporter]  

[11:14:46]: [iTMSTransporter] 1 package(s) were not uploaded because they had problems:

[11:14:46]: [iTMSTransporter] 	/var/folders/3r/gxn72hgj7vl59jrshs0wxh600000gn/T/d20201124-44941-z1gelj/1535370501.itmsp - Error Messages:

[11:14:46]: [iTMSTransporter] 		ERROR ITMS-90530: "Invalid MinimumOSVersion. Apps that only support 64-bit devices must specify a deployment target of 8.0 or later. MinimumOSVersion in '[My App].app/Frameworks/hermes.framework' is ''."

[11:14:46]: [iTMSTransporter] 		ERROR ITMS-90360: "Missing Info.plist value. A value for the key 'MinimumOSVersion' in bundle [My App].app/Frameworks/hermes.framework is required."

[11:14:46]: [iTMSTransporter] 		ERROR ITMS-90208: "Invalid Bundle. The bundle [My App].app/Frameworks/hermes.framework does not support the minimum OS Version specified in the Info.plist."

[11:14:46]: [iTMSTransporter] [2020-11-24 11:14:46 CET] <main> DBG-X: Returning 1

[11:14:46]: iTunes Transporter output above ^
[11:14:46]: ERROR ITMS-90530: "Invalid MinimumOSVersion. Apps that only support 64-bit devices must specify a deployment target of 8.0 or later. MinimumOSVersion in '[My App].app/Frameworks/hermes.framework' is ''."
ERROR ITMS-90360: "Missing Info.plist value. A value for the key 'MinimumOSVersion' in bundle [My App].app/Frameworks/hermes.framework is required."
ERROR ITMS-90208: "Invalid Bundle. The bundle [My App].app/Frameworks/hermes.framework does not support the minimum OS Version specified in the Info.plist."
Return status of iTunes Transporter was 1: ERROR ITMS-90530: "Invalid MinimumOSVersion. Apps that only support 64-bit devices must specify a deployment target of 8.0 or later. MinimumOSVersion in '[My App].app/Frameworks/hermes.framework' is \nERROR ITMS-90208: "Invalid Bundle. The bundle [My App].app/Frameworks/hermes.framework does not support the minimum OS Version specified in the Info.plist."
The call to the iTMSTransporter completed with a non-zero exit status: 1. This indicates a failure.

Manually setting MinimumOSVersion in the hermes framework's Info.plist to 8.0 should only be considered a workaround, as Apple advises against using the MinimumOSVersion key (source)

I've created an issue for this at facebook/hermes#420

[Critical] Could not get BatchedBridge crash in Release

EDIT: That seems to be resolved since I made a fix for reanimated. See my PR here: software-mansion/react-native-reanimated#1469

So after I hotfixed the hermes framework Info.plist in my xcarchive / .app and re-tried to upload it to Testflight, I noticed that my app doesn't launch anymore in release builds. Looks like the run-loop in RCTCxxBridge.mm immediately crashes with the following error:

2020-11-24 14:37:49.823341+0100 MyApp[2993:859629] [native] Could not get BatchedBridge, make sure your bundle is packaged correctly
2020-11-24 14:37:49.823811+0100 MyApp[2993:859629] *** Terminating app due to uncaught exception 'RCTFatalException: Could not get BatchedBridge, make sure your bundle is packaged correctly', reason: 'Could not get BatchedBridge, make sure your bundle is packaged correctly'
*** First throw call stack:
(0x199aac878 0x1ae002c50 0x1033ff584 0x103416374 0x103414974 0x103429ec4 0x103429c64 0x199a2849c 0x199a276e4 0x199a21e18 0x199a2121c 0x103411f70 0x19ae3fa34 0x1e2ec2b40 0x1e2ecb768)
libc++abi.dylib: terminating with uncaught exception of type NSException
*** Terminating app due to uncaught exception 'RCTFatalException: Could not get BatchedBridge, make sure your bundle is packaged correctly', reason: 'Could not get BatchedBridge, make sure your bundle is packaged correctly'
terminating with uncaught exception of type NSException

btw; global.__jsiExecutorDescription is set to '<JSCRuntime@0x600000770460>' on iOS debug, shouldn't this also say Hermes?

Debug: Console

In debug builds, everything runs fine and stable on Hermes. I noticed that any console.log statements aren't being printed to the metro bundler console anymore 🤔 Is this disabled per design?

[mikehardy]

I've also ran pod cache clean --all, which should've removed 2/.

"should've" -> did you verify?

[gilbertl]

I've also ran pod cache clean --all, which should've removed 2/.

"should've" -> did you verify?

No, I didn't verify at the time.

However, I ran and checked just now and pod cache clean --all does remove the "~/Library/Cache/Cocoapods/pods" directory.

[pvinis]

i see _gitattributes from the template is removed on v64 since rc0 😬. it had *.pbxproj -text in it, which is useful for diffing xcodeproj files. We should not remove it. I can't find the commit that removed it, but I can make a new PR to add it back.

[elicwhite]

@pvinis, I found it for you. It was removed in facebook/react-native#29792 (I used some FB internal search tools to find it)

[pvinis]

Thanks for finding it!

Here we go: facebook/react-native#31128

I think this should be merged for the 0.64 release, so we don't end up with a release with weird line endings 😬.

[grabbou]

I took another pass at recent comments here.

To sum up, I think we have two additional cherry-picks before stable:

• Fix RefreshControl layout when removed from window facebook/react-native#31024 by @janicduplessis
• Fixing the git attrs for all the people and all the files and all future 🙌  facebook/react-native#31128 by @pvinis

Changelog is in progress - https://github.com/react-native-community/releases/pull/220/files
Release article is in progress

I will keep you updated as we complete the above.

[swrobel]

@grabbou one more cherry-pick: facebook/react-native#30978

[sunnylqm]

And maybe this one facebook/react-native#31134

[grabbou]

Everything cherry-picked. No more cherry-picks - everything else will have to wait for a patch release. We're wrapping it up now.

[pvinis]

Are we leaving the gitattr out? 🤔

[swrobel]

Are we leaving the gitattr out? 🤔

Apparently not: facebook/react-native@728d55a

[grabbou]

Closing as new release is under way. Let's continue in a follow up issue dedicated to 0.64.0 and upcoming 0.64.1.

[grabbou]

Closing as new release is under way. Let's continue in a follow up issue dedicated to 0.64.0 and upcoming 0.64.1.

[Bardiamist]

Any instruction for project.pbxproj update?
Is need only to remove tvOS targets or something else?

Update 1:
I checked all props visually in Xcode and not found any critical. Looks only CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER was enabled.

Screenshot 1

Update 2:
Also "EXCLUDED_ARCHS[sdk=iphonesimulator*]" = "arm64 "; was added.

Screenshot 2

[N1colasVega]

after "npx react-native init AwesomeProject" can't lunch app on ios.

through script:
PhaseScriptExecution [CP-User]\ Generate\ Specs /Users/user/Library/Developer/Xcode/DerivedData/AwesomeProject-btdlvrsshpcfmndosfollajacgcx/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/FBReactNativeSpec.build/Script-46EB2E00011F50.sh
(1 failure)

through xcode:
Showing Recent Messages
Library not found for -lFBReactNativeSpec

this is a clean project

mac m1

[kristijantomic]

@N1colasVega you could try this: react-native-community/upgrade-support#138