-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1/2 TextInput accessibilityErrorMessage (Talkback, Android) #33468
Closed
Closed
Changes from 153 commits
Commits
Show all changes
160 commits
Select commit
Hold shift + click to select a range
ad9dc3e
draft - testing functionality
fabOnReact 431a9d5
draft
fabOnReact a4ef7a7
Merge branch 'main' into text-input-errors
fabOnReact 60b6c9b
draft implementation of android_errorMessage
fabOnReact fb30702
applying same solution from PR 28952
fabOnReact f22e1f3
adding ErrorExample to TextInputSharedExamples
fabOnReact caab17c
Merge branch 'main' into text-input-errors
fabOnReact 06c4908
Android NDK: Module react_codegen_rncore depends on undefined modules…
fabOnReact d1b6182
Revert "Android NDK: Module react_codegen_rncore depends on undefined…
fabOnReact 3092ac8
testing solution from https://github.com/facebook/react-native/pull/2…
fabOnReact e521859
restore original example
fabOnReact f92f843
update example
fabOnReact d94f343
call setError in ReactTextInputManager
fabOnReact 6bd7240
Error onBlur example
fabOnReact 202292a
draft examples
fabOnReact 2820a95
handle errors from diffent type of callbacks
fabOnReact b8846c9
adding onEndEditing callback
fabOnReact bf75148
revert changes to ReactEditText onChangeText
fabOnReact 5e9b4c3
add errorMessage to ReactTextUpdate and maybeSetErrorMessage
fabOnReact 97c2dff
update method alphabetical order
fabOnReact 31bfa40
rename android_errorMessage to errorMessageAndroid
fabOnReact 394f794
remove ViewDefault for ERROR
fabOnReact 3a8347a
remove call to setError onAttachedToWindow
fabOnReact f39e5f1
Merge branch 'main' into text-input-errors
fabOnReact 60bc4e3
adding @platform android to errorMessageAndroid comments
fabOnReact 3c48da3
moving TextInput example at the bottom of the list
fabOnReact aca0d99
adding errorMessageAndroid to ParagraphAttributes (fabric AndroidText…
fabOnReact 37f0004
adding /ReactAndroid/hermes-engine/.cxx to .gitignore
fabOnReact 0708d07
Merge branch 'main' into text-input-errors
fabOnReact 9df9484
using std::optional<std::string>
fabOnReact 17852df
add comments in ParagraphAttributes
fabOnReact add6198
draft solution to trigger setError when changing state in Paper
fabOnReact 3d5100c
adding Nullable flag
fabOnReact 53fe1c0
Merge branch 'main' into text-input-errors
fabOnReact 6c0f432
use value_or instead of pointer *paragraphAttributes.errorMessageAndroid
fabOnReact 0ee77ed
adding @VisibleForTesting to PROP_ERROR_MESSAGE
fabOnReact 84edc00
Merge branch 'main' into text-input-errors
fabOnReact 299eba6
Avoid any error visual styling
fabOnReact 27dd208
use androidx Nullable instead of java
fabOnReact 2e660d2
rename errorMessageAndroid in android_accessibilityErrorMessage
fabOnReact e1c8f54
rename prop to android_accessibilityError
fabOnReact d4a390b
rename prop in ReactTextUpdate
fabOnReact f29a21c
rename prop in .xml files
fabOnReact 79c5e4f
adding buck res dependency
fabOnReact cc602e0
adding comment
fabOnReact 4ba33c3
Paper maybeSetErrorMessage calls errorMessage on every prop updates
fabOnReact 6f69758
renaming ReactTextUpdate getErrorMessage
fabOnReact 4df9d95
rename android_accessibilityError to screenreaderErrorAndroid
fabOnReact 99b4a24
rename android_accessibilityError to screenreaderErrorAndroid java files
fabOnReact 1365f50
rename android_accessibilityError to screenreaderErrorAndroid cpp files
fabOnReact 3a1ef4a
rename android_accessibilityError to screenreaderErrorAndroid .h files
fabOnReact 994089c
Merge branch 'main' into text-input-errors
fabOnReact eb33c93
fix annoucement delayed to next character
fabOnReact bb2df1f
trigger call only on TYPE_VIEW_TEXT_CHANGED
fabOnReact de50984
remove convertion to (View)
fabOnReact 7252c15
adding try catch statement and logging
fabOnReact 586af1f
adding return statement if error does not change
fabOnReact d1b6f67
remove nested if
fabOnReact 56087d3
only trigger requestSendAccEvent when error present
fabOnReact 3d831a9
remove check on accessibilityErrorMessage != null
fabOnReact 0513007
Merge branch 'main' into text-input-errors
fabOnReact 425056d
Merge branch 'main' into text-input-errors
fabOnReact ea9bb4c
Pods update
fabOnReact 7f7b281
implementing iOS functionalities for https://github.com/facebook/reac…
fabOnReact ef89ba2
rename screenreaderErrorAndroid to screenreaderError
fabOnReact af8a0bd
Revert "Pods update"
fabOnReact 29b99ba
update Error example
fabOnReact f70870e
Merge branch 'main' into text-input-errors
fabOnReact bb4597e
improving iOS solution announce screenreaderError
fabOnReact d96a284
fix circleci failures
fabOnReact 9a58e2e
move screenreaderError to AccessibilityProps
fabOnReact 9958dcd
removing diffing in viewPropConversions
fabOnReact ad56244
rename errorMessage in screenreaderError
fabOnReact bb7b0c3
remove screenreaderError from AccessibilityProps
fabOnReact 195fb0b
using the same default prop for screenreaderError
fabOnReact 343eea1
update iOS logic to trigger error message
fabOnReact 521c907
Merge branch 'main' into text-input-errors
fabOnReact efba00c
Merge branch 'main' into text-input-errors
fabOnReact dac4b96
Rename screenreaderError to accessibilityErrorMessage
fabOnReact 1d00ea8
Merge branch 'main' into text-input-errors
fabOnReact 6bac85e
draft solution Android accessibilityInvalid
fabOnReact 54aca18
draft - basic example with accInvalid
fabOnReact 8e06f08
adding accessibilityInvalid to iOS TextInput props
fabOnReact ee964b6
moving prop type from AndroidProps to Props
fabOnReact 0e5ad7c
fix flow circleci error
fabOnReact 8670b13
update TextInput-test.js snapshot
fabOnReact d801b87
rename variable screenreaderError to accessibilityErrorMessage
fabOnReact 53d8464
update Example
fabOnReact cabb212
rename remaing configs to accessibilityErrorMessage
fabOnReact 318a964
set accessibilityValue to text value if there is no error
fabOnReact f1a8b00
update Example based on new API updates
fabOnReact aefa74c
Merge branch 'main' into text-input-errors
fabOnReact 086dce7
adding more AccessibilityError examples
fabOnReact ddd7f53
handle different scenarios
fabOnReact 9f1e465
minor change
fabOnReact 1574fc4
Merge branch 'main' into text-input-errors
fabOnReact 3b5acf3
iOS - Exception thrown while executing UI block: - RCTUITextView setA…
fabOnReact f978045
draft solution - announcing accessibilityErrorMessage on iOS Paper
fabOnReact 037089f
include attributedText.string and avoid 2 announcements
fabOnReact 04f5e14
Paper iOS - update accessibilityValue onChangeText
fabOnReact f594d51
iOS Paper - set error outside of onChangeText
fabOnReact 582b1e8
fix the following scenarios iOS Paper
fabOnReact e4a95c6
Merge branch 'main' into text-input-errors
fabOnReact b53ed9d
iOS - apply Paper improvements to Fabric
fabOnReact 8cd7f42
update variable name in RCTUITextField
fabOnReact dce9b91
test/improve check on accessibilityValue != text
fabOnReact 90aa959
Implement solution for multiline textinput
fabOnReact 3c4296f
avoid initializing lastChar if errorMessageRemoved is false
fabOnReact 3f3312d
Rename var ErrorMessageString -> ScreenReaderError
fabOnReact 9858e54
The attributedText property is nil by default
fabOnReact 16d7d4d
rm update accessibilityValue in RCTBaseTextInputView
fabOnReact 99b39d5
Reintroduce fix - avoid repeat error announcement
fabOnReact 34c5526
update Accessibility Example
fabOnReact 933aa3c
rename _errorMessage to currentScreenreaderError
fabOnReact 30f3f96
implementing strict check in setAttributed string
fabOnReact de3c2f3
implement previousScreenreaderError check on Fabric
fabOnReact ce5e52a
using mutableCopy to set previousScreenreaderError value
fabOnReact b2a6964
rename currentScreenreaderError to currentAccError
fabOnReact 9a3117b
rename currentScreenreaderError to currentAccError in Fabric
fabOnReact 596df4d
fix duplicated VoiceOver announcements
fabOnReact f5a3bb6
update accessibilityValue onChangeText
fabOnReact 84786a2
update Accessibility Example
fabOnReact c8790a1
Merge branch 'main' into text-input-errors
fabOnReact f4acead
Merge branch 'main' into text-input-errors
fabOnReact 63fd956
minor changes
fabOnReact 5e5e2c0
Merge branch 'main' into text-input-errors
fabOnReact cb0c506
avoid reiterate prop documentation in the docblock
fabOnReact d85c90a
adding comments as suggested by Brett
fabOnReact 7d0c4db
Merge branch 'main' into text-input-errors
fabOnReact a92e7f6
adding accessibilityError message to buildReactTextUpdateFromState
fabOnReact 114b4e0
Merge branch 'main' into text-input-errors
fabOnReact 011178c
Merge branch 'main' into text-input-errors
fabOnReact 9c48846
Merge branch 'main' into text-input-errors
fabOnReact 9829e68
minor change
fabOnReact 869dd49
adding flow type for accessibilityErrorMessage
fabOnReact b43c547
typescript types
fabOnReact 043b24a
eslint Strings must use singlequote. (quotes)
fabOnReact 6c9e233
Merge branch 'main' into text-input-errors
fabOnReact 2818fa4
trigger onChangeText accessibilityErrorMessage with props instead of
fabOnReact c3ee8f9
this update is triggered with textInputRef.setTextAndSelection(newText,
fabOnReact 5d43830
fabric does not use ReactTextUpdate to announce errorMessage onChange…
fabOnReact 46e3d06
removing accessibilityErrorMessage from ParagraphAttributes state
fabOnReact af2c906
set accessibilityErrorMessage in case MapBuffer serialization is
fabOnReact b1b8bf0
adding @Nullable to accessibilityErrorMessage
fabOnReact f0d0186
change .cpp default value
fabOnReact b006276
Merge branch 'main' into text-input-errors
fabOnReact 9d1adec
replace readwrite with assign
fabOnReact e4094c9
remove pressed state
fabOnReact ca6d811
fix error: auto property synthesis will not synthesize property 'acce…
fabOnReact bd826f4
Merge branch 'main' into text-input-errors
fabOnReact 1f9c10e
Merge branch 'main' into text-input-errors
fabOnReact 61b049e
adding type null or String
fabOnReact 29a13b6
fix flow errors circleci
fabOnReact e19d492
Merge branch 'main' into text-input-errors
fabOnReact 085730f
move iOS functionalities to a new PR
fabOnReact f51645e
updating example
fabOnReact f138da4
Merge branch 'main' into text-input-errors
fabOnReact e3f2d68
moving RCTTextInputViewConfig to iOS PR
fabOnReact 954a58f
Merge branch 'main' into text-input-errors
fabOnReact 27b963b
Merge branch 'main' into text-input-errors
fabOnReact File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabriziobertoglio1987 I'm getting a build error because this differs from Libraries/Text/TextInput/Singleline/RCTUITextField.h
Re
Which property declaration should we use? cc @blavalla if you have thoughts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lunaleaps The RCTTextInputComponentView.mm is the iOS Fabric Component for TextInput. Creates an instance _backedTextInput of type BackedTextInputViewProtocol using RCTUITextView or RCTUITextField constructors.
react-native/React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputComponentView.mm
Line 78 in f0d0186
BackedTextInputViewProtocol, RCTUITextView and RCTUITextField headers should match (currently they don't, accessibilityErrorMessage type differs in RCTBackedTextInputViewProtocol).
Sorry for the mistake. I'm rebasing, building, testing and pushing the commit soon. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9d1adec
fix_wrong_type_error.mp4