Prepare AppDelegate to enable Concurrent Root on iOS #33671
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 20, 2022 06:37
Summary: This pr adds a parameter to the `create-artifacts.js` script to accept the path to a node executable, falling back to `node` in case the parameter has not been passed. Then, it passes the NODE_BINARY to the script in the `script_phases.sh` script. This PR decouples the `node` environment from the system one and fixes a build issue in the new architecture when the environment has no `node` Differential Revision: D35748497 fbshipit-source-id: 201daed0b31e4230f623631c634b5e2cd1c0aab6
Summary: With React 18, we now need to allow users on Fabric to opt-in for Concurrent Root. This commit adds a new method that can be customized in the AppDelegate to turn the feature on and off. The flag is passed as an initialProps to the rootView. ## Changelog: [iOS][Added] - Prepare a method in the AppDelegate to control the concurrentRoot. Differential Revision: D35757833 fbshipit-source-id: d80096367061a7e1c78067e0ec3355d8fad02a06
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D35757833 |
react-native-bot
added
Platform: iOS
Base commit: cf55fd5 |
Base commit: cf55fd5 |
|
This pull request was successfully merged by @cipolleschi in 8ac8439. When will my fix make it into a release? | Upcoming Releases |
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 15, 2023
Summary: Pull Request resolved: facebook#33671 With React 18, we now need to allow users on Fabric to opt-in for Concurrent Root. This commit adds a new method that can be customized in the AppDelegate to turn the feature on and off. The flag is passed as an initialProps to the rootView. ## Changelog: [iOS][Added] - Prepare a method in the AppDelegate to control the concurrentRoot. Reviewed By: cortinico, dmitryrykun Differential Revision: D35757833 fbshipit-source-id: 192cf74c796554cba39366aa90c53c191f960c20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
With React 18, we now need to allow users on Fabric to opt-in for Concurrent Root.
This commit adds a new method that can be customized in the AppDelegate to turn the feature on and off.
The flag is passed as an initialProps to the rootView.
Note:
This PR depends on this other
Changelog:
[iOS][Added] - Prepare a method in the AppDelegate to control the concurrentRoot.
Differential Revision: D35757833