Pass node executable to codegen #33672
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This pr adds a parameter to the `create-artifacts.js` script to accept the path to a node executable, falling back to `node` in case the parameter has not been passed. Then, it passes the NODE_BINARY to the script in the `script_phases.sh` script. This PR decouples the `node` environment from the system one and fixes a build issue in the new architecture when the environment has no `node` ## Changelog [iOS][Changed] - Update CodeGen scripts to accept custom node executable Differential Revision: D35748497 fbshipit-source-id: a93d6765f40975f6c7a0739be303470d885a3a58
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D35748497 |
This was referenced Apr 20, 2022
Base commit: cf55fd5 |
Base commit: cf55fd5 |
|
This pull request was successfully merged by @cipolleschi in 323db75. When will my fix make it into a release? | Upcoming Releases |
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 15, 2023
Summary: Pull Request resolved: facebook#33672 This pr adds a parameter to the `create-artifacts.js` script to accept the path to a node executable, falling back to `node` in case the parameter has not been passed. Then, it passes the NODE_BINARY to the script in the `script_phases.sh` script. This PR decouples the `node` environment from the system one and fixes a build issue in the new architecture when the environment has no `node` [iOS][Changed] - Update CodeGen scripts to accept custom node executable Reviewed By: cortinico, dmitryrykun Differential Revision: D35748497 fbshipit-source-id: 41b102de6427d6ef0ba1f8725f4b939d3b8c63db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This pr adds a parameter to the
create-artifacts.jsscript to accept the path to a node executable, falling back tonodein case the parameter has not been passed.Then, it passes the NODE_BINARY to the script in the
script_phases.shscript.This PR decouples the
nodeenvironment from the system one and fixes a build issue in the new architecture when the environment has nonodeChangelog
[iOS][Changed] - Update CodeGen scripts to accept custom node executable
Differential Revision: D35748497