Update template to gitignore android/app/.cxx
#34430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake gens running debug - `android/app/.cxx/Debug/*` - `android/app/.cxx/RelWithDebInfo/*` Neither/nothing during release. So probably want the 87 debug files untracked. Follow-up: facebook#34354
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
Platform: Android
facebook-github-bot
added
the
Shared with Meta
Merged
1 task
leotm
added a commit
to leotm/react-native-template-new-architecture
that referenced
this pull request
Aug 16, 2022
leotm
added a commit
to leotm/react-native-template-new-architecture
that referenced
this pull request
Aug 16, 2022
* Update dependency react-native to v0.70.0-rc.3 * `pod install` * `pod update hermes-engine --no-repo-update` Needed after ✔ Remove installed CocoaPods ✔ Remove CocoaPods spec cache * Delete android/app/src/main/jni/Android.mk * Create android/app/src/main/jni/CMakeLists.txt * Update android/app/build.gradle from ndk-build+Make to CMake * Fix CMakeLists.txt * Gitignore `android/app/.cxx` facebook/react-native#34430 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: LeoTM <1881059+leotm@users.noreply.github.com>
cortinico
reviewed
Aug 16, 2022
cortinico
reviewed
Aug 16, 2022
Co-authored-by: Nicola Corti <corti.nico@gmail.com>
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @leotm in 542d43d. When will my fix make it into a release? | Upcoming Releases |
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
Summary: CMake gens running debug - `android/app/.cxx/Debug/*` - `android/app/.cxx/RelWithDebInfo/*` Neither/nothing during release. So probably want the 87 debug files untracked. Follow-up: facebook#34354 _macOS 13b, RN 0.70.0-rc.3_ ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Android] [Added] - Update template to gitignore `android/app/.cxx` Pull Request resolved: facebook#34430 Test Plan: Everything builds and runs as expected Reviewed By: cipolleschi Differential Revision: D38752097 Pulled By: cortinico fbshipit-source-id: 61c31317d5e45f831445841f3e14da871b3903e5
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
Summary: CMake gens running debug - `android/app/.cxx/Debug/*` - `android/app/.cxx/RelWithDebInfo/*` Neither/nothing during release. So probably want the 87 debug files untracked. Follow-up: facebook#34354 _macOS 13b, RN 0.70.0-rc.3_ ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Android] [Added] - Update template to gitignore `android/app/.cxx` Pull Request resolved: facebook#34430 Test Plan: Everything builds and runs as expected Reviewed By: cipolleschi Differential Revision: D38752097 Pulled By: cortinico fbshipit-source-id: 61c31317d5e45f831445841f3e14da871b3903e5
kelset
pushed a commit
that referenced
this pull request
Aug 22, 2022
Summary: CMake gens running debug - `android/app/.cxx/Debug/*` - `android/app/.cxx/RelWithDebInfo/*` Neither/nothing during release. So probably want the 87 debug files untracked. Follow-up: #34354 _macOS 13b, RN 0.70.0-rc.3_ ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Android] [Added] - Update template to gitignore `android/app/.cxx` Pull Request resolved: #34430 Test Plan: Everything builds and runs as expected Reviewed By: cipolleschi Differential Revision: D38752097 Pulled By: cortinico fbshipit-source-id: 61c31317d5e45f831445841f3e14da871b3903e5
leotm
added a commit
to leotm/react-native-template-new-architecture
that referenced
this pull request
Aug 24, 2022
Code review feedback - facebook/react-native#34430
leotm
added a commit
to leotm/react-native-template-new-architecture
that referenced
this pull request
Aug 25, 2022
* Update dependency react-native to v0.70.0-rc.4 * Update gitignore .cxx Code review feedback - facebook/react-native#34430 * Update react-native pods to v0.70.0-rc.4 * Remove stale _editorconfig - looks like for Windows - not in `main` /template * Update pod hermes-engine to 0.70.0-rc.4 #825 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: LeoTM <1881059+leotm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CMake gens running debug
android/app/.cxx/Debug/*android/app/.cxx/RelWithDebInfo/*Neither/nothing during release.
So probably want the 87 debug files untracked.
Follow-up: #34354
macOS 13b, RN 0.70.0-rc.3
Changelog
[Android] [Added] - Update template to gitignore
android/app/.cxxTest Plan
Everything builds and runs as expected