Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: renamed react-native-codegen to @react-native/codegen #34804

Closed
wants to merge 5 commits into from
Closed

chore: renamed react-native-codegen to @react-native/codegen #34804

wants to merge 5 commits into from

Conversation

shivenmian
Copy link
Contributor

@shivenmian shivenmian commented Sep 27, 2022 •
edited
Loading

Summary

Renamed react-native-codegen package to @react-native/codegen and updated references, without changing the folder name; part of RFC480 (#34692). Follow-up from #34578

Changelog

[General] [Changed] - Renamed react-native-codegen package to @react-native/codegen and updated references

Test Plan

@shivenmian shivenmian requested a review from hramos as a code owner September 27, 2022 19:29
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner labels Sep 27, 2022
@shivenmian shivenmian mentioned this pull request Sep 27, 2022
Closed
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Sep 27, 2022
@kelset kelset added the Tech: Monorepo For PRs that are related to the monorepo infra label Sep 28, 2022
@facebook-github-bot
Copy link
Contributor

@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

cortinico
cortinico reviewed Sep 28, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@shivenmian
Copy link
Contributor Author

@cortinico done. I'm not seeing the test_js task btw - CircleCI isn't running. Is there something more I need to do for that?

cortinico
cortinico reviewed Oct 3, 2022
View reviewed changes
.circleci/verdaccio.yml Outdated
Comment on lines 29 to 31
'@react-native/codegen':
access: $all
publish: $all
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just remove this section entierly

@cortinico
Copy link
Contributor

something more I need to do for that?

Let's try to rebase. If it's still not working, I'll try to look more closely into this

@shivenmian shivenmian force-pushed the rn_refactor_codegen branch from 6fc49c0 to dc38a26 Compare October 4, 2022 00:34
@shivenmian
Copy link
Contributor Author

shivenmian commented Oct 4, 2022 •
edited
Loading

@cortinico done. I'm getting a "workflow awaiting approval" message - perhaps that's why CircleCI did not run?

@cortinico
Copy link
Contributor

/rebase

@github-actions github-actions bot force-pushed the rn_refactor_codegen branch from dc38a26 to 600d173 Compare October 4, 2022 10:39
@analysis-bot
Copy link

analysis-bot commented Oct 4, 2022 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,103,533 +0
android hermes armeabi-v7a 6,471,857 +0
android hermes x86 7,521,168 +0
android hermes x86_64 7,380,054 +0
android jsc arm64-v8a 8,968,359 +0
android jsc armeabi-v7a 7,699,467 +0
android jsc x86 9,030,658 +0
android jsc x86_64 9,508,690 +0

Base commit: ca1ae5c
Branch: main

@cortinico
Copy link
Contributor

Hey @shivenmian, I've rebased your PR as the CI was not running.
Now eslint is failing on CI. Are you able to take a look at it?

@analysis-bot
Copy link

analysis-bot commented Oct 4, 2022 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: ca1ae5c
Branch: main

@cortinico cortinico mentioned this pull request Oct 4, 2022
Closed
11 tasks
@shivenmian shivenmian force-pushed the rn_refactor_codegen branch 2 times, most recently from 11dc296 to 8c475f7 Compare October 5, 2022 07:57
@shivenmian
Copy link
Contributor Author

shivenmian commented Oct 5, 2022 •
edited
Loading

@cortinico fixed and rebased. Should pass now once you approve the workflow / run circleci

@cortinico
Copy link
Contributor

/rebase

@cortinico
Copy link
Contributor

CircleCI is failing to run on this PR, not sure why. I've attempted an autorebase, let's see if this unblocks the situation

@github-actions github-actions bot force-pushed the rn_refactor_codegen branch from 8c475f7 to 73bd2e6 Compare October 5, 2022 17:42
@shivenmian
Copy link
Contributor Author

@cortinico looks like the JS loop passed. It doesn't seem like the Android / Windows loop failures are related to this, and the iOS one seems like it can't find @react-native/codegen from npm - this should be fixed once the package change makes it way up to npm as well?

@shivenmian
Copy link
Contributor Author

@cortinico this good to go?

@cortinico
Copy link
Contributor

@cortinico this good to go?

Sorry I was off some days and missed this ping.
The PR seems good to go. I'm investigating if we can use Verdaccio also for the template tests similarly to what we did here #34577

Is this something you would be interested in looking into setting up for the whole React Native repo (as this would unblock a lot of other PRs like this one).

@shivenmian
Copy link
Contributor Author

Sure. Quick question:

I'm investigating if we can use Verdaccio also for the template tests similarly to what we did here #34577

By "template tests", do you mean the tests that are failing right now on this PR (i.e test_android_template_... and test_ios_template_...)?

@hoxyq
Copy link
Contributor

hoxyq commented Nov 24, 2022

Hey @shivenmian, thanks for contributing. To make this work (both internally and in open-source) I need to add some changes. Could you please share if this is okay for you?

@hoxyq hoxyq force-pushed the rn_refactor_codegen branch from 73bd2e6 to c6b4f69 Compare November 25, 2022 16:18
@pull-bot
Copy link

PR build artifact for c6b4f69 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link

PR build artifact for c6b4f69 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@hoxyq hoxyq force-pushed the rn_refactor_codegen branch from c6b4f69 to b9a36df Compare November 25, 2022 18:33
@pull-bot
Copy link

PR build artifact for b9a36df is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link

PR build artifact for b9a36df is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@shivenmian
Copy link
Contributor Author

@hoxyq yep go ahead!

@hoxyq hoxyq force-pushed the rn_refactor_codegen branch from b9a36df to d284078 Compare November 25, 2022 21:20
@pull-bot
Copy link

PR build artifact for d284078 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link

PR build artifact for d284078 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@hoxyq hoxyq force-pushed the rn_refactor_codegen branch from d284078 to 720b05d Compare November 26, 2022 09:58
@pull-bot
Copy link

PR build artifact for 720b05d is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link

PR build artifact for 720b05d is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@hoxyq hoxyq force-pushed the rn_refactor_codegen branch from cd284fe to bd2a4ae Compare November 26, 2022 10:49
@hoxyq hoxyq force-pushed the rn_refactor_codegen branch from bd2a4ae to 512523e Compare November 26, 2022 10:49
@facebook-github-bot
Copy link
Contributor

@hoxyq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@pull-bot
Copy link

PR build artifact for 512523e is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link

PR build artifact for 512523e is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @shivenmian in b7a85b5.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 28, 2022
@hoxyq hoxyq mentioned this pull request Jan 2, 2023
Closed
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
@shivenmian @OlimpiaZurek
chore: renamed react-native-codegen to @react-native/codegen (faceboo…
f7040fc 
…k#34804)

Summary:
Renamed react-native-codegen package to react-native/codegen and updated references, without changing the folder name; part of RFC480 (facebook#34692). Follow-up from facebook#34578

## Changelog

[General] [Changed] - Renamed react-native-codegen package to react-native/codegen and updated references

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

Pull Request resolved: facebook#34804

Reviewed By: cortinico

Differential Revision: D39883584

Pulled By: hoxyq

fbshipit-source-id: 0ef384b75c6edd248b31e37b8f05f64b4d39ca6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico left review comments

@hramos hramos Awaiting requested review from hramos

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Microsoft Partner: Microsoft Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. Tech: Monorepo For PRs that are related to the monorepo infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@shivenmian @facebook-github-bot @cortinico @analysis-bot @hoxyq @pull-bot @react-native-bot @kelset