-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[General] [Fixed] - Fixes react-native-codegen location within script_phases.sh #35763
Conversation
Hey @peterpme, thanks for the contribution! I see that this line was changed in #34804, after we renamed package We probably changed these lines by a mistake. I don't have much of a context on how its used here, but does this revert fixes your problem, could you please validate that? |
Base commit: 4ac4a5c |
PR build artifact for d9555e5 is ready. |
This breaks the CI tests, please check e.g. here:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI builds are broken (see my comment above), looks it's because of this change.
if ! [ -d "$CODEGEN_CLI_PATH" ]; then | ||
error "error: Could not determine @react-native/codegen location, using node module resolution. Try running 'yarn install' or 'npm install' in your project root." | ||
error "error: Could not determine react-native-codegen location, using node module resolution. Try running 'yarn install' or 'npm install' in your project root." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could make sense to make the react-native-codegen
location a constant.
Summary
@byCedric did some amazing work to update the codegen location monorepo support. There was just 1 small issue which is in the name of the package: instead of
@react-native/codegen
it should bereact-native-codegen
Changelog
[General] [Fixed] - Fixes react-native-codegen location within script_phases.sh from
@react-native/codegen
toreact-native-codegen
Test Plan
Run
eas build --platform ios
within a monorepo like Backpack