Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2/2 TextInput accessibilityErrorMessage (VoiceOver, iOS) #35908

Closed
wants to merge 13 commits into from
Closed

2/2 TextInput accessibilityErrorMessage (VoiceOver, iOS) #35908

wants to merge 13 commits into from

Commits on Jan 20, 2023

  1. adding iOS functionalities from facebook#33468 

    for original commit history before applying squash see https://github.com/facebook/react-native/pull/33468/commits
    @fabOnReact
    fabOnReact committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    2d0d4d4 View commit details
    Browse the repository at this point in the history

  2. removing current/previousAccessibilityError

    @fabOnReact
    fabOnReact committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    6578340 View commit details
    Browse the repository at this point in the history

  3. remove accessibilityErrorMessage from .h files

    @fabOnReact
    fabOnReact committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    54cd9a2 View commit details
    Browse the repository at this point in the history

  4. add _skipNextAccessibilityAnnouncement to avoid repeat announcement

    @fabOnReact
    fabOnReact committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    8747594 View commit details
    Browse the repository at this point in the history

  5. moving logic to _setAccessibilityValueWithError

    @fabOnReact
    fabOnReact committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    8d72948 View commit details
    Browse the repository at this point in the history

  6. rename method to announceForAccessibility

    @fabOnReact
    fabOnReact committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    1f189ab View commit details
    Browse the repository at this point in the history

  7. minor change

    @fabOnReact
    fabOnReact committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    1a156ef View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2023

  1. The default std::string constructor creates empty string 

    https://cplusplus.com/reference/string/string/string/
https://stackoverflow.com/a/65534356/7295772
    @fabOnReact
    fabOnReact committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    83a9832 View commit details
    Browse the repository at this point in the history

  2. use _backedTextInputView instead of self.accessElement

    @fabOnReact
    fabOnReact committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    5f3dee2 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. remove example

    @fabOnReact
    fabOnReact committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    576a7df View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into text-input-errors-improvements

    @fabOnReact
    fabOnReact committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    42a97a3 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. Merge branch 'main' into text-input-errors-improvements

    @fabOnReact
    fabOnReact committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    1b7a022 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2023

  1. Merge branch 'main' into text-input-errors-improvements

    @fabOnReact
    fabOnReact committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    9baf641 View commit details
    Browse the repository at this point in the history