Log a soft exception from accessibility event exceptions

[Abbondanzo]

Summary:

This PR attempts to solve this issue I created last year, where accessibility events can fire after a view has been unmounted, causing the entire application to crash. This newly added try/catch block is modeled and copies verbiage exactly from the Fabric implementation of accessibility events here and here.

Changelog:

[ANDROID] [FIXED] - Fixed an issue where calling Accessibility.setAccessibilityFocus on an unmounted component would crash

Test Plan:

1. I reimplemented the crash demo from the Snack showcased in this issue. I created the branch here, although I may archive or delete this repo in the future so the link is not permanent
2. I disabled the new Fabric architecture. This crash only occurs in the old architecture
3. I pressed the button that would set accessibility focus on an unmounted component, and it logs a soft exception as seen in the screenshot below. I've also attached a screenshot from an identical soft exception that already gets logged by Fabric
4. In both cases, the app continues to function as expected

Example SoftException from this change	Example SoftException from Fabric (no changes to this code)

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,333,699	-303
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	9,573,226	-23
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 1ac3dab
Branch: main

[Abbondanzo]

Wanted to bump this one for review since it's still causing issues for a number of our users

[consuelo-sanna]

Hi @cortinico, @Titozzz,
I tag you here because we were discussing this topic, I hope you don't mind

As explained in the summary by Abbondanzo this PR would solve/improve the issue on Android that crashes if does not find the tag. you also mentioned that findNodeHandle is deprecated/is going to be deprecated - based on that, do you think this PR can be merged in?

I have not found much documentation about deprecating findNodeHandle, would you also be so kind to point me in the right direction for that?
Thank you

[cortinico]

Hey @consuelo-sanna
You mentioned there was a previous discussion around this topic which came to your attention. Could you share it here for future reference?

[consuelo-sanna]

sure @cortinico, it was this one issue 22807

Then I've also seen that recently this one was also opened up on the same matter issue 37015

[cortinico]

When we met in person, you mentioned that someone shared that this is the "intended behavior". Could you link that conversation?

[consuelo-sanna]

yes, I was referring to this comment by titozzz

I definitely see titozzz's point of view, but being a feature used for accessibilities reasons I think it would make more sense to handle it more gracefully than crashing, which would also align with what happens on iOS

[facebook-github-bot]

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[Abbondanzo]

Syncing my fork reopened this PR, was going to start work on something else from main (converting some of those tests to Kotlin). Want me to close this PR since it's been imported on your end?

[github-actions]

	Warnings
⚠️	One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against 8cb582f

[facebook-github-bot]

@cortinico merged this pull request in 5323221.

[zfrankdesign]

Has this been released yet? I can't find the RN version needed for this fix. Any help appreciated.

[Abbondanzo]

Has this been released yet? I can't find the RN version needed for this fix. Any help appreciated.

5323221
According to the commit it was included in, it should be in 0.73.0 and up