Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow custom assignment of rootView to rootViewController #37873

Closed
wants to merge 4 commits into from
Closed

feat: allow custom assignment of rootView to rootViewController #37873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f2b4db
feat: allow custom assignment of rootView to rootViewController
Gregoirevda Jun 14, 2023
45f66b6
Update packages/react-native/Libraries/AppDelegate/RCTAppDelegate.h
Gregoirevda Jun 14, 2023
674c4e1
fix: review
Gregoirevda Jun 14, 2023
2c681ef
fix: resolve conflicts
Gregoirevda Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/react-native/Libraries/AppDelegate/RCTAppDelegate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
* - (UIView *)createRootViewWithBridge:(RCTBridge *)bridge moduleName:(NSString*)moduleName initProps:(NSDictionary
*)initProps;
* - (UIViewController *)createRootViewController;
* - (void)setRootView:(UIView *)rootView toRootViewController:(UIViewController *)rootViewController;
* New Architecture:
* - (BOOL)concurrentRootEnabled
* - (BOOL)turboModuleEnabled;
Expand Down Expand Up @@ -94,6 +95,16 @@
*/
- (UIViewController *)createRootViewController;

/**
* It assigns the rootView to the rootViewController
* By default, it assigns the rootView to the view property of the rootViewController
* If you are not using a simple UIViewController, then there could be other methods to use to setup the rootView.
* For example: UISplitViewController requires `setViewController(_:for:)`
*
Gregoirevda marked this conversation as resolved.
Show resolved Hide resolved
* @return: void
*/
- (void)setRootView:(UIView *)rootView toRootViewController:(UIViewController *)rootViewController;

/// This method controls whether the App will use RuntimeScheduler. Only applicable in the legacy architecture.
///
/// @return: `YES` to use RuntimeScheduler, `NO` to use JavaScript scheduler. The default value is `YES`.
Expand Down
7 changes: 6 additions & 1 deletion packages/react-native/Libraries/AppDelegate/RCTAppDelegate.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(

self.window = [[UIWindow alloc] initWithFrame:[UIScreen mainScreen].bounds];
UIViewController *rootViewController = [self createRootViewController];
rootViewController.view = rootView;
[self setRootView:rootView toRootViewController:rootViewController];
self.window.rootViewController = rootViewController;
[self.window makeKeyAndVisible];

Expand Down Expand Up @@ -129,6 +129,11 @@ - (UIViewController *)createRootViewController
return [UIViewController new];
}

- (void)setRootView:(UIView *)rootView toRootViewController:(UIViewController *)rootViewController {
rootViewController.view = rootView;
}


- (BOOL)runtimeSchedulerEnabled
{
return YES;
Expand Down