feat: allow custom assignment of rootView to rootViewController #37873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Base commit: b0485be |
cipolleschi
requested changes
Jun 14, 2023
There was a problem hiding this comment.
Hi @Gregoirevda! Thank you so much for this PR. I'm super excited that you took some time to add this new feature to RCTAppDelegate. 😄
I left a few comments to align it more to standard iOS conventions, but overall the approach looks good to me!
Co-authored-by: Riccardo Cipolleschi <riccardo.cipolleschi@gmail.com>
|
Hi @cipolleschi |
cipolleschi
approved these changes
Jun 15, 2023
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @Gregoirevda in abc6e1c. When will my fix make it into a release? | Upcoming Releases |
|
@cipolleschi merged this pull request in abc6e1c. |
Closed
adamaveray
added a commit
to adamaveray/react-native
that referenced
this pull request
Jun 16, 2023
* main: (135 commits) translation auto-update for i18n/twilight.config.json on master Interop: Introduce Bridge proxy Remove okhttp internal util usage (facebook#37843) Update debian to fix CI while updating Node (facebook#37841) fix: foreground ripple crash on api < 23 (facebook#37901) Re-add the top level LICENSE file (facebook#37916) Deploy 0.209.0 to xplat (facebook#37921) Re-enable direct debugging with JSC on iOS 16.4+ (facebook#37914) add emitObjectProp in parser primitives (facebook#37904) Make React-utils its own pod (facebook#37659) feat: allow custom assignment of rootView to rootViewController (facebook#37873) Switch xplat prettier config to hermes plugin (facebook#37915) Set iOS AppState to inactive when app is launching (facebook#37690) Use `fileExists` in replace_hermes script (facebook#37911) (docs): fix license url (facebook#37909) Revert D46719890: Re-enable direct debugging with JSC on iOS 16.4+ Re-enable direct debugging with JSC on iOS 16.4+ (facebook#37874) Fix component type references in xplat (facebook#37903) Remove usage of passthroughAnimatedPropExplicitValues in ScrollViewStickyHeader (facebook#37867) test runtime lifecycle callback (facebook#37897) ...
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
To use a native Drawer on iPad, I can override
createRootViewControllerto create aUISplitViewControllerinstead of aUIViewController, but I then need to assign the rootView withwhich I can currently only do by copy pasting the entire
didFinishLaunchingWithOptionsand only replacing the assignmentIn an attempt of making it easier for developers to use a native drawer in iOS, being able to override the assignment would make it easier.
Changelog:
[iOS] [ADDED] - added override method with default implementation
Test Plan
Tested on iPad iOS 16 simulator