Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add the top level LICENSE file #37916

Closed
wants to merge 1 commit into from

Conversation

cortinico
Copy link
Contributor

Summary:
Repos on GitHub should have a top level LICENSE file to make sure GitHub can autodiscover
the correct license for the project.

Once we moved the file inside packages/react-native/ the autodiscovery is not working anymore (it returns a 404).

Changelog:
[Internal] - Re-add the top level LICENSE file

Reviewed By: hoxyq

Differential Revision: D46764347

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Jun 15, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46764347

Summary:
Pull Request resolved: facebook#37916

Repos on GitHub should have a top level LICENSE file to make sure GitHub can autodiscover
the correct license for the project.

Once we moved the file inside packages/react-native/ the autodiscovery is not working anymore (it returns a 404).

Changelog:
[Internal] - Re-add the top level LICENSE file

Reviewed By: hoxyq

Differential Revision: D46764347

fbshipit-source-id: 2deb9b67c1d8d4aa006d01f5f935fa55469293a2
@analysis-bot
Copy link

analysis-bot commented Jun 15, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,757,680 -4
android hermes armeabi-v7a 8,070,255 -5
android hermes x86 9,250,277 -4
android hermes x86_64 9,099,414 -3
android jsc arm64-v8a 9,318,824 -5
android jsc armeabi-v7a 8,508,735 -4
android jsc x86 9,382,317 -2
android jsc x86_64 9,635,562 -5

Base commit: abc6e1c
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46764347

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 15, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 2ae163a.

adamaveray added a commit to adamaveray/react-native that referenced this pull request Jun 16, 2023
* main: (135 commits)
  translation auto-update for i18n/twilight.config.json on master
  Interop: Introduce Bridge proxy
  Remove okhttp internal util usage (facebook#37843)
  Update debian to fix CI while updating Node (facebook#37841)
  fix: foreground ripple crash on api < 23 (facebook#37901)
  Re-add the top level LICENSE file (facebook#37916)
  Deploy 0.209.0 to xplat (facebook#37921)
  Re-enable direct debugging with JSC on iOS 16.4+ (facebook#37914)
  add emitObjectProp in parser primitives (facebook#37904)
  Make React-utils its own pod (facebook#37659)
  feat: allow custom assignment of rootView to rootViewController (facebook#37873)
  Switch xplat prettier config to hermes plugin (facebook#37915)
  Set iOS AppState to inactive when app is launching (facebook#37690)
  Use `fileExists` in replace_hermes script (facebook#37911)
  (docs): fix license url (facebook#37909)
  Revert D46719890: Re-enable direct debugging with JSC on iOS 16.4+
  Re-enable direct debugging with JSC on iOS 16.4+ (facebook#37874)
  Fix component type references in xplat (facebook#37903)
  Remove usage of passthroughAnimatedPropExplicitValues in ScrollViewStickyHeader (facebook#37867)
  test runtime lifecycle callback (facebook#37897)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants