-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore base config merge in metro-config #38092
Conversation
This pull request was exported from Phabricator. Differential Revision: D47055973 |
@kelset @cipolleschi @hoxyq Do you know if package version bumps are performed as part of the release process? Or should I increment the version here (to be subsequently bumped in the template)? |
Base commit: c803a5b |
yes they are done as part of the release process, please don't bump here. |
separate question: how does this change affect existing users on 0.72? will everything keep working as expected, or would they need to change anything? 'cause that will affect if we can cherry-pick in 0.72. |
@kelset Ah yeah of course, ty 👍🏻 |
This is non-breaking as I see it, so should be fine to pick - we'll just be exporting a complete config object rather than a loose, partial one. |
Summary: Pull Request resolved: facebook#38092 Reverts facebook#36777. This is motivated by reducing user friction when the widespread assumption is for `react-native/metro-config` to export a complete Metro config, as with Expo/rnx-kit, and like previously understood uses of `metro-config`. See facebook/metro#1010 (comment) for further notes. Fixes: - facebook/metro#1010 - facebook#38069 - kristerkari/react-native-svg-transformer#276 Note that we do not intend for `react-native/metro-config` to directly export `assetExts` etc — these can be accessed on the `resolver` property from the full config object. Changelog: [General][Changed] `react-native/metro-config` now includes all base config values from `metro-config` Reviewed By: robhogan Differential Revision: D47055973 fbshipit-source-id: eedc4698e651645ada46a013d3945a16965bff22
This pull request was exported from Phabricator. Differential Revision: D47055973 |
This pull request was successfully merged by @huntie in bbcedd3. When will my fix make it into a release? | Upcoming Releases |
Summary: Pull Request resolved: #38092 Reverts #36777. This is motivated by reducing user friction when the widespread assumption is for `react-native/metro-config` to export a complete Metro config, as with Expo/rnx-kit, and like previously understood uses of `metro-config`. See facebook/metro#1010 (comment) for further notes. Fixes: - facebook/metro#1010 - #38069 - kristerkari/react-native-svg-transformer#276 Note that we do not intend for `react-native/metro-config` to directly export `assetExts` etc — these can be accessed on the `resolver` property from the full config object. Changelog: [General][Changed] `react-native/metro-config` now includes all base config values from `metro-config` Reviewed By: robhogan Differential Revision: D47055973 fbshipit-source-id: 5ad23cc9700397110de5c0e81c7d76299761ef0a
Summary
Reverts #36777.
This is motivated by reducing user friction when the widespread assumption is for
@react-native/metro-config
to export a complete Metro config, as with Expo/rnx-kit, and like previously understood uses ofmetro-config
. See facebook/metro#1010 (comment) for further notes.Fixes:
@react-native/metro-config
doesn't export defaultassetExts
andsourceExts
anymore. #38069Note that we do not intend for
@react-native/metro-config
to directly exportassetExts
etc — these can be accessed on theresolver
property from the full config object.Changelog: [General][Changed]
@react-native/metro-config
now includes all base config values frommetro-config
Test Plan
Steps
yarn link
to substitute@react-native/metro-config
with local version.yarn link
to substitute@react-native-community/cli-plugin-metro
with local fork.watchFolders
in Metro config.yarn start
✅ Produces functionally identical final config
(Diff before and after changes)
✅ App builds
Differential Revision: D47055973