Fabric Interop - Also normalize direct events #38352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47472050 |
Base commit: 8ab9a77 |
Summary: Pull Request resolved: facebook#38352 This change is making sure we normalize both bubbling and direct events for the sake of Fabric Interop. This is currently required as some libraries have reported incompatiblities with Fabric Interop (see react-native-maps/react-native-maps#4383) Also this is has been reported by the WG here: reactwg/react-native-new-architecture#135 (comment) Changelog: [Android] [Fixed] - Fabric Interop - Fix support for direct events on Paper components Reviewed By: rshest Differential Revision: D47472050 fbshipit-source-id: d4f2d5cf99013f9934858be023bc612e1c74193f
|
This pull request was exported from Phabricator. Differential Revision: D47472050 |
cortinico
force-pushed
the
export-D47472050
branch
from
e315129 to
8580e20
Compare
|
This pull request was successfully merged by @cortinico in 995bb3e. When will my fix make it into a release? | Upcoming Releases |
juniorklawa
pushed a commit
to juniorklawa/react-native
that referenced
this pull request
Jul 20, 2023
Summary: Pull Request resolved: facebook#38352 This change is making sure we normalize both bubbling and direct events for the sake of Fabric Interop. This is currently required as some libraries have reported incompatiblities with Fabric Interop (see react-native-maps/react-native-maps#4383) Also this is has been reported by the WG here: reactwg/react-native-new-architecture#135 (comment) Changelog: [Android] [Fixed] - Fabric Interop - Fix support for direct events on Paper components Reviewed By: rshest Differential Revision: D47472050 fbshipit-source-id: f0ae95cb782e340281928819a702273fb14e9b16
lunaleaps
pushed a commit
that referenced
this pull request
Aug 7, 2023
Summary: Pull Request resolved: #38352 This change is making sure we normalize both bubbling and direct events for the sake of Fabric Interop. This is currently required as some libraries have reported incompatiblities with Fabric Interop (see react-native-maps/react-native-maps#4383) Also this is has been reported by the WG here: reactwg/react-native-new-architecture#135 (comment) Changelog: [Android] [Fixed] - Fabric Interop - Fix support for direct events on Paper components Reviewed By: rshest Differential Revision: D47472050 fbshipit-source-id: f0ae95cb782e340281928819a702273fb14e9b16
This was referenced Aug 10, 2023
Kudo
pushed a commit
to expo/react-native
that referenced
this pull request
Aug 21, 2023
Summary: Pull Request resolved: facebook#38352 This change is making sure we normalize both bubbling and direct events for the sake of Fabric Interop. This is currently required as some libraries have reported incompatiblities with Fabric Interop (see react-native-maps/react-native-maps#4383) Also this is has been reported by the WG here: reactwg/react-native-new-architecture#135 (comment) Changelog: [Android] [Fixed] - Fabric Interop - Fix support for direct events on Paper components Reviewed By: rshest Differential Revision: D47472050 fbshipit-source-id: f0ae95cb782e340281928819a702273fb14e9b16
This was referenced Jan 4, 2024
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change is making sure we normalize both bubbling and direct events for the sake of Fabric Interop.
This is currently required as some libraries have reported incompatiblities with Fabric Interop
(see react-native-maps/react-native-maps#4383)
Also this is has been reported by the WG here:
reactwg/react-native-new-architecture#135 (comment)
Changelog:
[Android] [Fixed] - Fabric Interop - Fix support for direct events on Paper components
Differential Revision: D47472050