Allow out-of-tree platforms to extend Touch fields #38681
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47896016 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D47896016 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 29, 2023
Summary: Pull Request resolved: facebook#38681 Desktop platforms send additional information with onTouch(Start|Move|End|Cancel) events, including modifier keys and mouse button information. This information has not historically been available for mobile platforms, so rather than blindly adding the fields, this change adds a hook for out-of-tree platforms to extend the data in nativeEvent payload for Fabric Touch events. ## Changelog: [General] [Added] - Support customization of underlying Touch event representation in out-of-tree platforms Differential Revision: D47896016 fbshipit-source-id: d282b739817f9477d0997a6865bea692e1713687
Base commit: 8bcfc49 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 31, 2023
Summary: Pull Request resolved: facebook#38681 Desktop platforms send additional information with onTouch(Start|Move|End|Cancel) events, including modifier keys and mouse button information. This information has not historically been available for mobile platforms, so rather than blindly adding the fields, this change adds a hook for out-of-tree platforms to extend the data in nativeEvent payload for Fabric Touch events. ## Changelog: [General] [Added] - Support customization of underlying Touch event representation in out-of-tree platforms Differential Revision: https://internalfb.com/D47896016 fbshipit-source-id: 536c3447715b987f95d377140977c0e4fa81b32c
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 31, 2023
Summary: Pull Request resolved: facebook#38681 Desktop platforms send additional information with onTouch(Start|Move|End|Cancel) events, including modifier keys and mouse button information. This information has not historically been available for mobile platforms, so rather than blindly adding the fields, this change adds a hook for out-of-tree platforms to extend the data in nativeEvent payload for Fabric Touch events. ## Changelog: [General] [Added] - Support customization of underlying Touch event representation in out-of-tree platforms Reviewed By: christophpurrer Differential Revision: D47896016 fbshipit-source-id: 1e40f1f633387d368c5f642290b192174d53551a
|
This pull request was exported from Phabricator. Differential Revision: D47896016 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 31, 2023
Summary: Pull Request resolved: facebook#38681 Desktop platforms send additional information with onTouch(Start|Move|End|Cancel) events, including modifier keys and mouse button information. This information has not historically been available for mobile platforms, so rather than blindly adding the fields, this change adds a hook for out-of-tree platforms to extend the data in nativeEvent payload for Fabric Touch events. ## Changelog: [General] [Added] - Support customization of underlying Touch event representation in out-of-tree platforms Differential Revision: https://internalfb.com/D47896016 fbshipit-source-id: 8dff33a5c3dfb7fada432853ac00462cdbd29e5a
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 31, 2023
Summary: Pull Request resolved: facebook#38681 Desktop platforms send additional information with onTouch(Start|Move|End|Cancel) events, including modifier keys and mouse button information. This information has not historically been available for mobile platforms, so rather than blindly adding the fields, this change adds a hook for out-of-tree platforms to extend the data in nativeEvent payload for Fabric Touch events. ## Changelog: [General] [Added] - Support customization of underlying Touch event representation in out-of-tree platforms Differential Revision: https://internalfb.com/D47896016 fbshipit-source-id: 3cb0dcbbe033a7ebbe8e7598e4398de2f57f1e04
|
This pull request was exported from Phabricator. Differential Revision: D47896016 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 31, 2023
Summary: Pull Request resolved: facebook#38681 Desktop platforms send additional information with onTouch(Start|Move|End|Cancel) events, including modifier keys and mouse button information. This information has not historically been available for mobile platforms, so rather than blindly adding the fields, this change adds a hook for out-of-tree platforms to extend the data in nativeEvent payload for Fabric Touch events. ## Changelog: [General] [Added] - Support customization of underlying Touch event representation in out-of-tree platforms Reviewed By: christophpurrer Differential Revision: D47896016 fbshipit-source-id: 60c70c9f758ba332b230672a41dbe3731c6086d4
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 31, 2023
Summary: Pull Request resolved: facebook#38681 Desktop platforms send additional information with onTouch(Start|Move|End|Cancel) events, including modifier keys and mouse button information. This information has not historically been available for mobile platforms, so rather than blindly adding the fields, this change adds a hook for out-of-tree platforms to extend the data in nativeEvent payload for Fabric Touch events. ## Changelog: [General] [Added] - Support customization of underlying Touch event representation in out-of-tree platforms Differential Revision: https://internalfb.com/D47896016 fbshipit-source-id: 5d7248d683c68420438b2a7584cd688559ec6f6a
Summary: Pull Request resolved: facebook#38549 Out of tree platforms may need different implementations of ViewProps. In fact, Android does already with props like `needsOffscreenAlphaCompositing` and `focusable`. This diff is not opinionated on whether these props should actually be shared on all platforms. Props like `focusable` may be a good candidate for generalizing to all platforms. However, there will always be a need for one platform to experiment with a new prop while it's not available yet on another, especially when considering out of tree platforms. This diff moves the existing ViewProps class to BaseViewProps, aliases ViewProps as BaseViewProps for iOS for now, and moves Android-specific view props to it's own header and implementation. ## Changelog: [General] [Added] - Support additional View props in out of tree platform Fabric implementations Differential Revision: https://internalfb.com/D47492635 fbshipit-source-id: 3ac7f51c367457388d3e6375a20617e0fde1f998
…ebook#38580) Summary: Pull Request resolved: facebook#38580 We already have a differential between Android and iOS View props that force view flattening (or unflattening) behaviors. Other out-of-tree platforms may have a need to customize view flattening behaviors. This change adds a ViewTraitsInitializer header that out of tree platforms can inject to include platform-specific ViewProps fields when considering view flattening behaviors. ## Changelog: [General] [Added] - Support customization of View traits for flattening in out of tree platform Fabric implementations Differential Revision: https://internalfb.com/D47721377 fbshipit-source-id: 5806c9629daa2ec361dc51cf694cdabea43d7bb9
…facebook#38582) Summary: Pull Request resolved: facebook#38582 Some out of tree platforms may have extra events (e.g., events for different input modalities) that don't exist on other platforms. For example, react-native-windows and react-native-macos have `onKeyUp` and `onKeyDown` that can be emitted from any native component. This change provides a hook for out of platforms to customize which events can be emitted from all native components. ## Changelog: [General] [Added] - Support additional View events in out of tree platform Fabric implementations Differential Revision: https://internalfb.com/D47721603 fbshipit-source-id: 32b54722ea3c9d6ac13a8341d9bbbd1e2e24c462
Summary: Pull Request resolved: facebook#38668 On other platforms (e.g., react-native-windows), it's possible that platform colors may not be efficiently represented as int32_t values. In the case of react-native-windows, Color can either be an ARGB value or a list of fallback strings for platform colors. This change should decouple how platforms represent color values, allowing them to manage how they are used at the point they are used. ## Changelog: [General] [Added] - Support customization of underlying Color representation in out-of-tree platforms Differential Revision: https://internalfb.com/D47873465 fbshipit-source-id: 817e43df1042db5fcf84e9f30965972b7f250d8a
Summary: Pull Request resolved: facebook#38681 Desktop platforms send additional information with onTouch(Start|Move|End|Cancel) events, including modifier keys and mouse button information. This information has not historically been available for mobile platforms, so rather than blindly adding the fields, this change adds a hook for out-of-tree platforms to extend the data in nativeEvent payload for Fabric Touch events. ## Changelog: [General] [Added] - Support customization of underlying Touch event representation in out-of-tree platforms Reviewed By: christophpurrer Differential Revision: D47896016 fbshipit-source-id: 86ed93f90160392dc45865b4224b4179b31a3618
|
This pull request was exported from Phabricator. Differential Revision: D47896016 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 31, 2023
Summary: Pull Request resolved: facebook#38681 Desktop platforms send additional information with onTouch(Start|Move|End|Cancel) events, including modifier keys and mouse button information. This information has not historically been available for mobile platforms, so rather than blindly adding the fields, this change adds a hook for out-of-tree platforms to extend the data in nativeEvent payload for Fabric Touch events. ## Changelog: [General] [Added] - Support customization of underlying Touch event representation in out-of-tree platforms Differential Revision: https://internalfb.com/D47896016 fbshipit-source-id: 263f49548927b37307f822950ac01591ef96418a
|
This pull request has been merged in 4884322. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Desktop platforms send additional information with onTouch(Start|Move|End|Cancel) events, including modifier keys and mouse button information.
This information has not historically been available for mobile platforms, so rather than blindly adding the fields, this change adds a hook for out-of-tree platforms to extend the data in nativeEvent payload for Fabric Touch events.
Changelog:
[General] [Added] - Support customization of underlying Touch event representation in out-of-tree platforms
Differential Revision: D47896016