RN: Support Private Methods & Properties #39318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49029339 |
Base commit: 48c297e |
|
This pull request was exported from Phabricator. Differential Revision: D49029339 |
yungsters
force-pushed
the
export-D49029339
branch
from
c10b715
to
13e705c
Compare
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 8, 2023
Summary: Pull Request resolved: facebook#39318 Updates `react-native/babel-preset` to support private methods and properties. Changelog: [General][Added] Added plugins for private methods and properties to `react-native/babel-preset`. Reviewed By: asiandrummer Differential Revision: D49029339 fbshipit-source-id: e3194ebf2e058acb77662e83f943fbd5dbe4ec77
|
This pull request was exported from Phabricator. Differential Revision: D49029339 |
yungsters
force-pushed
the
export-D49029339
branch
from
13e705c
to
8bd19fa
Compare
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 11, 2023
Summary: Pull Request resolved: facebook#39318 Updates `react-native/babel-preset` to support private methods and properties. Changelog: [General][Added] Added plugins for private methods and properties to `react-native/babel-preset`. Reviewed By: asiandrummer Differential Revision: D49029339 fbshipit-source-id: 5982605383702979b4598323c4bde9a9e8b12ab3
|
This pull request was exported from Phabricator. Differential Revision: D49029339 |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 11, 2023
Summary: Pull Request resolved: facebook#39318 Updates `react-native/babel-preset` to support private methods and properties. Changelog: [General][Added] Added plugins for private methods and properties to `react-native/babel-preset`. Reviewed By: asiandrummer Differential Revision: D49029339 fbshipit-source-id: 09067c741ba2007127106fa4bb29fcd175c36c4b
yungsters
force-pushed
the
export-D49029339
branch
from
8bd19fa
to
9c1a80b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49029339 |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 11, 2023
Summary: Pull Request resolved: facebook#39318 Updates `react-native/babel-preset` to support private methods and properties. Changelog: [General][Added] Added plugins for private methods and properties to `react-native/babel-preset`. Reviewed By: asiandrummer Differential Revision: D49029339 fbshipit-source-id: e3a06bd8d2f5ae74aca749acaa5c9b8fd1839421
yungsters
force-pushed
the
export-D49029339
branch
from
9c1a80b
to
a69f65a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49029339 |
yungsters
force-pushed
the
export-D49029339
branch
from
a69f65a
to
33a131e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49029339 |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 11, 2023
Summary: Pull Request resolved: facebook#39318 Updates `react-native/babel-preset` to support private methods and properties. Changelog: [General][Added] Added plugins for private methods and properties to `react-native/babel-preset`. Reviewed By: asiandrummer Differential Revision: D49029339 fbshipit-source-id: 3b6595977b8a761780cea7558c23cb3eb07ad05f
yungsters
force-pushed
the
export-D49029339
branch
from
33a131e
to
f291982
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49029339 |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 11, 2023
Summary: Pull Request resolved: facebook#39318 Updates `react-native/babel-preset` to support private methods and properties. Changelog: [General][Added] Added plugins for private methods and properties to `react-native/babel-preset`. Reviewed By: asiandrummer Differential Revision: D49029339 fbshipit-source-id: b1295ae93ffe88336ba500774f76dbb8ddd43aeb
yungsters
force-pushed
the
export-D49029339
branch
from
f291982
to
13f4c45
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49029339 |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 11, 2023
Summary: Pull Request resolved: facebook#39318 Updates `react-native/babel-preset` to support private methods and properties. Changelog: [General][Added] Added plugins for private methods and properties to `react-native/babel-preset`. Reviewed By: asiandrummer Differential Revision: D49029339 fbshipit-source-id: 1092930d931a2b59ba66b43b6be2e9b1863f14c0
yungsters
force-pushed
the
export-D49029339
branch
from
13f4c45
to
a331caa
Compare
Summary: Pull Request resolved: facebook#39318 Updates `react-native/babel-preset` to support private methods and properties. Changelog: [General][Added] Added plugins for private methods and properties to `react-native/babel-preset`. Reviewed By: asiandrummer Differential Revision: D49029339 fbshipit-source-id: 2df73ad9ee28471ec5cc1c1778a70de060c6945a
|
This pull request was exported from Phabricator. Differential Revision: D49029339 |
yungsters
force-pushed
the
export-D49029339
branch
from
a331caa
to
788e1c0
Compare
|
This pull request has been merged in db4a253. |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 11, 2023
Summary: Switches `EventEmitter` to use a private property. Support for private properties was [only recently added](facebook#39318), so this will be the first end-to-end validation of support in the `facebook/react-native` project. Changelog: [Internal] Differential Revision: D49167908
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 12, 2023
Summary: Pull Request resolved: facebook#39395 Switches `EventEmitter` to use a private property. Support for private properties was [only recently added](facebook#39318), so this will be the first end-to-end validation of support in the `facebook/react-native` project. Changelog: [Internal] Differential Revision: D49167908 fbshipit-source-id: f2e9f9d6e3b73639b92ad6fe9e652aaad20dd3df
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 12, 2023
Summary: Switches `EventEmitter` to use a private property. Support for private properties was [only recently added](facebook#39318), so this will be the first end-to-end validation of support in the `facebook/react-native` project. Changelog: [Internal] Reviewed By: voideanvalue Differential Revision: D49167908
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
Summary: Pull Request resolved: #39395 Switches `EventEmitter` to use a private property. Support for private properties was [only recently added](#39318), so this will be the first end-to-end validation of support in the `facebook/react-native` project. Changelog: [Internal] Reviewed By: voideanvalue Differential Revision: D49167908 fbshipit-source-id: 6a496ed130bfe5671663166626b1acbd80b0e9c3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Updates
react-native/babel-presetto support private methods and properties.Changelog:
[General][Added] Added plugins for private methods and properties to
react-native/babel-preset.Differential Revision: D49029339