RN: Use a Private Property in EventEmitter
#39395
Closed
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49167908 |
|
This pull request was exported from Phabricator. Differential Revision: D49167908 |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 12, 2023
Summary: Pull Request resolved: facebook#39395 Switches `EventEmitter` to use a private property. Support for private properties was [only recently added](facebook#39318), so this will be the first end-to-end validation of support in the `facebook/react-native` project. Changelog: [Internal] Differential Revision: D49167908 fbshipit-source-id: f2e9f9d6e3b73639b92ad6fe9e652aaad20dd3df
yungsters
force-pushed
the
export-D49167908
branch
from
ce5ac71
to
89b39f1
Compare
Summary: Switches `EventEmitter` to use a private property. Support for private properties was [only recently added](facebook#39318), so this will be the first end-to-end validation of support in the `facebook/react-native` project. Changelog: [Internal] Reviewed By: voideanvalue Differential Revision: D49167908
|
This pull request was exported from Phabricator. Differential Revision: D49167908 |
yungsters
force-pushed
the
export-D49167908
branch
from
89b39f1
to
e8fc708
Compare
|
This pull request has been merged in 06b5c6e. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Switches
EventEmitterto use a private property.Support for private properties was only recently added, so this will be the first end-to-end validation of support in the
facebook/react-nativeproject.Changelog:
[Internal]
Differential Revision: D49167908