Remove unused canLoadFile function from HermesExecutor.java
#39481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49320244 |
Base commit: 0ab8b40 |
…ok#39481) Summary: This function is hardcoded to `true` and is never used, so I'm removing it. I found no relevant usages in OSS so that can probably go. Also see: facebook#39292 where it got reported. Changelog: [Android] [Removed] - Remove unused `canLoadFile` function from HermesExecutor.java Reviewed By: yungsters, mdvacca Differential Revision: D49320244
|
This pull request was exported from Phabricator. Differential Revision: D49320244 |
cortinico
force-pushed
the
export-D49320244
branch
from
21d26a8 to
44ae23c
Compare
|
This pull request has been merged in 1b7e26c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This function is hardcoded to
trueand is never used, so I'm removing it.I found no relevant usages in OSS so that can probably go.
Also see: #39292 where it got reported.
Changelog:
[Android] [Removed] - Remove unused
canLoadFilefunction from HermesExecutor.javaReviewed By: yungsters
Differential Revision: D49320244